From: "Dong, Eric" <eric.dong@intel.com>
To: devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Default avoid print.
Date: Wed, 31 Jul 2019 15:35:02 +0800 [thread overview]
Message-ID: <20190731073502.24640-3-eric.dong@intel.com> (raw)
In-Reply-To: <20190731073502.24640-1-eric.dong@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984
Current debug message brings much restriction for the platform
which use this driver.
For PEI and DXE phase, platform mush link base DebugLib (without
using any pei/dxe services, even for its dependent libraries).
This patch default disable this debug message, only open it when
need to debug the related code.
Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
index 2cfc61b2c6..b8cbc3a9d1 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
@@ -1,7 +1,7 @@
/** @file
Code for Processor S3 restoration
-Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -90,7 +90,9 @@ UINT8 mApHltLoopCodeTemplate[] = {
0xEB, 0xFC // jmp $-2
};
+GLOBAL_REMOVE_IF_UNREFERENCED
CHAR16 *mRegisterTypeStr[] = {L"MSR", L"CR", L"MMIO", L"CACHE", L"SEMAP", L"INVALID" };
+#define DEBUG_AP_MSG 0
/**
Sync up the MTRR values for all processors.
@@ -209,7 +211,7 @@ ProgramProcessorRegister (
ApLocation->Core * CpuStatus->MaxThreadCount +
ApLocation->Thread;
DEBUG ((
- DEBUG_INFO,
+ DEBUG_AP_MSG,
"Processor = %lu, Entry Index %lu, Type = %s!\n",
(UINT64)ThreadIndex,
(UINT64)Index,
--
2.21.0.windows.1
next prev parent reply other threads:[~2019-07-31 7:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 7:35 [Patch 0/2] UefiCpuPkg: Default avoid print Dong, Eric
2019-07-31 7:35 ` [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: " Dong, Eric
2019-07-31 7:35 ` Dong, Eric [this message]
2019-07-31 12:43 ` [Patch 0/2] UefiCpuPkg: " Laszlo Ersek
2019-07-31 16:34 ` [edk2-devel] " Brian J. Johnson
2019-07-31 18:06 ` Andrew Fish
2019-07-31 18:58 ` Laszlo Ersek
2019-07-31 22:04 ` Johnson, Michael
2019-08-02 0:12 ` Laszlo Ersek
2019-08-01 20:20 ` Brian J. Johnson
2019-08-01 21:14 ` Andrew Fish
2019-08-02 21:45 ` Laszlo Ersek
2019-08-01 7:51 ` Ni, Ray
2019-08-01 9:07 ` Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731073502.24640-3-eric.dong@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox