* [PATCH 0/3] Enhance ESRT to support multiple controllers @ 2019-07-31 14:59 Eric Jin 2019-07-31 21:03 ` [edk2-devel] " Laszlo Ersek 2019-08-05 6:19 ` Wu, Hao A 0 siblings, 2 replies; 6+ messages in thread From: Eric Jin @ 2019-07-31 14:59 UTC (permalink / raw) To: devel Multiple Controllers Support solution REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 The patch set is to makes enhancement to the ESRT when multiple same controllers exist in one system. Eric Jin (3): MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 +++++++++++++------- 1 file changed, 257 insertions(+), 137 deletions(-) -- 2.20.1.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers 2019-07-31 14:59 [PATCH 0/3] Enhance ESRT to support multiple controllers Eric Jin @ 2019-07-31 21:03 ` Laszlo Ersek 2019-08-05 8:09 ` Eric Jin 2019-08-05 6:19 ` Wu, Hao A 1 sibling, 1 reply; 6+ messages in thread From: Laszlo Ersek @ 2019-07-31 21:03 UTC (permalink / raw) To: eric.jin; +Cc: devel On 07/31/19 16:59, Eric Jin wrote: > Multiple Controllers Support solution > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 > > The patch set is to makes enhancement to the ESRT when multiple > same controllers exist in one system. > > Eric Jin (3): > MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT > MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT > MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance > > MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 +++++++++++++------- > 1 file changed, 257 insertions(+), 137 deletions(-) > Not a comment on the patches themselves, just a workflow suggestion for *future* postings: please enable shallow threading in git. git config sendemail.thread true git config sendemail.chainreplyto false Thanks Laszlo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers 2019-07-31 21:03 ` [edk2-devel] " Laszlo Ersek @ 2019-08-05 8:09 ` Eric Jin 0 siblings, 0 replies; 6+ messages in thread From: Eric Jin @ 2019-08-05 8:09 UTC (permalink / raw) To: Laszlo Ersek; +Cc: devel@edk2.groups.io Hi Laszlo, Thank you for the suggestion. Will set them in git. Best Regards Eric -----Original Message----- From: Laszlo Ersek <lersek@redhat.com> Sent: Thursday, August 1, 2019 5:03 AM To: Jin, Eric <eric.jin@intel.com> Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers On 07/31/19 16:59, Eric Jin wrote: > Multiple Controllers Support solution > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 > > The patch set is to makes enhancement to the ESRT when multiple same > controllers exist in one system. > > Eric Jin (3): > MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT > MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT > MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance > > MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 > +++++++++++++------- > 1 file changed, 257 insertions(+), 137 deletions(-) > Not a comment on the patches themselves, just a workflow suggestion for *future* postings: please enable shallow threading in git. git config sendemail.thread true git config sendemail.chainreplyto false Thanks Laszlo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers 2019-07-31 14:59 [PATCH 0/3] Enhance ESRT to support multiple controllers Eric Jin 2019-07-31 21:03 ` [edk2-devel] " Laszlo Ersek @ 2019-08-05 6:19 ` Wu, Hao A 2019-08-05 8:15 ` Eric Jin 2019-08-07 12:39 ` Laszlo Ersek 1 sibling, 2 replies; 6+ messages in thread From: Wu, Hao A @ 2019-08-05 6:19 UTC (permalink / raw) To: devel@edk2.groups.io, Jin, Eric Cc: Gao, Liming, Kinney, Michael D, afish@apple.com, lersek@redhat.com, leif.lindholm@linaro.org > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Eric Jin > Sent: Wednesday, July 31, 2019 10:59 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple > controllers > > Multiple Controllers Support solution > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 > > The patch set is to makes enhancement to the ESRT when multiple > same controllers exist in one system. > > Eric Jin (3): > MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT > MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT > MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance Hello Eric, After looking into the series, I found that patches 2/3 & 3/3 are actually addressing issues introduced by the 1/3 patch. It looks to me that these 3 patches should be squashed into 1 commit, since they all focus on adding a feature for ESRT to support multiple controllers. However, originally, the 3 separate commits come from the edk2-staging repository, so I am not very sure what approach should be adopted when merging them back to the edk2 repo master branch. (Includes the stewards here for suggestions.) My personal preference is to merge them together as one patch. Best Regards, Hao Wu > > MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 +++++++++++++--- > ---- > 1 file changed, 257 insertions(+), 137 deletions(-) > > -- > 2.20.1.windows.1 > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers 2019-08-05 6:19 ` Wu, Hao A @ 2019-08-05 8:15 ` Eric Jin 2019-08-07 12:39 ` Laszlo Ersek 1 sibling, 0 replies; 6+ messages in thread From: Eric Jin @ 2019-08-05 8:15 UTC (permalink / raw) To: Wu, Hao A, devel@edk2.groups.io Cc: Gao, Liming, Kinney, Michael D, afish@apple.com, lersek@redhat.com, leif.lindholm@linaro.org Hao, Thank you for the suggestion. I have sent the patch v2 out and merge series to one patch. Let's wait one day to follow the possible comments from stewards. Thanks. Best Regards Eric -----Original Message----- From: Wu, Hao A <hao.a.wu@intel.com> Sent: Monday, August 5, 2019 2:20 PM To: devel@edk2.groups.io; Jin, Eric <eric.jin@intel.com> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; lersek@redhat.com; leif.lindholm@linaro.org Subject: RE: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Eric Jin > Sent: Wednesday, July 31, 2019 10:59 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple > controllers > > Multiple Controllers Support solution > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 > > The patch set is to makes enhancement to the ESRT when multiple same > controllers exist in one system. > > Eric Jin (3): > MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT > MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT > MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance Hello Eric, After looking into the series, I found that patches 2/3 & 3/3 are actually addressing issues introduced by the 1/3 patch. It looks to me that these 3 patches should be squashed into 1 commit, since they all focus on adding a feature for ESRT to support multiple controllers. However, originally, the 3 separate commits come from the edk2-staging repository, so I am not very sure what approach should be adopted when merging them back to the edk2 repo master branch. (Includes the stewards here for suggestions.) My personal preference is to merge them together as one patch. Best Regards, Hao Wu > > MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 394 +++++++++++++--- > ---- > 1 file changed, 257 insertions(+), 137 deletions(-) > > -- > 2.20.1.windows.1 > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers 2019-08-05 6:19 ` Wu, Hao A 2019-08-05 8:15 ` Eric Jin @ 2019-08-07 12:39 ` Laszlo Ersek 1 sibling, 0 replies; 6+ messages in thread From: Laszlo Ersek @ 2019-08-07 12:39 UTC (permalink / raw) To: Wu, Hao A, devel@edk2.groups.io, Jin, Eric Cc: Gao, Liming, Kinney, Michael D, afish@apple.com, leif.lindholm@linaro.org On 08/05/19 08:19, Wu, Hao A wrote: >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Eric Jin >> Sent: Wednesday, July 31, 2019 10:59 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple >> controllers >> >> Multiple Controllers Support solution >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 >> >> The patch set is to makes enhancement to the ESRT when multiple >> same controllers exist in one system. >> >> Eric Jin (3): >> MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT >> MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT >> MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance > > > Hello Eric, > > After looking into the series, I found that patches 2/3 & 3/3 are actually > addressing issues introduced by the 1/3 patch. It looks to me that these > 3 patches should be squashed into 1 commit, since they all focus on adding > a feature for ESRT to support multiple controllers. > > However, originally, the 3 separate commits come from the edk2-staging > repository, so I am not very sure what approach should be adopted when > merging them back to the edk2 repo master branch. > > (Includes the stewards here for suggestions.) > > My personal preference is to merge them together as one patch. Sorry about the late response. I certainly agree that a single patch series should avoid introducing a bug or esp. regression, just for another patch in the same series to fix it up. In that case, both halves indeed belong to a single patch. However, speaking generally (not knowing any specifics here), that doesn't mean that everything should be squashed into a single patch. The series (speaking generally) should still have a fine-grained structure; each patch should do as little, and as well isolated, as reasonably possible. Thanks Laszlo ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-07 12:39 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-07-31 14:59 [PATCH 0/3] Enhance ESRT to support multiple controllers Eric Jin 2019-07-31 21:03 ` [edk2-devel] " Laszlo Ersek 2019-08-05 8:09 ` Eric Jin 2019-08-05 6:19 ` Wu, Hao A 2019-08-05 8:15 ` Eric Jin 2019-08-07 12:39 ` Laszlo Ersek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox