From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: devel@edk2.groups.io
Cc: Jaben Carsey <jaben.carsey@intel.com>, Ray Ni <ray.ni@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: [Patch v3 1/2] ShellPkg/AcpiView: Fix IA32 link error
Date: Fri, 2 Aug 2019 18:46:54 -0700 [thread overview]
Message-ID: <20190803014655.11184-2-michael.d.kinney@intel.com> (raw)
In-Reply-To: <20190803014655.11184-1-michael.d.kinney@intel.com>
https://bugzilla.tianocore.org/show_bug.cgi?id=1970
Update SLIT_ELEMENT() macro to use MultU64x64() to
perform multiplication on 64-bit operands. This is
required to avoid use of an intrinsic on IA32 VS20xx
builds.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.../UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c
index 1f9dac66ee..ca2808db52 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c
@@ -30,7 +30,7 @@ STATIC CONST ACPI_PARSER SlitParser[] = {
/**
Macro to get the value of a System Locality
**/
-#define SLIT_ELEMENT(Ptr, i, j) *(Ptr + (i * LocalityCount) + j)
+#define SLIT_ELEMENT(Ptr, i, j) *(Ptr + (MultU64x64 (i, LocalityCount)) + j)
/**
This function parses the ACPI SLIT table.
--
2.21.0.windows.1
next prev parent reply other threads:[~2019-08-03 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 1:46 [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview Michael D Kinney
2019-08-03 1:46 ` Michael D Kinney [this message]
2019-08-03 1:46 ` [Patch v3 2/2] ShellPkg: Add shell with all commands integrated Michael D Kinney
2019-08-05 0:51 ` [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview Gao, Zhichao
2019-08-05 10:47 ` [edk2-devel] " Sami Mujawar
2019-08-05 20:28 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190803014655.11184-2-michael.d.kinney@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox