From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: michael.d.kinney@intel.com) Received: from mga04.intel.com (mga04.intel.com []) by groups.io with SMTP; Fri, 02 Aug 2019 18:46:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2019 18:46:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,340,1559545200"; d="scan'208";a="257151893" Received: from mdkinney-mobl2.amr.corp.intel.com ([10.251.130.221]) by orsmga001.jf.intel.com with ESMTP; 02 Aug 2019 18:46:58 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Jaben Carsey , Ray Ni , Zhichao Gao , Sami Mujawar Subject: [Patch v3 1/2] ShellPkg/AcpiView: Fix IA32 link error Date: Fri, 2 Aug 2019 18:46:54 -0700 Message-Id: <20190803014655.11184-2-michael.d.kinney@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20190803014655.11184-1-michael.d.kinney@intel.com> References: <20190803014655.11184-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit https://bugzilla.tianocore.org/show_bug.cgi?id=1970 Update SLIT_ELEMENT() macro to use MultU64x64() to perform multiplication on 64-bit operands. This is required to avoid use of an intrinsic on IA32 VS20xx builds. Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Michael D Kinney --- .../UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c index 1f9dac66ee..ca2808db52 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c @@ -30,7 +30,7 @@ STATIC CONST ACPI_PARSER SlitParser[] = { /** Macro to get the value of a System Locality **/ -#define SLIT_ELEMENT(Ptr, i, j) *(Ptr + (i * LocalityCount) + j) +#define SLIT_ELEMENT(Ptr, i, j) *(Ptr + (MultU64x64 (i, LocalityCount)) + j) /** This function parses the ACPI SLIT table. -- 2.21.0.windows.1