From: "Dong, Eric" <eric.dong@intel.com>
To: devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.
Date: Mon, 5 Aug 2019 14:43:57 +0800 [thread overview]
Message-ID: <20190805064359.29332-2-eric.dong@intel.com> (raw)
In-Reply-To: <20190805064359.29332-1-eric.dong@intel.com>
This debug message may be called by BSP and APs. It may
caused ASSERT when APs call this debug code.
In order to avoid system boot assert, Remove this debug
message.
Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
---
.../CpuFeaturesInitialize.c | 22 -------------------
1 file changed, 22 deletions(-)
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
index 4e97e863c7..fb0535edd6 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
@@ -9,7 +9,6 @@
#include "RegisterCpuFeatures.h"
CHAR16 *mDependTypeStr[] = {L"None", L"Thread", L"Core", L"Package", L"Invalid" };
-CHAR16 *mRegisterTypeStr[] = {L"MSR", L"CR", L"MMIO", L"CACHE", L"SEMAP", L"INVALID" };
/**
Worker function to save PcdCpuFeaturesCapability.
@@ -772,7 +771,6 @@ ProgramProcessorRegister (
UINT32 PackageThreadsCount;
UINT32 CurrentThread;
UINTN ProcessorIndex;
- UINTN ThreadIndex;
UINTN ValidThreadCount;
UINT32 *ValidCoreCountPerPackage;
@@ -785,26 +783,6 @@ ProgramProcessorRegister (
RegisterTableEntry = &RegisterTableEntryHead[Index];
- DEBUG_CODE_BEGIN ();
- //
- // Wait for the AP to release the MSR spin lock.
- //
- while (!AcquireSpinLockOrFail (&CpuFlags->ConsoleLogLock)) {
- CpuPause ();
- }
- ThreadIndex = ApLocation->Package * CpuStatus->MaxCoreCount * CpuStatus->MaxThreadCount +
- ApLocation->Core * CpuStatus->MaxThreadCount +
- ApLocation->Thread;
- DEBUG ((
- DEBUG_INFO,
- "Processor = %08lu, Index %08lu, Type = %s!\n",
- (UINT64)ThreadIndex,
- (UINT64)Index,
- mRegisterTypeStr[MIN ((REGISTER_TYPE)RegisterTableEntry->RegisterType, InvalidReg)]
- ));
- ReleaseSpinLock (&CpuFlags->ConsoleLogLock);
- DEBUG_CODE_END ();
-
//
// Check the type of specified register
//
--
2.21.0.windows.1
next prev parent reply other threads:[~2019-08-05 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 6:43 [Patch v2 0/2] UefiCpuPkg: Remove debug message Dong, Eric
2019-08-05 6:43 ` Dong, Eric [this message]
2019-08-07 17:17 ` [edk2-devel] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: " rebecca
2019-08-08 18:53 ` Laszlo Ersek
2019-08-05 6:43 ` [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: " Dong, Eric
2019-08-05 9:21 ` [Patch v2 0/2] UefiCpuPkg: " Ni, Ray
2019-08-07 17:11 ` Laszlo Ersek
2019-08-07 18:14 ` Laszlo Ersek
2019-08-08 0:07 ` Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805064359.29332-2-eric.dong@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox