From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: eric.dong@intel.com) Received: from mga17.intel.com (mga17.intel.com []) by groups.io with SMTP; Sun, 04 Aug 2019 23:44:02 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2019 23:44:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,348,1559545200"; d="scan'208";a="175501281" Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.133]) by fmsmga007.fm.intel.com with ESMTP; 04 Aug 2019 23:44:01 -0700 From: "Dong, Eric" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek Subject: [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message. Date: Mon, 5 Aug 2019 14:43:57 +0800 Message-Id: <20190805064359.29332-2-eric.dong@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20190805064359.29332-1-eric.dong@intel.com> References: <20190805064359.29332-1-eric.dong@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This debug message may be called by BSP and APs. It may caused ASSERT when APs call this debug code. In order to avoid system boot assert, Remove this debug message. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek --- .../CpuFeaturesInitialize.c | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c index 4e97e863c7..fb0535edd6 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c @@ -9,7 +9,6 @@ #include "RegisterCpuFeatures.h" CHAR16 *mDependTypeStr[] = {L"None", L"Thread", L"Core", L"Package", L"Invalid" }; -CHAR16 *mRegisterTypeStr[] = {L"MSR", L"CR", L"MMIO", L"CACHE", L"SEMAP", L"INVALID" }; /** Worker function to save PcdCpuFeaturesCapability. @@ -772,7 +771,6 @@ ProgramProcessorRegister ( UINT32 PackageThreadsCount; UINT32 CurrentThread; UINTN ProcessorIndex; - UINTN ThreadIndex; UINTN ValidThreadCount; UINT32 *ValidCoreCountPerPackage; @@ -785,26 +783,6 @@ ProgramProcessorRegister ( RegisterTableEntry = &RegisterTableEntryHead[Index]; - DEBUG_CODE_BEGIN (); - // - // Wait for the AP to release the MSR spin lock. - // - while (!AcquireSpinLockOrFail (&CpuFlags->ConsoleLogLock)) { - CpuPause (); - } - ThreadIndex = ApLocation->Package * CpuStatus->MaxCoreCount * CpuStatus->MaxThreadCount + - ApLocation->Core * CpuStatus->MaxThreadCount + - ApLocation->Thread; - DEBUG (( - DEBUG_INFO, - "Processor = %08lu, Index %08lu, Type = %s!\n", - (UINT64)ThreadIndex, - (UINT64)Index, - mRegisterTypeStr[MIN ((REGISTER_TYPE)RegisterTableEntry->RegisterType, InvalidReg)] - )); - ReleaseSpinLock (&CpuFlags->ConsoleLogLock); - DEBUG_CODE_END (); - // // Check the type of specified register // -- 2.21.0.windows.1