From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"jsd@semihalf.com" <jsd@semihalf.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Kostya Porotchkin <kostap@marvell.com>
Subject: Re: [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400
Date: Mon, 5 Aug 2019 12:35:01 +0100 [thread overview]
Message-ID: <20190805113501.GC25813@bivouac.eciton.net> (raw)
In-Reply-To: <20190711084500.evh7zwzrnawz2yne@bivouac.eciton.net>
Hi Marcin,
On Thu, Jul 11, 2019 at 09:45:00AM +0100, Leif Lindholm wrote:
> > > > On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> > > > > Ensure that in case of SlowMode or 3.3V operation,
> > > > > also the HS400 capability will be disabled in the
> > > > > SdMmc driver.
> > > > >
> > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > >
> > > > Well done on keeping this tag. But I'm thinking we need to do that
> > > > relicensing sooner rather than later, and drop the tag.
> > >
> > > I left it, as this file is still not 2-clause SPDX tagged.
> > >
> > > >
> > > >
> > > > However, can you clarify what problem this solves?
> > > >
> > >
> > > On another SoC revision, the capability register marks HS400 support
> > > as enabled. However the interface itself is powered with 3.3V and it
> > > turned out that my flags in SdMmcOverride driver did not cover this
> > > case, which resulted in an unsuccessful EmmcSwitchToHS400 () execution
> > > - it shouldn't be done at all.
> > >
> >
> > Did you have a chance to see my explanation? Should I repost?
>
> Sorry, yes. Explanation is fine. If you can update the commit message
> and drop the Contributed-under, I will push this once we get the
> licenses updated.
Licenses have now been updated.
Can you please resubmit with the updated commit message and dropped
Contributed-under?
Best Regards,
Leif
prev parent reply other threads:[~2019-08-05 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 7:04 [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400 Marcin Wojtas
2019-06-26 9:31 ` Leif Lindholm
2019-06-26 9:58 ` Marcin Wojtas
2019-07-11 8:07 ` Marcin Wojtas
2019-07-11 8:45 ` Leif Lindholm
2019-08-05 11:35 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805113501.GC25813@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox