From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=nRLQ7lp6;
 spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65])
 by groups.io with SMTP; Mon, 05 Aug 2019 04:35:05 -0700
Received: by mail-wr1-f65.google.com with SMTP id f9so5142392wre.12
        for <devel@edk2.groups.io>; Mon, 05 Aug 2019 04:35:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=NF2F1y6lbJlsskdHQB13vVF0nU9TPRAFwrCCQh6p91M=;
        b=nRLQ7lp6GtZ/zu2QWcI1ZEmJBJl0LM+P4FV3uRzWdkUldmyl7g166qNyQgp2eaUC9j
         cNEXRwjrRlGLT+pK/czOGeN/8kEgz2rrsbwexBi6q1Zva2KqkPxsma3MX8T0r5CU7K/C
         8h6UVzYU9hgUSOhCFFbt1+ZUbKyGuxKszYVk5nsbm12sHFOif/PCWgiHCgIumMtaezZw
         rT9G+MH/8TI75lQQlWyxgD5OGmb90o42ZK9UF5Oz8Da+DDbo2E49t/YSfnZVxM0jnaza
         u2XGTsIdKNMX2T2rSpE40Bs1pFQcXcLdLHN++2teCpRjExxZeXH0JthXCTxBkEYXMU/e
         r4dQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=NF2F1y6lbJlsskdHQB13vVF0nU9TPRAFwrCCQh6p91M=;
        b=J0x9gRQxN2aUyITbEQJYZCMcUlqj76ieU2DhpkBQ9lc3CaqsQEz0TpDCRYIMWsboAw
         xuU4D1TicxLloIQl7vty9S8nBXSN+Dw4VgeJy0K+aq/XDPJ5YyQCpbxjms7FH4T06Fzo
         LudTxoLIGx7kF+Ucb/pM9utGsNp07h2yecRzaUZeEldEqmolGFNR/B6Gf0fmBK1Ekxen
         mh1ZD9HqeQQuJOoC9rmvxxnO0yjcfuLzZPpXRYuEMjZBzP2YHVF0fLz9nuWxo8a5buN8
         XQL9gwAUtedL2fnVDodmICH1PF7f4HGGmxNQ/0oEqaxiyEGdH+EzgZoMclYNGXFt32fi
         UYCA==
X-Gm-Message-State: APjAAAXKNOTd1WH3AlgMwYP5nC+05/vTkSLhysHd1G9t7gldzbN3D7s4
	BC1npdqBxKqrLSig66FRgZNY2Q==
X-Google-Smtp-Source: APXvYqwHUM+IKxMyXyOfxuS1bKzWe8S3yfkKkOgCm4Rg7xUBUattZf1+DZPddk6hcygO/cODbLuLuw==
X-Received: by 2002:adf:f60a:: with SMTP id t10mr127535826wrp.258.1565004903708;
        Mon, 05 Aug 2019 04:35:03 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id s188sm78200718wmf.40.2019.08.05.04.35.02
        (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
        Mon, 05 Aug 2019 04:35:02 -0700 (PDT)
Date: Mon, 5 Aug 2019 12:35:01 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"jsd@semihalf.com" <jsd@semihalf.com>,
	Grzegorz Jaszczyk <jaz@semihalf.com>,
	Kostya Porotchkin <kostap@marvell.com>
Subject: Re: [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400
Message-ID: <20190805113501.GC25813@bivouac.eciton.net>
References: <1561532654-6277-1-git-send-email-mw@semihalf.com>
 <20190626093155.bjetr56imew7q74v@bivouac.eciton.net>
 <CAPv3WKedP_wGc+8c_-JBqt8C4Pas==me6efFUpdd3iOuoFuwyw@mail.gmail.com>
 <CAPv3WKfjA3vivkU0QRAcFkTG7H4M3i1toC4drQjXZSyzzNJY4w@mail.gmail.com>
 <20190711084500.evh7zwzrnawz2yne@bivouac.eciton.net>
MIME-Version: 1.0
In-Reply-To: <20190711084500.evh7zwzrnawz2yne@bivouac.eciton.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Marcin,

On Thu, Jul 11, 2019 at 09:45:00AM +0100, Leif Lindholm wrote:
> > > > On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> > > > > Ensure that in case of SlowMode or 3.3V operation,
> > > > > also the HS400 capability will be disabled in the
> > > > > SdMmc driver.
> > > > >
> > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > >
> > > > Well done on keeping this tag. But I'm thinking we need to do that
> > > > relicensing sooner rather than later, and drop the tag.
> > >
> > > I left it, as this file is still not 2-clause SPDX tagged.
> > >
> > > >
> > > >
> > > > However, can you clarify what problem this solves?
> > > >
> > >
> > > On another SoC revision, the capability register marks HS400 support
> > > as enabled. However the interface itself is powered with 3.3V and it
> > > turned out that my flags in SdMmcOverride driver did not cover this
> > > case, which resulted in an unsuccessful EmmcSwitchToHS400 () execution
> > > - it shouldn't be done at all.
> > >
> > 
> > Did you have a chance to see my explanation? Should I repost?
> 
> Sorry, yes. Explanation is fine. If you can update the commit message
> and drop the Contributed-under, I will push this once we get the
> licenses updated.

Licenses have now been updated.
Can you please resubmit with the updated commit message and dropped
Contributed-under?

Best Regards,

Leif