* [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add missing description for parameter
@ 2019-08-06 2:17 Zhang, Shenglei
2019-08-07 8:24 ` Wu, Hao A
0 siblings, 1 reply; 2+ messages in thread
From: Zhang, Shenglei @ 2019-08-06 2:17 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Hao A Wu
The description of parameter CapFileName is missing in comments.
So add the description.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
index 2cecc87385b3..f2cd0ad3e816 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
@@ -136,6 +136,7 @@ UINT32 mCapsuleTotalNumber;
Caution: This function may receive untrusted input.
@param[in] CapsuleHeader Points to a capsule header.
+ @param[in] CapFileName Capsule file name.
@param[out] ResetRequired Indicates whether reset is required or not.
@retval EFI_SUCESS Process Capsule Image successfully.
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add missing description for parameter
2019-08-06 2:17 [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add missing description for parameter Zhang, Shenglei
@ 2019-08-07 8:24 ` Wu, Hao A
0 siblings, 0 replies; 2+ messages in thread
From: Wu, Hao A @ 2019-08-07 8:24 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Wang, Jian J
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Tuesday, August 06, 2019 10:18 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add missing
> description for parameter
>
> The description of parameter CapFileName is missing in comments.
> So add the description.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
Hello,
One comment that is not related with the patch itself.
In the future, please help to run the 'GetMaintainer.py' script under
BaseTools/Scripts/ to get the CC list when proposing a patch in the
MdeModulePkg.
For the patch:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
And the pushed via commit 111bbcf876.
Best Regards,
Hao Wu
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
> b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
> index 2cecc87385b3..f2cd0ad3e816 100644
> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c
> @@ -136,6 +136,7 @@ UINT32 mCapsuleTotalNumber;
> Caution: This function may receive untrusted input.
>
> @param[in] CapsuleHeader Points to a capsule header.
> + @param[in] CapFileName Capsule file name.
> @param[out] ResetRequired Indicates whether reset is required or not.
>
> @retval EFI_SUCESS Process Capsule Image successfully.
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-07 8:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-06 2:17 [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add missing description for parameter Zhang, Shenglei
2019-08-07 8:24 ` Wu, Hao A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox