From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.155.168, mailfrom: roger.pau@citrix.com) Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by groups.io with SMTP; Wed, 07 Aug 2019 07:28:40 -0700 Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: hQYCQbWIZnordqryp9+l1l5LaN4Sr3AU1hoH+2odvoIQX9MKqwZyOWMFVKvj+WkXq9s4G0SF9x WnD3Et7O703brtDWLhfN70AnOe176oHEex+ucN38lVdxjzE0JEe75Vqf7e6CEuq76+zXulwx+G HiHcy4EG9fehFdZTLw/aBOoPPFRZoahFZGsHz2mBSeGjMXTtcxudTeCpccIz6Avw9KwqHaNe5t 9O8kFrlvtOPYVU8f9CN+H+MynqCrgt4iPLnj0OkyAeZ6Z2gdpOYRu2pInzSMALY1fsPrG6AdFt Oag= X-SBRS: 2.7 X-MesageID: 4113115 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,357,1559534400"; d="scan'208";a="4113115" Date: Wed, 7 Aug 2019 16:25:14 +0200 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= To: Anthony PERARD CC: , Julien Grall , , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Andrew Cooper Subject: Re: [PATCH v4 09/35] OvmfPkg/OvmfXen: use a TimerLib instance that depends only on the CPU Message-ID: <20190807142514.hhfniahggy5npll6@Air-de-Roger> References: <20190729153944.24239-1-anthony.perard@citrix.com> <20190729153944.24239-10-anthony.perard@citrix.com> MIME-Version: 1.0 In-Reply-To: <20190729153944.24239-10-anthony.perard@citrix.com> User-Agent: NeoMutt/20180716 Return-Path: roger.pau@citrix.com X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Jul 29, 2019 at 04:39:18PM +0100, Anthony PERARD wrote: > The ACPI Timer isn't present in a PVH guest, but local APIC works on > both PVH and HVM. > > Note that the use of SecPeiDxeTimerLibCpu might be an issue with a > driver of type DXE_RUNTIME_DRIVER. I've attempted to find out which of > the DXE_RUNTIME_DRIVER uses the TimerLib at runtime. I've done that by > replacing the TimerLib evaluation in > [LibraryClasses.common.DXE_RUNTIME_DRIVER] by a different one and > checking every module that uses it (with the --report-file=report > build option). > > ResetSystemRuntimeDxe is calling the TimerLib API at runtime to do the > operation "EfiResetCold", so this may never complete if the OS have > disabled the Local APIC Timer. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Acked-by: Laszlo Ersek > --- > > Notes: > v4: > - reworded the first sentence, use "not present" instead of "don't work". Thanks, I'm afraid I cannot comment on the change itself, but the comment message is accurate now :). Roger.