[PATCH 0/3] Fix warning message issues

[PATCH 0/3] Fix warning message issues

[Zhang, Shenglei]

There are some header files used but not included in INF
files. This causes warings are generated when building the
packages. So now add them into INF files.
https://bugzilla.tianocore.org/show_bug.cgi?id=2036

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Shenglei Zhang (3):
  MdeModulePkg: Add missing header files in INF files
  ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
  IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

 IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf                    | 1 +
 MdeModulePkg/Universal/CapsulePei/CapsulePei.inf           | 1 +
 MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf        | 7 +++++++
 .../UefiShellAcpiViewCommandLib.inf                        | 2 ++
 4 files changed, 11 insertions(+)

-- 
2.18.0.windows.1

[PATCH 1/3] MdeModulePkg: Add missing header files in INF files

[Zhang, Shenglei]

The header files are used but missing in INF,which causes
generating warning message when building them.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdeModulePkg/Universal/CapsulePei/CapsulePei.inf    | 1 +
 MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
index 786c41163304..adf9f1502d69 100644
--- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
+++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
@@ -33,6 +33,7 @@ [Sources]
   UefiCapsule.c
   Capsule.h
   Common/CapsuleCoalesce.c
+  Common/CommonHeader.h
 
 [Packages]
   MdePkg/MdePkg.dec
diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
index af002bd98e99..2a4e256063a6 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
@@ -28,6 +28,13 @@ [Sources]
   EbcDebugger/EdbCommon.h
   EbcDebugger/EdbSupportString.c
   EbcDebugger/EdbSupport.h
+  EbcDebugger/EdbCommand.h
+  EbcDebugger/EdbHook.h
+  EbcDebugger/Edb.h
+  EbcDebugger/EdbDisasmSupport.h
+  EbcDebugger/EdbDisasm.h
+  EbcDebugger/EdbSymbol.h
+  EbcDebuggerHook.h
 
 [Packages]
   MdePkg/MdePkg.dec
-- 
2.18.0.windows.1

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files

[Wu, Hao A]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 08, 2019 2:25 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Gao, Liming
> Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files
> in INF files
> 
> The header files are used but missing in INF,which causes
> generating warning message when building them.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdeModulePkg/Universal/CapsulePei/CapsulePei.inf    | 1 +
>  MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 7 +++++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> index 786c41163304..adf9f1502d69 100644
> --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> @@ -33,6 +33,7 @@ [Sources]
>    UefiCapsule.c
>    Capsule.h
>    Common/CapsuleCoalesce.c
> +  Common/CommonHeader.h


File 'Common/CapsuleCoalesce.c' is referring the header
'Common/CommonHeader.h'.

The patch updates CapsulePei.inf, but there is a similar case in
CapsuleX64.inf as well.

Could you help to check whether such change is needed there?


> 
>  [Packages]
>    MdePkg/MdePkg.dec
> diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> index af002bd98e99..2a4e256063a6 100644
> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> @@ -28,6 +28,13 @@ [Sources]
>    EbcDebugger/EdbCommon.h
>    EbcDebugger/EdbSupportString.c
>    EbcDebugger/EdbSupport.h
> +  EbcDebugger/EdbCommand.h
> +  EbcDebugger/EdbHook.h
> +  EbcDebugger/Edb.h
> +  EbcDebugger/EdbDisasmSupport.h
> +  EbcDebugger/EdbDisasm.h
> +  EbcDebugger/EdbSymbol.h
> +  EbcDebuggerHook.h


Could you help to check whether the below 3 INF files within
MdeModulePkg/Universal/EbcDxe have listed all used files in them?

(At least, I think there might be something missing in EbcDxe.inf)

Best Regards,
Hao Wu


> 
>  [Packages]
>    MdePkg/MdePkg.dec
> --
> 2.18.0.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files

[Zhang, Shenglei]

> -----Original Message-----
> From: Wu, Hao A
> Sent: Monday, August 12, 2019 10:00 AM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header
> files in INF files
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Zhang, Shenglei
> > Sent: Thursday, August 08, 2019 2:25 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J; Wu, Hao A; Gao, Liming
> > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header
> files
> > in INF files
> >
> > The header files are used but missing in INF,which causes
> > generating warning message when building them.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  MdeModulePkg/Universal/CapsulePei/CapsulePei.inf    | 1 +
> >  MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf | 7 +++++++
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> > index 786c41163304..adf9f1502d69 100644
> > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
> > @@ -33,6 +33,7 @@ [Sources]
> >    UefiCapsule.c
> >    Capsule.h
> >    Common/CapsuleCoalesce.c
> > +  Common/CommonHeader.h
> 
> 
> File 'Common/CapsuleCoalesce.c' is referring the header
> 'Common/CommonHeader.h'.
> 
> The patch updates CapsulePei.inf, but there is a similar case in
> CapsuleX64.inf as well.
> 
> Could you help to check whether such change is needed there?
> 
Good point! Indeed it looks strange to add 'Common/CommonHeader.h' only
in CapsulePei.inf but not in CapsuleX64.inf. I'll add it in v2 patch.

> 
> >
> >  [Packages]
> >    MdePkg/MdePkg.dec
> > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> > b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> > index af002bd98e99..2a4e256063a6 100644
> > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebuggerConfig.inf
> > @@ -28,6 +28,13 @@ [Sources]
> >    EbcDebugger/EdbCommon.h
> >    EbcDebugger/EdbSupportString.c
> >    EbcDebugger/EdbSupport.h
> > +  EbcDebugger/EdbCommand.h
> > +  EbcDebugger/EdbHook.h
> > +  EbcDebugger/Edb.h
> > +  EbcDebugger/EdbDisasmSupport.h
> > +  EbcDebugger/EdbDisasm.h
> > +  EbcDebugger/EdbSymbol.h
> > +  EbcDebuggerHook.h
> 
> 
> Could you help to check whether the below 3 INF files within
> MdeModulePkg/Universal/EbcDxe have listed all used files in them?

I'll check them. Potential changes will be included in v2 patch.

Thanks,
Shenglei

> 
> (At least, I think there might be something missing in EbcDxe.inf)
> 
> Best Regards,
> Hao Wu
> 
> 
> >
> >  [Packages]
> >    MdePkg/MdePkg.dec
> > --
> > 2.18.0.windows.1
> >
> >
> > 

[PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF

[Zhang, Shenglei]

MadtParser.h and PpttParser.h are actually used but missing INF file,
which will generate warning message when building this package.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
index e06e2082a197..1e2fa52b00a3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
@@ -43,6 +43,8 @@ [Sources.common]
   Parsers/Srat/SratParser.c
   Parsers/Ssdt/SsdtParser.c
   Parsers/Xsdt/XsdtParser.c
+  Parsers/Madt/MadtParser.h
+  Parsers/Pptt/PpttParser.h
 
 [Packages]
   MdePkg/MdePkg.dec
-- 
2.18.0.windows.1

Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF

[Gao, Zhichao]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 8, 2019 2:25 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib:
> Add missing header files in INF
> 
> MadtParser.h and PpttParser.h are actually used but missing INF file, which
> will generate warning message when building this package.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.inf
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.inf
> index e06e2082a197..1e2fa52b00a3 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.inf
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> +++ andLib.inf
> @@ -43,6 +43,8 @@ [Sources.common]
>    Parsers/Srat/SratParser.c
>    Parsers/Ssdt/SsdtParser.c
>    Parsers/Xsdt/XsdtParser.c
> +  Parsers/Madt/MadtParser.h
> +  Parsers/Pptt/PpttParser.h
> 
>  [Packages]
>    MdePkg/MdePkg.dec
> --
> 2.18.0.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Thanks
-Jaben


> -----Original Message-----
> From: Gao, Zhichao
> Sent: Thursday, August 08, 2019 1:59 AM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH 2/3]
> ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
> 
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Zhang, Shenglei
> > Sent: Thursday, August 8, 2019 2:25 PM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Gao, Zhichao <zhichao.gao@intel.com>
> > Subject: [edk2-devel] [PATCH 2/3]
> ShellPkg/UefiShellAcpiViewCommandLib:
> > Add missing header files in INF
> >
> > MadtParser.h and PpttParser.h are actually used but missing INF file, which
> > will generate warning message when building this package.
> >
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2
> ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.inf
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.inf
> > index e06e2082a197..1e2fa52b00a3 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > andLib.inf
> > +++
> >
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> > +++ andLib.inf
> > @@ -43,6 +43,8 @@ [Sources.common]
> >    Parsers/Srat/SratParser.c
> >    Parsers/Ssdt/SsdtParser.c
> >    Parsers/Xsdt/XsdtParser.c
> > +  Parsers/Madt/MadtParser.h
> > +  Parsers/Pptt/PpttParser.h
> >
> >  [Packages]
> >    MdePkg/MdePkg.dec
> > --
> > 2.18.0.windows.1
> >
> >
> > 

[PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

[Zhang, Shenglei]

SecFsp.h is used but missing inf file, which will cause generating
warning message.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
index 3de09b5b4921..86d3d31d3269 100644
--- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
+++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
@@ -22,6 +22,7 @@ [Defines]
 
 [Sources]
   SecFspApiChk.c
+  SecFsp.h
 
 [Sources.IA32]
   Ia32/Stack.nasm
-- 
2.18.0.windows.1

Re: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

[Chiu, Chasel]

Please extend copyright to 2019 of this file.
With above change Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, August 8, 2019 2:25 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF
> file
> 
> SecFsp.h is used but missing inf file, which will cause generating warning
> message.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> index 3de09b5b4921..86d3d31d3269 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> @@ -22,6 +22,7 @@ [Defines]
> 
>  [Sources]
>    SecFspApiChk.c
> +  SecFsp.h
> 
>  [Sources.IA32]
>    Ia32/Stack.nasm
> --
> 2.18.0.windows.1

Re: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

[Zeng, Star]

Same with Chasel. Reviewed-by: Star Zeng <star.zeng@intel.com>.

> -----Original Message-----
> From: Chiu, Chasel
> Sent: Thursday, August 8, 2019 2:59 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in
> INF file
> 
> 
> Please extend copyright to 2019 of this file.
> With above change Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> 
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Thursday, August 8, 2019 2:25 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> > Subject: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file
> > in INF file
> >
> > SecFsp.h is used but missing inf file, which will cause generating
> > warning message.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > index 3de09b5b4921..86d3d31d3269 100644
> > --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > @@ -22,6 +22,7 @@ [Defines]
> >
> >  [Sources]
> >    SecFspApiChk.c
> > +  SecFsp.h
> >
> >  [Sources.IA32]
> >    Ia32/Stack.nasm
> > --
> > 2.18.0.windows.1

Re: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

[Nate DeSimone]

Agreed with Chasel and Star. Once copyright is extended:

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Zeng, Star 
Sent: Thursday, August 8, 2019 7:56 AM
To: Chiu, Chasel <chasel.chiu@intel.com>; Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file

Same with Chasel. Reviewed-by: Star Zeng <star.zeng@intel.com>.

> -----Original Message-----
> From: Chiu, Chasel
> Sent: Thursday, August 8, 2019 2:59 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star 
> <star.zeng@intel.com>
> Subject: RE: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header 
> file in INF file
> 
> 
> Please extend copyright to 2019 of this file.
> With above change Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> 
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Thursday, August 8, 2019 2:25 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L 
> > <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> > Subject: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header 
> > file in INF file
> >
> > SecFsp.h is used but missing inf file, which will cause generating 
> > warning message.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > index 3de09b5b4921..86d3d31d3269 100644
> > --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> > @@ -22,6 +22,7 @@ [Defines]
> >
> >  [Sources]
> >    SecFspApiChk.c
> > +  SecFsp.h
> >
> >  [Sources.IA32]
> >    Ia32/Stack.nasm
> > --
> > 2.18.0.windows.1