From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: shenglei.zhang@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Thu, 08 Aug 2019 00:54:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 00:54:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="186271471" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga002.jf.intel.com with ESMTP; 08 Aug 2019 00:54:50 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Laszlo Ersek Subject: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style Date: Thu, 8 Aug 2019 15:54:48 +0800 Message-Id: <20190808075448.6760-1-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 1. Update CPUStatus to CpuStatus in comments to align comments with code. 2. Add "OUT" attribute for "ProcedureArguments" parameter in function header. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- v2: Add "OUT" attribute for "ProcedureArguments" parameter in both function header and comments,in MpService.c. UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 6 +++--- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c index 328d7ae53a49..d8d2b6f44461 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -1967,7 +1967,7 @@ RegisterSmmEntry ( EFI_MP_SERVICES_PROTOCOL.StartupAllAPs. If caller may pass a value of NULL to deregister any existing startup procedure. - @param[in] ProcedureArguments Allows the caller to pass a list of parameters to the code that is + @param[in,out] ProcedureArguments Allows the caller to pass a list of parameters to the code that is run by the AP. It is an optional common mailbox between APs and the caller to share information @@ -1977,8 +1977,8 @@ RegisterSmmEntry ( **/ EFI_STATUS RegisterStartupProcedure ( - IN EFI_AP_PROCEDURE Procedure, - IN VOID *ProcedureArguments OPTIONAL + IN EFI_AP_PROCEDURE Procedure, + IN OUT VOID *ProcedureArguments OPTIONAL ) { if (Procedure == NULL && ProcedureArguments != NULL) { diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h index a0e59f20886b..7b3fbc8b55ec 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -1311,7 +1311,7 @@ RestoreCr2 ( Note that timeout support is optional. Whether an implementation supports this feature can be determined via the Attributes data member. - @param[in,out] CPUStatus This optional pointer may be used to get the status code returned + @param[in,out] CpuStatus This optional pointer may be used to get the status code returned by Procedure when it completes execution on the target AP, or with EFI_TIMEOUT if the Procedure fails to complete within the optional timeout. The implementation will update this variable with @@ -1437,8 +1437,8 @@ InternalSmmStartupAllAPs ( **/ EFI_STATUS RegisterStartupProcedure ( - IN EFI_AP_PROCEDURE Procedure, - IN VOID *ProcedureArguments OPTIONAL + IN EFI_AP_PROCEDURE Procedure, + IN OUT VOID *ProcedureArguments OPTIONAL ); /** -- 2.18.0.windows.1