From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.2.85, mailfrom: glin@suse.com) Received: from m4a0039g.houston.softwaregrp.com (m4a0039g.houston.softwaregrp.com [15.124.2.85]) by groups.io with SMTP; Thu, 08 Aug 2019 01:09:55 -0700 Received: FROM m4a0039g.houston.softwaregrp.com (15.120.17.146) BY m4a0039g.houston.softwaregrp.com WITH ESMTP; Thu, 8 Aug 2019 08:09:44 +0000 Received: from M9W0067.microfocus.com (2002:f79:be::f79:be) by M4W0334.microfocus.com (2002:f78:1192::f78:1192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 8 Aug 2019 08:08:26 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (15.124.72.11) by M9W0067.microfocus.com (15.121.0.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Thu, 8 Aug 2019 08:08:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YFYx3aBGSBmDfe1lPFV6dW2E0QDcVJMHgt4NlqiNxKxWr5Wdvf2vQu3MkZXYyKB4Gzh/sR9YDXge8NoHdA7jElhQaqIv3tGo1JXNKtSo4awZXNcG+0QiLp71ysIcEnvJ1pOmSaPlPZLjQVMr6WCxFf4p7Qtg00X+8Q4VwDRK7/DH9UZRE2dQRzljTIIdO/To3ym9n2ox/82kTRiybFQ0SSMBdvu3UC/di1ENC4P4VCRrk6QpUa4378Xqtn6sZUPtx4t+e694Jo+nfYLRzvGCNQnvOip14Z2TAsju19UZlA54XQ2qiWs06e1IG7c4QPVAQQaKQgwBspC+7lBzetqOWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yJgeSecNoXz2YiJGEweogrPoCW8zqLGp8FuxqEB3aKY=; b=F4M0t+gJ+MjXgWJ1i8rI2qTU/UTLLwmbW2c8l+KERoXFUnLBerxrUdfQ+HcHW6AJQDe9R69yXlmmmXIR1071lndyecZF+J8JSKjTyN0MwgEqlTdE+bwbKSO16L+bPOVh1Tk3OuEPNeGiACkkrwG+njQlaBnzoxEv9OwbiawseDSwvpBLlh7PBQk5TYuNrUf97W3lQ6QtJRlXQwFkiuZlOfAVexngOoqQ6kJg/NT81Ie9m1g9yBjZzbp/FpgWfuFksptQm+D+dJh8X545gYJFuuWJu0cZZ3O+FxRAvP9j6PNr0xIBQ6bf6YCiq3mwzSuHgtLtFmhM06b8RKZ7pKK1/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB2858.namprd18.prod.outlook.com (20.179.52.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Thu, 8 Aug 2019 08:08:24 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::95e2:f1a5:356c:9a5d]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::95e2:f1a5:356c:9a5d%3]) with mapi id 15.20.2157.015; Thu, 8 Aug 2019 08:08:24 +0000 From: "Gary Lin" To: "devel@edk2.groups.io" , "michael.d.kinney@intel.com" CC: Yi Qian , Zailiang Sun Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard Thread-Index: AQHVRq8IkgwNEj0QbUCqOgBW+vbq+Kbw5R0QgAAOXQA= Date: Thu, 8 Aug 2019 08:08:24 +0000 Message-ID: <20190808080812.GB26233@GaryWorkstation> References: <20190730081518.16349-1-glin@suse.com> In-Reply-To: Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB6PR07CA0148.eurprd07.prod.outlook.com (2603:10a6:6:16::41) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de273ffb-fa2f-4a06-7414-08d71bd7960c x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB2858; x-ms-traffictypediagnostic: DM6PR18MB2858: x-ms-exchange-purlcount: 4 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 012349AD1C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(4636009)(346002)(366004)(39860400002)(136003)(396003)(376002)(13464003)(199004)(189003)(6246003)(256004)(66476007)(6506007)(11346002)(71190400001)(14454004)(5660300002)(6512007)(86362001)(478600001)(6486002)(476003)(186003)(446003)(229853002)(9686003)(54906003)(6436002)(71200400001)(6306002)(52116002)(80792005)(6116002)(66946007)(966005)(99286004)(66066001)(19627235002)(386003)(53546011)(64756008)(66446008)(2906002)(8676002)(7736002)(33716001)(76176011)(53936002)(81156014)(3846002)(81166006)(486006)(305945005)(8936002)(25786009)(2501003)(33656002)(1076003)(66556008)(316002)(14444005)(110136005)(26005)(102836004)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB2858;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: b4abJl2D1qVZ2nxbgjoROruJk47GPorn1hmROdAS1YAoIT+NWNSrTzoW5XeaQVfrUxBHVMpbFNuEIZXmS1bWo6Gpka0U48q7FH+zHOEdxM/jSpEpLizxEbaXRV8aUvEZ1b39hXevQ+fFSEMkcEdLxzNAuiW7vfpDrZfMfM1/E1cRP/T6K8tiK7uOJtUAQGXHD1wuLzUPxJHUen3T3xwP0C1m2EKSSX0tiUsvl2Xp1OCzF+vfJGmAVd7l9m9OcXuqOhUV7AFKdKWouGsFqIGI8DTZN4V7mPKKYlqvBcYq/0AyFnhA00SzqjpKwKeEfLEruKqcX8bKDc2iFFtt2kKaaBRdSPSvGCMPjr6ArtpXMedOT00XJN/yWsmb/VpUu10VKhVYMTeN3a/ab1Ra21Elr1jr9eZc1JzMufockF6yBwU= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: de273ffb-fa2f-4a06-7414-08d71bd7960c X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2019 08:08:24.7520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xx1ODWW1GTYI/2KSin+JcAzWRvE+CRqsYRYnDg3H609rnqxODU4jIVBu0XUtmybt X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2858 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <2E8D034F5D6EE94497B9EEA6244AA2C1@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Thu, Aug 08, 2019 at 07:26:04AM +0000, Michael D Kinney wrote: > Hi Gary, >=20 Hi Michael, > Thank you for these patches. >=20 > I am seeing one behavior change in the setup forms. > The following 2 forms are missing information that > used to be filled in. I will help look into this > tomorrow. >=20 > 1) Device Manager -> System Setup -> Main >=20 > 2) Device Manager -> System Setup -> Main -> Platform Information >=20 I built another firmware without my patches and those information were still missing, so the bug is probably introduced by other patch. Thanks, Gary Lin > Best regards, >=20 > Mike >=20 > > -----Original Message----- > > From: Gary Lin [mailto:GLin@suse.com] > > Sent: Tuesday, July 30, 2019 1:16 AM > > To: devel@edk2.groups.io > > Cc: Sun, Zailiang ; Qian, Yi > > ; Kinney, Michael D > > > > Subject: [edk2-platforms] [PATCH v2 0/6] Fix the boot > > order, SMBIOS, and capsule GUIDs of Minnowboard > >=20 > > After switching to MdeModulePkg BdsDxe, the boot option > > created by OS was always put at the end of BootOrder > > after reboot. Besides, the PXE boot options were always > > the first boot options. > >=20 > > The 1st to 3rd patches fix the priority of boot options > > and stop sorting the boot options after the first boot. > > The missing BootManagerMenuApp is also added back. > >=20 > > The 4th patch cleans up PlatformBootOption.c to remove > > the unused variables and function. > >=20 > > The 5th patch adds some missing bits of BIOS > > Characteristics Extension in SMBIOS, so that fwupd can > > detect the system correctly. > >=20 > > The 6th patch converts the device GUIDs in metainfo.xml > > to lowercase to be compatible with LVFS/fwupd. > >=20 > > The patches are also available in my github branch: > > https://github.com/lcp/edk2-platforms/tree/fix- > > minnowboard-bds-v2 > >=20 > > v2: > > * Add the missing MSG_URI_DP to BootOptionPriority() > > * Update the descriptioins of 2nd and 4th patches > > * Add the 5th and 6th patches > >=20 > > Cc: Zailiang Sun > > Cc: Yi Qian > > Cc: Michael D Kinney > >=20 > > Gary Lin (6): > > Vlv2TbltDevicePkg: Adjust the device priority > > Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp > > Vlv2TbltDevicePkg: Only sort boot options when > > necessary > > Vlv2TbltDevicePkg: Clean up the unused variables and > > function > > Vlv2TbltDevicePkg: Add the missing SMBIOS bits > > Vlv2TbltDevicePkg: Convert the device GUIDs of > > capsules to lowercase > >=20 > >=20 > > Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/Genera > > teCapsule/GenCapsuleAll.py | 24 +++--- > >=20 > > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > > tManagerLib/BdsPlatform.c | 9 +- > >=20 > > Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBoo > > tManagerLib/PlatformBootOption.c | 86 ++++++----------- > > --- > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf > > | 3 +- > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > | 1 + > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > | 1 + > >=20 > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubR > > ecords.h | 5 +- > >=20 > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBios > > VendorData.c | 5 +- > > 8 files changed, 54 insertions(+), 80 deletions(-) > >=20 > > -- > > 2.22.0 >=20 >=20 >=20 >=20 >=20