From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=cIqXQ1hG;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by groups.io with SMTP; Thu, 08 Aug 2019 02:55:22 -0700
Received: by mail-wm1-f66.google.com with SMTP id g67so1775331wme.1
        for <devel@edk2.groups.io>; Thu, 08 Aug 2019 02:55:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=/hcJoHQndP/Je3KBvsqv1V0S15q/bvM8Aok/bGUaruA=;
        b=cIqXQ1hGQm+TPCixL96LGJwBPxYgqSI0gw0n3tq/73G5uctz/JsSlmjaeNg3/C9Mnx
         n3NOUaXAqsWDjXGFhCVPpTpC6qS0duQ/U6Bj22VR6+YAKXWv+2SI+PMRdEqti46+cpPh
         QH/foJhpunPP0pOg/OK8rJhr13IORSwDlfWIUQfWMVQcZia07srlAuzsYHomiMRGSay5
         uH1lxycKQ4pvCNrnojk+pJq1o7PNyP6kiX9mZkNDD0qZUMqw+FaLO3tnG15A041YXpj6
         OGIUB54hBT75OIFPAwaq/Le5a4j2pS8H2RVvSyt5bUBapR/PZxbtlQTI81aGSezS0F1H
         t78w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=/hcJoHQndP/Je3KBvsqv1V0S15q/bvM8Aok/bGUaruA=;
        b=i7s8z+9kGM9BWIOt82BIfBV03ZPy3IDj6Uq/DDFzl5HuN9RMHzqNPuliV0kvWY2gBv
         kqpQt5WtXr5uYAQKV15DkxpRoECn/En935HaLNzF3eEVhN+X8lx37zV7KYzhORC+lAtX
         mJYUb9yRKBAIPXyeTk4/V25sT2HuNZMFyO8+fcgzWL32miStMvx6VAnsyCZNanS4zfZm
         mqdq2ETXRZMywVcHbf1KnBFIo8X4ucJMabh+R2cfN8vo5eb6mDpaM1MEAKBZ11VVmU8q
         35M6d3FuFQ4kBI46ilE07Hqu+zf8nP72323wTixR2WerHCl9810F3/4eDRyeENLVpjlM
         fb+g==
X-Gm-Message-State: APjAAAXvLCUHg5nImWO8BtfKzN6COilM4EwtoixgQMFm27mcm2CiQNln
	8UVjEmBNaI8Ch6O5T6qyYbIb0UivoU0=
X-Google-Smtp-Source: APXvYqzcTpb2CAUBogA1pVyTUG5Xn93Qdd59+Bt8+UYiXm9wi/nMtDOBi1J//rzPW0kSbbjBgPwSyA==
X-Received: by 2002:a1c:c1c1:: with SMTP id r184mr3360093wmf.9.1565258120155;
        Thu, 08 Aug 2019 02:55:20 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id v12sm80280869wrr.87.2019.08.08.02.55.19
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 08 Aug 2019 02:55:19 -0700 (PDT)
Date: Thu, 8 Aug 2019 10:55:18 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, shenglei.zhang@intel.com
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <liming.gao@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Eugene Cohen <eugene@hp.com>
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template
Message-ID: <20190808095518.GT25813@bivouac.eciton.net>
References: <20190808080918.744-1-shenglei.zhang@intel.com>
MIME-Version: 1.0
In-Reply-To: <20190808080918.744-1-shenglei.zhang@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Shenglei,

On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote:
> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35
> in tools_def.template. These tool chains are for ARM and AARCH64 only.
> There is no change recently and they are not used.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1750

This still does not address my comment in the BZ that deleting all
RVCT profiles before full VS support is enabled for (32-bit) ARM, we
orphan an awful lot of .asm files.

This may not have much of a practical effect, since I doubt anyone is
using these toolchains today - but it does prevent someone from
actively going through and testing future updates (where before, they
may just have neglected to do so).

This point needs discussing rather than ignoring, and I think we're
getting too close to the freeze to consider the patch to go in as is
at this point.

Whenever this patch does go in should be in the week after a stable
tag is made, to give plenty of time for anyone affected to shout
before the next stable tag is made.

After the 2019.08 stable tag has been made, I am happy for a patch
going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX.

The deletion of the final RVCT profile needs further discussion.

Best Regards,

Leif