From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.155.144, mailfrom: anthony.perard@citrix.com) Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by groups.io with SMTP; Thu, 08 Aug 2019 03:41:26 -0700 Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa4.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa4.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa4.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 3l9HoUspUGZwJU9PnCnk8hbj2tlkWF58Ri51v3FgiXc55dNJBBK6IRTVkzYMKpnZqT2OTj4LMi gSvChZo1Z+LCOqAYberi+tdU04CsPNewVyV/py3aKxq84Z/uF2bVmYsEATBetmhlnfiOuLkeiI 1p+skxKjU3tdTGoJVmoO0JLyAccgU5thDqASXuhTBtv4zz0eIlWoOWyc3DZjiyxlg2JWjmF+/J QfSHG5n2bghCZjgNfbA3s7kmbaIsngi2OZHb3pSdZ9ABW6ZfBxJxf9yz01JpOO+dc+66IRY1GC HnE= X-SBRS: 2.7 X-MesageID: 4202638 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,360,1559534400"; d="scan'208";a="4202638" Date: Thu, 8 Aug 2019 11:41:18 +0100 From: "Anthony PERARD" To: Roger Pau =?iso-8859-1?Q?Monn=E9?= CC: , Julien Grall , , Jordan Justen , Ard Biesheuvel , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v4 22/35] OvmfPkg/XenPlatformPei: no hvmloader: get the E820 table via hypercall Message-ID: <20190808104118.GS1242@perard.uk.xensource.com> References: <20190729153944.24239-1-anthony.perard@citrix.com> <20190729153944.24239-23-anthony.perard@citrix.com> <20190807150849.b6alhjw2lgcjpmxx@Air-de-Roger> MIME-Version: 1.0 In-Reply-To: <20190807150849.b6alhjw2lgcjpmxx@Air-de-Roger> User-Agent: Mutt/1.12.1 (2019-06-15) Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Aug 07, 2019 at 05:14:33PM +0200, Roger Pau Monné wrote: > On Mon, Jul 29, 2019 at 04:39:31PM +0100, Anthony PERARD wrote: > > When the Xen PVH entry point has been used, hvmloader hasn't run and > > hasn't prepared an E820 table. The only way left to get an E820 table > > is to ask Xen via an hypercall, the call can only be made once so keep > > the result cached for later. > > I think we agreed that the above is not true, and that the memory > map can be fetched as many times as desired using the hypercall > interface. Yes, I'll change the commit message. How about: When the Xen PVH entry point has been used, hvmloader hasn't run and hasn't prepared an E820 table. The only way left to get an E820 table is to ask Xen via an hypercall. We keep the result cached to avoid making a second hypercall which would give the same result. Thanks, -- Anthony PERARD