Re: [PATCH edk2-platforms v3 0/3] Robust Netsec Initialiation

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Thu, Aug 08, 2019 at 09:23:32PM +0900, Masahisa Kojima wrote:
> This patch series is bugfix for the hang-up issue in Netsec driver.
> 
> Some linux distributions such as Ubuntu power down the ethernet phy
> in reboot. In this case, Netsec initialization fails and
> system hungs.
> 
> This patch series add the robust netsec initialization,
> set ethernet phy as loopback mode to expect stable RXCLK,
> and wait for media link up.
> 
> The disadvantage of this patch series is that user has to wait
> several seconds until netsec driver gives up ethernet link-up
> if the ethernet cable is not connected.

Thanks for this v3 - apologies for not spotting the Signed-off-by
issue on the first revision. For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as 86ef5b3e5d88..1ad8bb58a798.

> Changes since v2:
>   - use From: tag instead of Signed-off-by:
> 
> Changes since v1:
>   - modified wrong indent
>   - updated order of new parameter
>   - updated comment
>   - removed unrelated whitespace changes
> 
> Satoru Okamoto (3):
>   NetsecDxe: embed phy address into NETSEC SDK internal structure
>   NetsecDxe: put phy in loopback mode to guarantee stable RXCLK input
>   NetsecDxe: SnpInitialize() waits for media linking up
> 
>  .../Socionext/DeveloperBox/DeveloperBox.dsc   |   1 +
>  .../Drivers/Net/NetsecDxe/NetsecDxe.c         | 236 ++++++++----------
>  .../Drivers/Net/NetsecDxe/NetsecDxe.dec       |   1 +
>  .../Drivers/Net/NetsecDxe/NetsecDxe.h         |   2 -
>  .../Drivers/Net/NetsecDxe/NetsecDxe.inf       |   1 +
>  .../netsec_sdk/include/ogma_api.h             |   6 +-
>  .../netsec_sdk/src/ogma_gmac_access.c         |  61 ++---
>  .../netsec_sdk/src/ogma_internal.h            |   2 +
>  .../netsec_sdk/src/ogma_misc.c                |  78 ++++++
>  .../netsec_for_uefi/netsec_sdk/src/ogma_reg.h |   4 +
>  10 files changed, 211 insertions(+), 181 deletions(-)
> 
> -- 
> 2.17.1
>