From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ivUuh/Ub; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Thu, 08 Aug 2019 08:58:07 -0700 Received: by mail-wm1-f65.google.com with SMTP id l2so2956929wmg.0 for ; Thu, 08 Aug 2019 08:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zhynjR5uqTP0uxBWqa0HBCCHvZ197kmPgLmtzYeT3WA=; b=ivUuh/UbQJnJwHdx6EdfOYFnixafLpn/F+2Owh+c98ZsQ0fkleIhMYBaIfnc/4BAof btFpz23qMXFjdUZk5Rb6Q07KLk9ooXPPJMuKLGIExIBuTVwT4gyIdDDGjpE0Olz3xv2S 7JNT/IBVXtLGpdZ6Kghx8nJeTlbcnSTO84SpyBoY9IkMdBMMz7W2MiEPWia4V/N1nLmm izAA7Nzgp8m01XDJC6Z3rqRgRWE3kd4o/x/iiqyWO89PjyodQBRZ8o89UV56R0F/xBf2 PHWG8a6tZwFNkCTa+UcB4xN4eZ6+dSyNw5KkOmx4PgvqVodZhSdap5nF8c4SYwZHv8qG pGRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zhynjR5uqTP0uxBWqa0HBCCHvZ197kmPgLmtzYeT3WA=; b=gbZ6WoGNG6bN5wVElNmmtkfhKC9l2JEsMYVNNJVH88TMcw4ruM6qGEV9Rw3mwPz7RF W1Hlw2exxDg4+Jdgz8VJZflutmC53J0YF8Yt1YjXy+6oPLvrYBF4thdJ/ZRSMIsJLV+h quXahscwEwnEwWfxHCR9oaVK+NLEDhILJIGlFJaAmpJTkAj+6bQUVP2NvGPGQY8cR7P6 yIRdI1vIsQ+Wx/fKCykfz5J0dvHIMKj5vCkR+DS6YdDYmf/0UrGqzBPOp/5HDE3Ybo84 AhUG06/NSpFCAQ9/e0Is+JHhFJ0VorQZmPjbMEU9Xle8mUYw4hJr40VjMXwpvW0zz8e3 bZtQ== X-Gm-Message-State: APjAAAXoY2bHhaaJdNsnymA/C8u/MtuV6/8ESZ8Lg/vgj0L8pfLmkVUd PitgLZi9rTq33bc+8SO7G3mSiQ== X-Google-Smtp-Source: APXvYqyBGqHToN+DKmz/jhT9sNTMzT51tiWZ1TsLR8YFfs5Yu06iyxCllhM6F4gP7bwKvK4uKoI/TA== X-Received: by 2002:a1c:4b07:: with SMTP id y7mr5332048wma.130.1565279885834; Thu, 08 Aug 2019 08:58:05 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q1sm2340955wmq.25.2019.08.08.08.58.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 08:58:05 -0700 (PDT) Date: Thu, 8 Aug 2019 16:58:03 +0100 From: "Leif Lindholm" To: Masahisa Kojima Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, okamoto.satoru@socionext.com Subject: Re: [PATCH edk2-platforms v3 0/3] Robust Netsec Initialiation Message-ID: <20190808155803.GC25813@bivouac.eciton.net> References: <20190808122335.11883-1-masahisa.kojima@linaro.org> MIME-Version: 1.0 In-Reply-To: <20190808122335.11883-1-masahisa.kojima@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 08, 2019 at 09:23:32PM +0900, Masahisa Kojima wrote: > This patch series is bugfix for the hang-up issue in Netsec driver. > > Some linux distributions such as Ubuntu power down the ethernet phy > in reboot. In this case, Netsec initialization fails and > system hungs. > > This patch series add the robust netsec initialization, > set ethernet phy as loopback mode to expect stable RXCLK, > and wait for media link up. > > The disadvantage of this patch series is that user has to wait > several seconds until netsec driver gives up ethernet link-up > if the ethernet cable is not connected. Thanks for this v3 - apologies for not spotting the Signed-off-by issue on the first revision. For the series: Reviewed-by: Leif Lindholm Pushed as 86ef5b3e5d88..1ad8bb58a798. > Changes since v2: > - use From: tag instead of Signed-off-by: > > Changes since v1: > - modified wrong indent > - updated order of new parameter > - updated comment > - removed unrelated whitespace changes > > Satoru Okamoto (3): > NetsecDxe: embed phy address into NETSEC SDK internal structure > NetsecDxe: put phy in loopback mode to guarantee stable RXCLK input > NetsecDxe: SnpInitialize() waits for media linking up > > .../Socionext/DeveloperBox/DeveloperBox.dsc | 1 + > .../Drivers/Net/NetsecDxe/NetsecDxe.c | 236 ++++++++---------- > .../Drivers/Net/NetsecDxe/NetsecDxe.dec | 1 + > .../Drivers/Net/NetsecDxe/NetsecDxe.h | 2 - > .../Drivers/Net/NetsecDxe/NetsecDxe.inf | 1 + > .../netsec_sdk/include/ogma_api.h | 6 +- > .../netsec_sdk/src/ogma_gmac_access.c | 61 ++--- > .../netsec_sdk/src/ogma_internal.h | 2 + > .../netsec_sdk/src/ogma_misc.c | 78 ++++++ > .../netsec_for_uefi/netsec_sdk/src/ogma_reg.h | 4 + > 10 files changed, 211 insertions(+), 181 deletions(-) > > -- > 2.17.1 >