From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"jsd@semihalf.com" <jsd@semihalf.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Kostya Porotchkin <kostap@marvell.com>
Subject: Re: [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support
Date: Thu, 8 Aug 2019 18:53:24 +0100 [thread overview]
Message-ID: <20190808175324.GF25813@bivouac.eciton.net> (raw)
In-Reply-To: <CAPv3WKenjMqghBHj1Qx2xjAK6C_K5wOpN=jguUZ_8ojHHV64QQ@mail.gmail.com>
On Thu, Aug 08, 2019 at 07:05:29PM +0200, Marcin Wojtas wrote:
> > On a higher level, I confess to not being entirely convinced about the
> > triplicate .dsc/.dsc.inc/.fdf.inc setup. (Of the three, the .dsc.inc
> > is the one I object the least to.)
> > For the .dscs, I understand the desire to separate the build
> > directories, but could this be achieved with -D build flags instead?
> > Certainly the differences in .fdf.inc could be handled via
> > conditional statements determined in a single .dsc.
> >
> > If (and this is a possibility) the 3 different .dscs is the right way
> > forward, I still think everything other than the [defines] section
> > should be kept in a common .dsc.inc.
> >
>
> I will try the -D option. How about:
> - single .dsc / .fdf.inc
> - triple .dsc.inc (they overlap in really minimal way and show pretty
> good the differences between 3 variants)
> ?
Yeah, that sounds good to me. Agreed on the .dsc.inc - you could
possibly slightly decrease duplication if keeping them as one file,
but it would be more difficult to read and review changes.
Best Regards,
Leif
next prev parent reply other threads:[~2019-08-08 17:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 23:30 [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 1/9] Marvell/Cn9130Db: Add ACPI tables Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 2/9] Marvell/Cn9130Db: Add DeviceTree Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 3/9] Marvell/Cn9130Db: Introduce board support Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 4/9] Marvell/Library: ArmadaSoCDescLib: Extend Xenon information Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 5/9] Marvell/Library: MppLib: Allow to configure more Xenon PHYs Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 6/9] Marvell/Library: IcuLib: Fix debug information Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 7/9] Marvell/Cn9131Db: Introduce board support Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 8/9] Marvell/Cn9132Db: " Marcin Wojtas
2019-08-07 23:30 ` [edk2-platforms: PATCH 9/9] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name Marcin Wojtas
2019-08-08 11:51 ` [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support Leif Lindholm
2019-08-08 13:51 ` Marcin Wojtas
2019-08-08 16:48 ` Leif Lindholm
2019-08-08 17:05 ` Marcin Wojtas
2019-08-08 17:53 ` Leif Lindholm [this message]
2019-08-09 6:36 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808175324.GF25813@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox