From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=hedG8VzK; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Thu, 08 Aug 2019 10:53:28 -0700 Received: by mail-wr1-f66.google.com with SMTP id n9so95902214wru.0 for ; Thu, 08 Aug 2019 10:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Pl+mkKWacjXJi46tm8fr3cQZ4iXuSM04mNpLXT+cBMI=; b=hedG8VzKxUhi0g+K8YdVXGwEYur5K9uxEzeM34HozPro1zwiAwg4FtyMzfnV1ksyiS OPbe+xNVA4wkBIwT8bEUWNE7SIybR9YYofCyiQA06bB4ZApLWGnIXR44bMrgeVk0gdxY ZOSK2VMWi7xBLFahswj+t+KJqvbjgglLw2JPgYOAFi529RysdV+ZFR0x1Vb1AM+WtBb5 CwhLs8MQaqYuTVCZnu1RReWg6/hKG1cOZubhD70v8AnDRGsfNw4lwd23T/bJsECaLb1a iqzAlxHVnSAKgSJPzYf4y9FGR2vgS5vwjVCpB6b0cg56pL1DVMqPv09CKEoeHifi6o9A ZEmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Pl+mkKWacjXJi46tm8fr3cQZ4iXuSM04mNpLXT+cBMI=; b=YJJeFYb+fNUo+rbAlHZAqslOFeZdE1irmaOGrhSdsb4ZqKIPJhErOZPbeCDMxp30oT hXQAFevpjYWHW6zcEiHDZm0fS32CFSgJhGeTs1PWQU10nvjIgKIGpTeJGF6EVazCZ6PG cDhc8Ek1PV34C93q0rD3qoDsjJvAQBvt3tm/Tv2eThPxS6dUp8RWSZx5FRrsdN+UaOWo 4gg3BO2aHDivWuUBbsL5k2M5l6lQWU424SXpsbGI61nAi0A3oKZVAGSyKKUgRcNa6QJi qajY/Se6t/Y+In6Mwafdj2kWNf8wH3SjEdNXPrXxzRhzWZDuzYl85YO83JhukncA3fSU LZbg== X-Gm-Message-State: APjAAAXTcUSdJC7Ss34F4dSgEqkX8GFxAFt06/JlE9FG7VL4BLd/HhCx kFj5AHnAxfc78822Ar+zWdKhDw== X-Google-Smtp-Source: APXvYqxMnp+gyI9x5tCcFRkIAp1fduBAufT4lwMt30RpCRJNUm0NgRObUeSVr4bLDs06b5D7PC0wTg== X-Received: by 2002:a5d:4492:: with SMTP id j18mr15908291wrq.53.1565286806483; Thu, 08 Aug 2019 10:53:26 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h97sm4854498wrh.74.2019.08.08.10.53.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 10:53:25 -0700 (PDT) Date: Thu, 8 Aug 2019 18:53:24 +0100 From: "Leif Lindholm" To: Marcin Wojtas Cc: edk2-devel-groups-io , Ard Biesheuvel , "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Subject: Re: [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support Message-ID: <20190808175324.GF25813@bivouac.eciton.net> References: <1565220630-1653-1-git-send-email-mw@semihalf.com> <20190808115153.GX25813@bivouac.eciton.net> <20190808164822.GE25813@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 08, 2019 at 07:05:29PM +0200, Marcin Wojtas wrote: > > On a higher level, I confess to not being entirely convinced about the > > triplicate .dsc/.dsc.inc/.fdf.inc setup. (Of the three, the .dsc.inc > > is the one I object the least to.) > > For the .dscs, I understand the desire to separate the build > > directories, but could this be achieved with -D build flags instead? > > Certainly the differences in .fdf.inc could be handled via > > conditional statements determined in a single .dsc. > > > > If (and this is a possibility) the 3 different .dscs is the right way > > forward, I still think everything other than the [defines] section > > should be kept in a common .dsc.inc. > > > > I will try the -D option. How about: > - single .dsc / .fdf.inc > - triple .dsc.inc (they overlap in really minimal way and show pretty > good the differences between 3 variants) > ? Yeah, that sounds good to me. Agreed on the .dsc.inc - you could possibly slightly decrease duplication if keeping them as one file, but it would be more difficult to read and review changes. Best Regards, Leif