Re: [PATCH V3 03/15] ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Thu, Aug 08, 2019 at 10:21:16PM +0200, Laszlo Ersek wrote:
> On 08/08/19 03:08, Zhichao Gao wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772
> > 
> > ResetUtilityLib would be consumed by CapsuleRuntimeDxe.
> > So add it for the platform dsc file.
> > 
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> >  ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> > index 7ae6702ac1..4b8130f8e7 100644
> > --- a/ArmVirtPkg/ArmVirtQemu.dsc
> > +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> > @@ -73,6 +73,7 @@
> >    PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> >    PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
> >    PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> > +  ResetUtilityLib|MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf
> >  
> >  [LibraryClasses.common.PEIM]
> >    ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf
> > 
> 
> Can you please update your git configuration for displaying the DSC
> section headers near the hunk markers (@@), when a patch is formatted?
> So that it's easier to see, during review, what DSC section is being
> modified?

Even better, run BaseTools/Scripts/SetupGit.py and get *all* of the
correct settings that are possible to configure statically.

/
    Leif

p.s.
Yes, I really should update the wiki to mention this.

> *
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05
> 
> $ git config diff.ini.xfuncname     '^\[[A-Za-z0-9_., ]+]'
> 
> *
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09
> 
> $ cat > .git/info/attributes <<EOT
> *.efi     -diff
> *.EFI     -diff
> *.bin     -diff
> *.BIN     -diff
> *.raw     -diff
> *.RAW     -diff
> *.bmp     -diff
> *.BMP     -diff
> *.dec     diff=ini
> *.dsc     diff=ini
> *.dsc.inc diff=ini
> *.fdf     diff=ini
> *.fdf.inc diff=ini
> *.inf     diff=ini
> EOT
> 
> Can you please reformat & repost the series like that?
> 
> Thanks,
> Laszlo