From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=gZLjzwQP; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Thu, 08 Aug 2019 13:39:40 -0700 Received: by mail-wr1-f66.google.com with SMTP id b3so3803679wro.4 for ; Thu, 08 Aug 2019 13:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QtwImRiR+2qhz8QXYpJhTZSQs2kHoWN+vm6aTQzEX9E=; b=gZLjzwQPyBsvuxn7vjVR3YFmRNMnkQ57qJbNzHbscsP8/DR6lJCGtyfwvJ8xkhoeC0 uv/NayCsuOS4FjqHuui+XXcKuImTTK9y68gHHCJa+pou1NZWlMhYMIe5tV4Q+KF6P2Bq wr4fyVFcPB8nHb1dcysfnL0jbvWwDyAxiNkMoe8CQV4lG4QtsXjDQ3x+C3bmt93Maojw q69chPpc0+xAlWQeXBMpSTG8NZPodE2yFlMm2lA1uar00OcUByXuC2tsf6d+c6ZtMP0a ZmISs3SMqjJGawz6ongJS2Y4ucc30L1LySDzW8GWooCKhKqYN0wo0O5EXHhu4sJmGZvS N0Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QtwImRiR+2qhz8QXYpJhTZSQs2kHoWN+vm6aTQzEX9E=; b=qITNabxrvk6i/xM7WQzf5i1ufJ51/WHearVNbshbTRJQYHvc5Tm2jh//cVOspie0KH qdlR0K24JnEMOv1wCYjcHmp77UwxndXPruwNgASdo/leOaGpFQz0s/dFsEY+fnrtim1b 0JPWQ1B0a+zAXYHcCH5Hxt1f6e1DcCXyQQ8RxL6a4JXjAhemfpiC5ZpRisAttUw1ijrr PCimNI7m0sZtO+N0gthD5NcTej/p6pqbwuPHbQf+oMNAfSl7jrxPowIT0kUGCyvTBrnU zZRisE7OpbkVvNZZqjshzPJ2jv6IkDyVr3dRbXKvMuPeSRrvR3tlUuoVL5jTJ0JovmfE CaWg== X-Gm-Message-State: APjAAAXap9K+Fe/EYsFNiZh/89De5NLjST7He7SFl/QYAIGakxrjA2a0 PooAoPW/KgxVjZqLtlrb5fntUA== X-Google-Smtp-Source: APXvYqyW8dhbX/OszozBjrGGDV07/KMX0MFQPZG6DEfZJ82UgW96UCeN5IANj22gjj1lx/8LbQRk5A== X-Received: by 2002:a05:6000:14b:: with SMTP id r11mr19573915wrx.196.1565296779119; Thu, 08 Aug 2019 13:39:39 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q20sm19783700wrc.79.2019.08.08.13.39.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 13:39:38 -0700 (PDT) Date: Thu, 8 Aug 2019 21:39:36 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: Zhichao Gao , devel@edk2.groups.io, Ard Biesheuvel , Liming Gao Subject: Re: [PATCH V3 03/15] ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file Message-ID: <20190808203936.GG25813@bivouac.eciton.net> References: <20190808010825.16784-1-zhichao.gao@intel.com> <20190808010825.16784-4-zhichao.gao@intel.com> <58ed45db-3249-75ea-9604-dbada90ba41b@redhat.com> MIME-Version: 1.0 In-Reply-To: <58ed45db-3249-75ea-9604-dbada90ba41b@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 08, 2019 at 10:21:16PM +0200, Laszlo Ersek wrote: > On 08/08/19 03:08, Zhichao Gao wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 > > > > ResetUtilityLib would be consumed by CapsuleRuntimeDxe. > > So add it for the platform dsc file. > > > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Liming Gao > > Signed-off-by: Zhichao Gao > > --- > > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > > index 7ae6702ac1..4b8130f8e7 100644 > > --- a/ArmVirtPkg/ArmVirtQemu.dsc > > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > > @@ -73,6 +73,7 @@ > > PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf > > PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf > > PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf > > + ResetUtilityLib|MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf > > > > [LibraryClasses.common.PEIM] > > ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf > > > > Can you please update your git configuration for displaying the DSC > section headers near the hunk markers (@@), when a patch is formatted? > So that it's easier to see, during review, what DSC section is being > modified? Even better, run BaseTools/Scripts/SetupGit.py and get *all* of the correct settings that are possible to configure statically. / Leif p.s. Yes, I really should update the wiki to mention this. > * > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05 > > $ git config diff.ini.xfuncname '^\[[A-Za-z0-9_., ]+]' > > * > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09 > > $ cat > .git/info/attributes < *.efi -diff > *.EFI -diff > *.bin -diff > *.BIN -diff > *.raw -diff > *.RAW -diff > *.bmp -diff > *.BMP -diff > *.dec diff=ini > *.dsc diff=ini > *.dsc.inc diff=ini > *.fdf diff=ini > *.fdf.inc diff=ini > *.inf diff=ini > EOT > > Can you please reformat & repost the series like that? > > Thanks, > Laszlo