From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=SPF record not found (domain: fensystems.co.uk, ip: 212.13.204.60, mailfrom: mbrown@fensystems.co.uk) Received: from duck.fensystems.co.uk (duck.fensystems.co.uk [212.13.204.60]) by groups.io with SMTP; Thu, 08 Aug 2019 16:16:31 -0700 Received: from pudding.home (cbs92326-cmbg19-2-0-cust10.5-4.cable.virginm.net [86.1.148.75]) by duck.fensystems.co.uk (Postfix) with ESMTPSA id D2364152EF; Fri, 9 Aug 2019 00:16:28 +0100 (BST) From: Michael Brown To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, pete@akeo.ie, Michael Brown Subject: [edk2-platforms: PATCH v2 0/1] Platform/RPi3: Report device tree Date: Fri, 9 Aug 2019 00:16:24 +0100 Message-Id: <20190808231625.1730843-1-mbrown@fensystems.co.uk> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190806170719.GJ25813@bivouac.eciton.net> References: <20190806170719.GJ25813@bivouac.eciton.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 06/08/2019 18:07, Leif Lindholm wrote: > Happy with all of this, except for the use of EFI_DEVICE_ERROR. >=20 > Generally, EFI_DEVICE_ERROR is used as an i/o error type status. > Either EFI_NOT_FOUND, EFI_INVALID_PARAMETER or EFI_OUT_OF_RECOURCES > would be more appropriate when referring to device-tree manipulation. >=20 > Could you update these and spin a v2 please? Here you go. I have switched all of the EFI_DEVICE_ERROR uses to EFI_NOT_FOUND, because I could not find any more appropriate EFI_STATUS value to represent "device tree appears to be corrupted". (EFI_INVALID_PARAMETER seemed misleading to me, since there is nothing wrong with the parameters provided by the caller.) Michael Brown (1): Platform/RPi3: Report device tree modification errors using Print() .../RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 102 ++++++++++++------ 1 file changed, 70 insertions(+), 32 deletions(-) --=20 2.21.0