From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=wNlwZNkQ; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 09 Aug 2019 03:07:29 -0700 Received: by mail-wm1-f68.google.com with SMTP id 10so5116540wmp.3 for ; Fri, 09 Aug 2019 03:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eMdxPz3GOQh/w8Ntw6c8EM/YObFuRBE5Q/7ri2a9rrc=; b=wNlwZNkQTzi0WEdGQtLkNog5/O1z55nCizb4WuRXEHOR184Rrq1reDMwXeHDEcpIlr Zoiu5hrFofc9g2OcbFB0SW7jzidVgdveLmNdDuasG4VDmun8Fqb+8mbDv4/w2w6ysO6o Ddf+uMi939WtCVMEuFT56OkVU8aSSfyoC4UwEOYLUyor0N2OM6c9dl7lh8TMntXt5md9 AtKGqsBniNOz2N7VEhGl8frOtllgaxR91AJCVol0So/R72sILaMZxCioRpDHBagNPtjh TV6AA06XGptSlkIFp6E0O7cJ4/cuPFBb3Ndm1C8aTkiP5fuWuP/Q83ZIzl8KEgDnWdxt 13NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eMdxPz3GOQh/w8Ntw6c8EM/YObFuRBE5Q/7ri2a9rrc=; b=tJdBnwOYMhSks4zFlsQu4bsL6+UUh5k+QQSLupL/ESvHxcOZPeXKgGGf95MekrP62M QSZdkKTlC2UGeIlftiTlkJrlwtsapd3rVdHviX+dHF5Fu0k9qmB32HN3LM82RUx3t8QJ 5tffEyaCJtYZvPnJsQ6bFMWoz1o0hObsPc/g0xDcmIWFRcgmhlfYSQpwBH3FpMfOECwn ePrx4pw1D41VBZqd96Cn+SRigdXYdb2AFrDbWOsu7AJph4FXoV45YU1g4G/jW0UngoZp H0wKDkRjQSUO3ZCUdvQ775joP8U8Jm9XokMiC31NwJcsgaqA7BqvxNFoDDe2IfO/Xlx3 oGfw== X-Gm-Message-State: APjAAAV4JxuUMg5rO7WtLI0sxWkeZ4vaq6JrUVNqizRJ19uHT6rrpis3 Cr8dxQ76B0wBeTaR5An7R8s8Hw== X-Google-Smtp-Source: APXvYqxRFrgtzPEpZUJQFL0cvUj8PIoUoX8aEA37dhl7JfSNLKhylBl4vfwQvA2h0oB7hxjKNogjvQ== X-Received: by 2002:a7b:c212:: with SMTP id x18mr9720984wmi.77.1565345247882; Fri, 09 Aug 2019 03:07:27 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h14sm95280297wrs.66.2019.08.09.03.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2019 03:07:27 -0700 (PDT) Date: Fri, 9 Aug 2019 11:07:25 +0100 From: "Leif Lindholm" To: Michael Brown Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, pete@akeo.ie Subject: Re: [edk2-platforms: PATCH v2 0/1] Platform/RPi3: Report device tree Message-ID: <20190809100725.GJ25813@bivouac.eciton.net> References: <20190806170719.GJ25813@bivouac.eciton.net> <20190808231625.1730843-1-mbrown@fensystems.co.uk> MIME-Version: 1.0 In-Reply-To: <20190808231625.1730843-1-mbrown@fensystems.co.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 09, 2019 at 12:16:24AM +0100, Michael Brown wrote: > On 06/08/2019 18:07, Leif Lindholm wrote: > > Happy with all of this, except for the use of EFI_DEVICE_ERROR. > > > > Generally, EFI_DEVICE_ERROR is used as an i/o error type status. > > Either EFI_NOT_FOUND, EFI_INVALID_PARAMETER or EFI_OUT_OF_RECOURCES > > would be more appropriate when referring to device-tree manipulation. > > > > Could you update these and spin a v2 please? > > Here you go. I have switched all of the EFI_DEVICE_ERROR uses to > EFI_NOT_FOUND, because I could not find any more appropriate > EFI_STATUS value to represent "device tree appears to be corrupted". > > (EFI_INVALID_PARAMETER seemed misleading to me, since there is nothing > wrong with the parameters provided by the caller.) Fair point, and agree with the choice. Reviewed-by: Leif Lindholm Pushed as 812b291c5589. Thanks! > Michael Brown (1): > Platform/RPi3: Report device tree modification errors using Print() > > .../RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 102 ++++++++++++------ > 1 file changed, 70 insertions(+), 32 deletions(-) > > -- > 2.21.0 >