From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=cU0s69h2; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Fri, 09 Aug 2019 03:15:41 -0700 Received: by mail-wm1-f67.google.com with SMTP id z23so5122208wmf.2 for ; Fri, 09 Aug 2019 03:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PEJPUjyNSIOwKnB3lHsIb1pS+9g2VwX8qqDfn97aoWE=; b=cU0s69h2E9HcbzgQgKDlb0DJt5aw0YAetxFZSBC8Mbd9xRoIOFbCmAbFTaHEu9bjvs /RBqfTS16DOyBFJM82cGCRnjxEyVclVn9J+ussCuP3lDEb4Ke8O3cGxGqj28JkLZFm0s 5vooH3F/G1VJi7BghXoRIp+1tCX7Geap1etxJkHXO8Ij0r8WnzkyRBbA9k9LfLhiTMjQ mb3yCwLXCD4fUcIvOayp1bAvcBNHF+/Ql3B8VTXCWm8uzSg8rzce8AI8bnck/5B9yDpI f/bfGOP8e+BnsBeEbF9bRA9B4nyE6RHegDRbjIHmYUmEuTmtq5PQne6C98Z8VR7YdYb7 oj2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PEJPUjyNSIOwKnB3lHsIb1pS+9g2VwX8qqDfn97aoWE=; b=fS/Bxb/3iefs4W+zFekFlBClFCahMqtO/MIER57GsQL5sbUOCDfs2ru2GxHZ25pfCz PBBdjxG87KtPEX+jluK/r5ERAJ+PsRnvH6AK4APzxuoCm4RGiAQtpSy6kaIUbOf0Ttq6 JmE0wACpYbmF4WQRy0Y/Pz+Qx2W5TFNjiZZ+pyVo2C561N448D3FKVuN0GtT5Uo6IWdA EukPxIQe+UCDIEtQ7LiC45xBJ/M7yDndfuPUDTjeJ58Qt0eseMLd2YiChMVcWYWl69nD M1+pG1VG6J2dj5be4WtocZqBrHruOxrrRMI+9USKTfGNU7pSZurkCk4+Hp+n5+Fii6+4 plrA== X-Gm-Message-State: APjAAAUVplWN8uW0xNmhtuhjqZqTBxEQD+9CDS2AhW4OLGYktlsCPpCI K7pwXo7LzEMGmt4oNX+EdVtb1g== X-Google-Smtp-Source: APXvYqzDwRrNl6jS1YtIiwywMwrLfn53m/M61oGcr4FNZjDMdGyUJpkUN+QOEtOw7b+8Vy2ngNJG1A== X-Received: by 2002:a1c:968c:: with SMTP id y134mr9852106wmd.75.1565345739362; Fri, 09 Aug 2019 03:15:39 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 15sm3692024wmk.34.2019.08.09.03.15.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 03:15:38 -0700 (PDT) Date: Fri, 9 Aug 2019 11:15:37 +0100 From: "Leif Lindholm" To: "Loh, Tien Hock" Cc: "Kinney, Michael D" , "devel@edk2.groups.io" , "thloh85@gmail.com" , Ard Biesheuvel Subject: Re: [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support Message-ID: <20190809101537.GK25813@bivouac.eciton.net> References: <20190801103213.118840-1-tien.hock.loh@intel.com> <20190805092616.GB25813@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Tien Hock, Given Mike's review, could you roll a v7 with all of the incorporated feedback from Mike based on this (instead of submitting the v6 updates as a separate patch, which I previously requested)? Could you also roll in the following in that patch?: diff --git a/Maintainers.txt b/Maintainers.txt index 876ae5612ad8..47d58ffa0b2c 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -98,6 +98,11 @@ M: Shifei A Lu M: Xiaohu Zhou M: Isaac W Oram +Platform/Intel/Stratix10SocPkg +M: Leif Lindholm +M: Michael D Kinney +R: Tien Hock Loh + Platform/Intel/Tools M: Bob Feng M: Liming Gao Best Regards, Leif On Fri, Aug 09, 2019 at 02:17:42AM +0000, Loh, Tien Hock wrote: > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Friday, August 9, 2019 3:50 AM > > To: Leif Lindholm ; Loh, Tien Hock > > ; Kinney, Michael D > > > > Cc: devel@edk2.groups.io; thloh85@gmail.com; Ard Biesheuvel > > > > Subject: RE: [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform support > > > > Tien Hock, > > > > I have a few comments: > > > > 1) Recommend change name of directory > > > > Platform/Intel/Startix10 -> Platform/Intel/Startix10SocPkg. > OK will do that. > > > > > 2) S10ClockManager.c is missing file header with license and copyright > > 3) S10ClockManager.h is missing file header with license and copyright > Yeah, I'll submit a fix to that > > > 4) PlatformHookLib.inf uses '..' to access sources in a different directory. > > '..' should never be used in an INF. This INF also lists many > > PCDs that are not used by PlatformHookLib.c > OK I'll remove the dependencies. > > > 5) PlatformHookLib.c also uses '..' in an include that should not > > be used. > > 6) Can the following files be updated to a BSD+Patent license and > > use an SPDX identifier? > > > > IntelPlatformDxe.inf > > IntelPlatformDxe.c > > > > IntelPlatformLib.inf > > Stratix10PlatformLib.c > > Startix10Mmu.c > > ArmPlatformHelper.S > > > OK. Noted, I missed changing these license headers. > > > If S10ClockManager is only used by the PlatformHookLib, then I > > recommend you move the S10ClockManager sources into the > > PlatformHookLib > > directory or a subdirectory below PlatformHookLib. > > > The S10ClockManager is also being used by Drivers/IntelPlatformDxe/IntelPlatformDxe.c, so I'm wondering what's the best approach to this? > > > Thanks, > > > > Mike