From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Bpvo0Q4V; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Fri, 09 Aug 2019 03:32:36 -0700 Received: by mail-wr1-f67.google.com with SMTP id 31so97804379wrm.1 for ; Fri, 09 Aug 2019 03:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Rodl7NktSuo3juc0zkTSvwtsgq6lDiIOOPn11VgXiMI=; b=Bpvo0Q4VL4M5XblWmxDfdXsZC9jXlJDEvOQY2KTgYvdZfXM64hgS59pTq8caBnzBj5 4L8OHEhUOuf9GJH+fK6z/eElRmc0GFH1ZdF0KPAL89wlvO1WdDdVWBcKtRCfyDun1X8q e60J1Z7rnunmZbs+x611v9O5CdhJaatON8xaxVwRnKAOjZIsv/nYxlozzRTuqaLfWvmo WAIEIWe+cTjbg2tMmroqVHjhUvRUORd9ORqIkBHe86vE7qOi323FO886nuVijvwKAc3p V337Yuu9rVP6FmY06tI+6p+jpJ8btw1QgN1t6LpvIlT8pnqj2jQmp1/MLRPmWpbAf0tJ UuAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Rodl7NktSuo3juc0zkTSvwtsgq6lDiIOOPn11VgXiMI=; b=NCEyy9qpwGN3vNJEImPIYVQKA0AObXm/fmK8naZKYAKes4Tg3MZi1p+2PWYzxR+rGO N9Adxh7zfLo0cWqm7lC+7/CU+Q+0gcvGUUtEag5XAdFjev4T+usgvKmB15f4FdrQ+dZA Gtsq0ZOIeIiG6aElnXp+zKYTDECKoSKDUuj5xWNEqNDRyJU1+ir1t3NI4LGQF60NRzvH wGSkDyWMunoElAbfWfI9e2Jot4UsvOauyUQoKtwu9jsP5DvmWDz3TgBYDD9P/zjAhmh5 1V6fbeWMw4Hi1tsDolBbL7ayVzKGr/rP8LVCA5gvRskj6IPduGdAKIAyfCmRImR2Huvi WBVQ== X-Gm-Message-State: APjAAAW6cDE8C8E08O2F8gOoaXEoQQAaBEib4GYey9roFP/nNvKKPvkH 4cULmgCf/xaXLr51oAFqgyi9/A== X-Google-Smtp-Source: APXvYqyUlsyegVACeJeRm8tv9vI0NvokfoO3lXBhRgH+JNDI3k3/NdO2K5DQLPqLkWh7H2D5AKh3Lg== X-Received: by 2002:adf:ff84:: with SMTP id j4mr21931223wrr.71.1565346754586; Fri, 09 Aug 2019 03:32:34 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m23sm1947487wml.41.2019.08.09.03.32.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 03:32:33 -0700 (PDT) Date: Fri, 9 Aug 2019 11:32:32 +0100 From: "Leif Lindholm" To: Nate DeSimone Cc: devel@edk2.groups.io, Andrew Fish , Laszlo Ersek , Michael D Kinney , Michael Kubacki , Ankit Sinha , Chasel Chiu Subject: Re: [edk2-platforms] [PATCH] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch Message-ID: <20190809103232.GL25813@bivouac.eciton.net> References: <20190808213048.35628-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 In-Reply-To: <20190808213048.35628-1-nathaniel.l.desimone@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 08, 2019 at 02:30:48PM -0700, Nate DeSimone wrote: > Updated Platform/Intel/Readme.md to point to master branch on > edk2-non-osi instead of devel-MinPlatform > > Updated edk2-platforms/Readme.md to point to Platform/Intel/Readme.md > for build instructions on Intel based Minimum Platforms > > Added a link to the EDK II Minimum Platform Draft Specification > to Platform/Intel/Readme.md > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Michael Kubacki > Cc: Ankit Sinha > Cc: Chasel Chiu > Signed-off-by: Nate DeSimone > --- > Platform/Intel/Readme.md | 6 ++++-- > Readme.md | 8 +++++++- > 2 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md > index 0a0e8a8c80..00f42985a2 100644 > --- a/Platform/Intel/Readme.md > +++ b/Platform/Intel/Readme.md > @@ -1,7 +1,9 @@ > # **EDK II Minimum Platform Firmware for Intel(R) Platforms** > > The Minimum Platform is a software architecture that guides uniform delivery of Intel platforms enabling firmware > -solutions for basic boot functionality with extensibility built-in. > +solutions for basic boot functionality with extensibility built-in. Please see the > +[EDK II Minimum Platform Draft Specification](https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/) > +for more details. > > Package maintainers for the Minimum Platform projects are listed in Maintainers.txt. > > @@ -98,7 +100,7 @@ return back to the minimum platform caller. > * ``git clone https://github.com/tianocore/edk2-platforms.git`` > > * edk2-non-osi repository > - * ``git clone https://github.com/tianocore/edk2-non-osi.git -b devel-MinPlatform`` > + * ``git clone https://github.com/tianocore/edk2-non-osi.git`` Really happy to see this change. > * FSP repository > * ``git clone https://github.com/IntelFsp/FSP.git`` > diff --git a/Readme.md b/Readme.md > index 63e59f60b4..28badd6b4b 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -34,6 +34,9 @@ edk2-devel mailing list with a subject prefix of `[platforms]`. See > on how to do this successfully. > > # How to build (Linux Environment) > +Note: Build instructions for Intel based Minimum Platforms differ from these > +instructions and are available at > +[`edk2-platforms/Platform/Intel/README.md`](https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Readme.md) Less happy to see this. I am well aware that there are platform-specific steps required to achieve the final firmware image for some systems. But we need to work to address that. There have been discussions about implementing support for hooking pre/post-build python scripts into the .dsc format - has there been any progress on that? For this patch, I would prefer if instead of adding these notes we changed the ## [Intel](Platform/Intel/Readme.md) ### Minimum Platforms * [Clevo](Platform/Intel/ClevoOpenBoardPkg) * [Kaby Lake](Platform/Intel/KabylakeOpenBoardPkg) * [Purley](Platform/Intel/PurleyOpenBoardPkg) links to all point to (Platform/Intel) instead. I realise that my intent with these platform links was unclear - for all of the ARM platforms, these point to directories that have their own Readme.md (meaning on github you see the documentation *and* the files when you click the link). Arguably, it would make sense to move all of the MinPlatform ... platforms ... and the Readme.md to a separate subdirectory and link to that directory. Not everything under Platform/Intel is a MinPlatform platform - soon there'll even be an ARM one. Best Regards, Leif