From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Andrew Fish <afish@apple.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen
Date: Fri, 9 Aug 2019 14:28:39 +0100 [thread overview]
Message-ID: <20190809132839.GM25813@bivouac.eciton.net> (raw)
In-Reply-To: <3df03b87-1b32-0647-ca68-54508df8aae0@redhat.com>
On Fri, Aug 09, 2019 at 02:54:31PM +0200, Laszlo Ersek wrote:
> On 08/09/19 03:37, Feng, Bob C wrote:
> > Thanks for your response.
> >
> > I'm going to push this patch set late today, if there is no more comments.
>
> Sorry, I have to disagree about that. There is a NACK standing from Leif
> -- he will have to rescind that NACK explicitly, for you to push the series.
>
> Leif: can you please confirm, in light of the new information [*] if you
> are OK with this v8 patchset being merged?
>
> [*] The new information is that "--hash" breaks "pick-up" after Ctrl-C,
> independently of the present patchset. So, it's not a regression from
> the new work, and if "--hash" is removed from the command line, the
> "pick-up" is successful both with and without these patches.
Ah, it was not clear to me that the bug was reproducible with --hash
without this set. (I read it as the bug was only reproducible with
this set if using --hash, which is not the same thing.)
In that case, I rescind my NACK.
Thank you for the clarification, Laszlo.
I would say this makes a fix for the --hash issue a hard requirement
for the stable tag.
Best Regards,
Leif
next prev parent reply other threads:[~2019-08-09 13:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 4:25 [Patch 00/10 V8] Enable multiple process AutoGen Bob Feng
2019-08-07 4:25 ` [Patch 01/10 V8] BaseTools: Singleton the object to handle build conf file Bob Feng
2019-08-07 4:25 ` [Patch 02/10 V8] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions Bob Feng
2019-08-07 4:25 ` [Patch 03/10 V8] BaseTools: Add functions to get platform scope build options Bob Feng
2019-08-07 4:25 ` [Patch 04/10 V8] BaseTools: Decouple AutoGen Objects Bob Feng
2019-08-22 8:04 ` [edk2-devel] " Gary Lin
2019-08-22 8:15 ` Bob Feng
2019-08-22 8:26 ` Gary Lin
2019-08-07 4:25 ` [Patch 05/10 V8] BaseTools: Enable Multiple Process AutoGen Bob Feng
2019-09-24 1:18 ` [edk2-devel] " dann frazier
2019-09-24 2:25 ` Bob Feng
2019-09-24 12:49 ` dann frazier
2019-08-07 4:25 ` [Patch 06/10 V8] BaseTools: Add shared data for processes Bob Feng
2019-08-07 4:25 ` [Patch 07/10 V8] BaseTools: Add LogAgent to support multiple process Autogen Bob Feng
2019-08-07 4:25 ` [Patch 08/10 V8] BaseTools: Move BuildOption parser out of build.py Bob Feng
2019-08-07 4:25 ` [Patch 09/10 V8] BaseTools: Add the support for python 2 Bob Feng
2019-08-07 4:25 ` [Patch 10/10 V8] BaseTools: Enable block queue log agent Bob Feng
2019-08-08 13:08 ` [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen Laszlo Ersek
2019-08-08 13:45 ` Leif Lindholm
2019-08-08 15:38 ` Bob Feng
2019-08-08 22:18 ` Laszlo Ersek
2019-08-08 23:29 ` Laszlo Ersek
2019-08-09 0:49 ` Liming Gao
2019-08-09 1:37 ` Bob Feng
2019-08-09 12:54 ` Laszlo Ersek
2019-08-09 13:28 ` Leif Lindholm [this message]
2019-08-09 14:54 ` Liming Gao
2019-08-09 15:31 ` Leif Lindholm
2019-08-09 15:09 ` Bob Feng
2019-08-09 14:42 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809132839.GM25813@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox