From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=l4uKHhu7; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 09 Aug 2019 06:28:42 -0700 Received: by mail-wm1-f68.google.com with SMTP id s3so5737839wms.2 for ; Fri, 09 Aug 2019 06:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KIcvxt44O+j8Oy6CPr2aHwSwZhzrF4rquwKcAAzGk/A=; b=l4uKHhu77PNwwoByfN8hMzZQVGdq7Rtu2ZZkrY5o/J6CMMlkRuecQhiNKfG5hcpWot w24LP03HENGUGRyMd7LkGN6ewQzN0l7UT5RzmZ0f8/u196oKZxpaTrzmgHXj0BkmY+mJ 3bru2Wjym4ASX5BgA+l3263I2dfYTaRVhvf+I8QawVn41vqXagPvjq3HPTbR59WxNGYz ZiL6J7F4yRxYP3e3jgHbDMRNM0fPHa5XR1fh3KzE89TvKQtpP5kA7DNpPbHoHswlVFnp ai+Ui/c6O5UuFNkt8P71OxOQXwBfnsoW8nqNn2eT3RVv1R+SpBbpxqRBGbAhzzPwn/w7 qNPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KIcvxt44O+j8Oy6CPr2aHwSwZhzrF4rquwKcAAzGk/A=; b=QVE7elILlyJBh5B+fTBv9kTY2aRmb+F8riY1UdoFlftwlJ6V/OP4DNrE05pSCpgw7A BjfU+ntaKWXJfM0TGA7uMZiwV6fwgLmUEJqN5HtX1NEN3vq0Xwp1aNpUyM9qXV1gNy6m BUiD4PlT1sY9oXbLbI+Z9FPoS77+5iLopiDMAYger1sC++PZRJ3bAgQjRmQwaxnIZNpJ c4+Meg+3+rIJ1zWD/aVEjedY9cEA/C9zpQvvEbUZE0C1rBipWHKmU/JSg41Ho6lmAA0k +E8IZHT8eNHuqSGbRrYkOAvlXD29l7F+nrqNihYLgihaO5vVlqWKSRb3Iue98tshTUXJ BE+g== X-Gm-Message-State: APjAAAUElYoGtrwNxEZSvNQLtUoVLarjwbI3zMMtwjptwUSa9f4mBKwM IzIi1Wnod9C1z6vD55mHr6jWSQ== X-Google-Smtp-Source: APXvYqwXfy7Q0Tgh7a6bDD4/GazE8ksqo3zG8lfkHsljKTruCIuZ5ThKhrtWXC4c2uBNBvzd7BhowA== X-Received: by 2002:a7b:c766:: with SMTP id x6mr11405143wmk.40.1565357321096; Fri, 09 Aug 2019 06:28:41 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f10sm86124800wrs.22.2019.08.09.06.28.40 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 06:28:40 -0700 (PDT) Date: Fri, 9 Aug 2019 14:28:39 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: "Feng, Bob C" , "Gao, Liming" , "devel@edk2.groups.io" , Andrew Fish , "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen Message-ID: <20190809132839.GM25813@bivouac.eciton.net> References: <20190807042537.11928-1-bob.c.feng@intel.com> <20190808134522.GY25813@bivouac.eciton.net> <08650203BA1BD64D8AD9B6D5D74A85D160B559E9@SHSMSX105.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CD287@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16150242B@SHSMSX105.ccr.corp.intel.com> <3df03b87-1b32-0647-ca68-54508df8aae0@redhat.com> MIME-Version: 1.0 In-Reply-To: <3df03b87-1b32-0647-ca68-54508df8aae0@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 09, 2019 at 02:54:31PM +0200, Laszlo Ersek wrote: > On 08/09/19 03:37, Feng, Bob C wrote: > > Thanks for your response. > > > > I'm going to push this patch set late today, if there is no more comments. > > Sorry, I have to disagree about that. There is a NACK standing from Leif > -- he will have to rescind that NACK explicitly, for you to push the series. > > Leif: can you please confirm, in light of the new information [*] if you > are OK with this v8 patchset being merged? > > [*] The new information is that "--hash" breaks "pick-up" after Ctrl-C, > independently of the present patchset. So, it's not a regression from > the new work, and if "--hash" is removed from the command line, the > "pick-up" is successful both with and without these patches. Ah, it was not clear to me that the bug was reproducible with --hash without this set. (I read it as the bug was only reproducible with this set if using --hash, which is not the same thing.) In that case, I rescind my NACK. Thank you for the clarification, Laszlo. I would say this makes a fix for the --hash issue a hard requirement for the stable tag. Best Regards, Leif