* [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression
@ 2019-08-09 19:34 Michael D Kinney
2019-08-11 15:37 ` Sun, Zailiang
2019-08-12 2:33 ` Gary Lin
0 siblings, 2 replies; 3+ messages in thread
From: Michael D Kinney @ 2019-08-09 19:34 UTC (permalink / raw)
To: devel; +Cc: Zailiang Sun, Gary Lin
The following commit removed the call to SetupInfo() from
SystemConfigExtractConfig(). This caused the BIOS, Processor,
Platform, and Memory information strings from being filled
in with their proper values.
https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5
The call to SetupInfo() is added back.
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Gary Lin <glin@suse.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
index 7a4987f656..f3850b2aff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
@@ -150,6 +150,7 @@ SystemConfigExtractConfig (
OUT EFI_STRING *Results
)
{
+ SetupInfo();
return EFI_UNSUPPORTED;
}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression
2019-08-09 19:34 [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression Michael D Kinney
@ 2019-08-11 15:37 ` Sun, Zailiang
2019-08-12 2:33 ` Gary Lin
1 sibling, 0 replies; 3+ messages in thread
From: Sun, Zailiang @ 2019-08-11 15:37 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io; +Cc: Gary Lin
Reviewed-by: Zailiang Sun <Zailiang.sun@intel.com>
-----Original Message-----
From: Kinney, Michael D
Sent: Saturday, August 10, 2019 3:34 AM
To: devel@edk2.groups.io
Cc: Sun, Zailiang <zailiang.sun@intel.com>; Gary Lin <glin@suse.com>
Subject: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression
The following commit removed the call to SetupInfo() from
SystemConfigExtractConfig(). This caused the BIOS, Processor,
Platform, and Memory information strings from being filled
in with their proper values.
https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5
The call to SetupInfo() is added back.
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Gary Lin <glin@suse.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
index 7a4987f656..f3850b2aff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
@@ -150,6 +150,7 @@ SystemConfigExtractConfig (
OUT EFI_STRING *Results
)
{
+ SetupInfo();
return EFI_UNSUPPORTED;
}
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression
2019-08-09 19:34 [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression Michael D Kinney
2019-08-11 15:37 ` Sun, Zailiang
@ 2019-08-12 2:33 ` Gary Lin
1 sibling, 0 replies; 3+ messages in thread
From: Gary Lin @ 2019-08-12 2:33 UTC (permalink / raw)
To: Michael D Kinney; +Cc: devel@edk2.groups.io, Zailiang Sun
On Fri, Aug 09, 2019 at 12:34:03PM -0700, Kinney, Michael D wrote:
> The following commit removed the call to SetupInfo() from
> SystemConfigExtractConfig(). This caused the BIOS, Processor,
> Platform, and Memory information strings from being filled
> in with their proper values.
>
> https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5
>
> The call to SetupInfo() is added back.
>
The system info is back after applying this patch.
Tested-by: Gary Lin <glin@suse.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Gary Lin <glin@suse.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> index 7a4987f656..f3850b2aff 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> @@ -150,6 +150,7 @@ SystemConfigExtractConfig (
> OUT EFI_STRING *Results
> )
> {
> + SetupInfo();
> return EFI_UNSUPPORTED;
> }
>
> --
> 2.21.0.windows.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-12 2:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-09 19:34 [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression Michael D Kinney
2019-08-11 15:37 ` Sun, Zailiang
2019-08-12 2:33 ` Gary Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox