From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.64.67, mailfrom: glin@suse.com) Received: from m9a0002g.houston.softwaregrp.com (m9a0002g.houston.softwaregrp.com [15.124.64.67]) by groups.io with SMTP; Sun, 11 Aug 2019 19:33:57 -0700 Received: FROM m9a0002g.houston.softwaregrp.com (15.121.0.191) BY m9a0002g.houston.softwaregrp.com WITH ESMTP; Mon, 12 Aug 2019 02:33:33 +0000 Received: from M9W0067.microfocus.com (2002:f79:be::f79:be) by M9W0068.microfocus.com (2002:f79:bf::f79:bf) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 12 Aug 2019 02:33:05 +0000 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (15.124.72.10) by M9W0067.microfocus.com (15.121.0.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 12 Aug 2019 02:33:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fq3oS4RONdv4aFZAurFSNiqvQzyQpcqWrS+OkDpP+uKJqsvlS3UNrouQTm30HS2qIkjqcX1kEOpmjrUWWeYIQsiS4f2VUItMGyOvZWRg/Z4TfWAEdpdp+wijfXiGbf1gbTAGWvF0HQJN+DvTMhV8g7zN4D6opWw0nUZnOaN1PJOF6OKhIr9D4YcaVJ8tFrgNsQeGWaCNJrmmWI7u4chSs9MP681PHeiQe6i8ADF5HfEAvVx7UgVY5CuWU9xXg8sbbAWX0UTI7ZcUikIPxWrLpegPEkLjSgHZLhvgaFdv6FjUJAhC+aNo5PNjTi2z/xkSGsCVqusXQei2yzTFDNSaTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ivtit6w5hEecp7+vFk3F6j0DU7LnHI7Ge4+4oftH/4=; b=OJKv8bg3XpDvMD4PCfLvWDNvBwCYsO+4L89j4YsYrrXQZUHcp/s90omn2q6gZ1qNFL334mu3q4Fm2goAg0s/c1VeHkUA03P/55L/X/JK/G+pfCKonhWg5vuP0ryXp3RiXDvV0jKxvctObRoG4PSMxkB/aZAeLok1PK2Uz/tFHKzFoj6k0ub/FZsyLmjea6Pn/cMXMwhGJjFx0ddvG0m/fljSjUWcPFa59JxBfE9W/wNTRYv2pPOqdTsBVtXM76R8Kj1ChRn98jUPSKtPAgrtrFs8n0mSd/B+xt6CbYRRZvaXTG4nKFJX+kMcD2H+SjzYDriw1uHqvAj0umGpMX1KmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB3179.namprd18.prod.outlook.com (10.255.172.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.18; Mon, 12 Aug 2019 02:33:04 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::95e2:f1a5:356c:9a5d]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::95e2:f1a5:356c:9a5d%3]) with mapi id 15.20.2157.022; Mon, 12 Aug 2019 02:33:04 +0000 From: "Gary Lin" To: Michael D Kinney CC: "devel@edk2.groups.io" , Zailiang Sun Subject: Re: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression Thread-Topic: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression Thread-Index: AQHVTul0nL2tmnRf4ECht1/V0nPHkab2zqcA Date: Mon, 12 Aug 2019 02:33:04 +0000 Message-ID: <20190812023252.GE26233@GaryWorkstation> References: <20190809193403.7392-1-michael.d.kinney@intel.com> In-Reply-To: <20190809193403.7392-1-michael.d.kinney@intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB7PR08CA0066.eurprd08.prod.outlook.com (2603:10a6:10:26::43) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0aad1286-59d6-4098-acb4-08d71ecd66e7 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB3179; x-ms-traffictypediagnostic: DM6PR18MB3179: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:519; x-forefront-prvs: 012792EC17 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(7916004)(346002)(366004)(39860400002)(376002)(136003)(396003)(199004)(189003)(66946007)(66476007)(66556008)(86362001)(64756008)(66446008)(2906002)(3846002)(33656002)(6116002)(80792005)(33716001)(9686003)(6306002)(6512007)(1076003)(5660300002)(229853002)(6486002)(6916009)(6436002)(8676002)(76176011)(52116002)(966005)(54906003)(8936002)(99286004)(6506007)(386003)(14454004)(102836004)(53936002)(81156014)(81166006)(6246003)(11346002)(446003)(476003)(4326008)(478600001)(25786009)(305945005)(7736002)(486006)(66066001)(71190400001)(71200400001)(186003)(256004)(26005)(316002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB3179;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: EV5r4SIJW42FwakEAGSXC7rhSOb+7OnFsWgsY4RybPkYjrZkHee3kzSGsAuauXUxcoJ7eM0D2V50Fsf/ocipPiv8ijn9+ucYIAQuqb89YY78sxFkKrijL967ciJ8vxbai2+3Mw8zwgPGE9pnxJz4x7039DgRMzVtL2DaD4lbMr6PZtnV44jZBGSiuDFQW7XscKgW1ksux7iAgrJvkHLkfGddLYuYOAioA+qqj21HdYW+GK5iuudTcUEpdNp1tT2VLDfHsSEBiJsqoHZQa4Odid72xJZ4CzooHl/iSMvjaDIdayYQ82bCWe4u/z7JZLcPsqqE9CqIBHvy8l9jkYpWYD+XAVCtlSyhqiIPFFxcEIpb255scsvNmWP4QilnUHp4yNblPSZD+pcqwBZUGGUv9ouqMA+G4iJJfiA7A2IVkr0= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0aad1286-59d6-4098-acb4-08d71ecd66e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2019 02:33:04.0612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FZNAtVKKkCprBjA1Cpc01yms3b2Wb0gVybV9Qq/ef7fM1x1Qnb/Zt80baXzKivsG X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3179 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <00B519FB7D6A2944A8B84FDE41DDC4F9@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Fri, Aug 09, 2019 at 12:34:03PM -0700, Kinney, Michael D wrote: > The following commit removed the call to SetupInfo() from > SystemConfigExtractConfig(). This caused the BIOS, Processor, > Platform, and Memory information strings from being filled > in with their proper values. >=20 > https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230= a4541bc2cb74c10ea5 >=20 > The call to SetupInfo() is added back. >=20 The system info is back after applying this patch. Tested-by: Gary Lin > Cc: Zailiang Sun > Cc: Gary Lin > Signed-off-by: Michael D Kinney > --- > .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSe= tupDxe.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupD= xe.c > index 7a4987f656..f3850b2aff 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.= c > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.= c > @@ -150,6 +150,7 @@ SystemConfigExtractConfig ( > OUT EFI_STRING *Results > ) > { > + SetupInfo(); > return EFI_UNSUPPORTED; > } > =20 > --=20 > 2.21.0.windows.1 >=20 >=20