From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.64.68, mailfrom: glin@suse.com) Received: from m9a0003g.houston.softwaregrp.com (m9a0003g.houston.softwaregrp.com [15.124.64.68]) by groups.io with SMTP; Sun, 11 Aug 2019 19:36:44 -0700 Received: FROM m9a0003g.houston.softwaregrp.com (15.121.0.190) BY m9a0003g.houston.softwaregrp.com WITH ESMTP; Mon, 12 Aug 2019 02:36:22 +0000 Received: from M9W0067.microfocus.com (2002:f79:be::f79:be) by M9W0067.microfocus.com (2002:f79:be::f79:be) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 12 Aug 2019 02:35:53 +0000 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (15.124.72.14) by M9W0067.microfocus.com (15.121.0.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 12 Aug 2019 02:35:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AcwTK+LOu7ml93KiW+x7blxwx6Xsq8b55YWk00KIKeC18d9l+bx4Ez/4OtXEdIQ3lrjwPWqMfK/fKonmG9suKi7Yw2X4t+mjoiNWsPSZRLARXaA8cbinjVZNohT0dOe7lOeB/B95rX+j/ax8HcD5WV5Ne2jrpd8+p5EScn0ElEYOKZj1eu57y0vspPct3a800IbjLcvRwODJj6cKFe2ueYUz7nMxq1Y2mxB98ouG2wNbPzp4uyxlB4UdgsDW/PV7mEXctHBvmky5AnVke5DBZxi65OTEopFSKURJFc0KL/5EWRLjd6RUzWX6IQBbdzhUzizLm5616vLnu4gNaCWwIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UKHJP7lbvuyD1YHnzjUXD6SbEFSxf4tGZw+muetYw+M=; b=RUITUWyj3AFV8Bi58b+/BctElUWweCohj80wGGIlOVEjuO8Sa/KqvyTnOHumLEtnx3r66yTrrBhcgJk7iKOfwyKQL8ftIETRqudRm/3yJD6ncePsY5pPXkY+Q38d0tAtshdNYM/5zP+9yHRP8lQVfK5YYRknoIlEyNwpqaNYdUVHhmRB0bPLOoxuKEx9QgZcWOh6ksQObl9l4Nv2epQdhl/O4UksI6vTxP0rPKcI4jfum1YPArpOSWTQFunkLw2zJn8zyBo1TMdC2gL8c3D/xzgrC6ljQ2zm8kR0q2cyIoYbfmist/8q7Rdsv98CIOE7vCVGXEmv9RmYoUJljuQwhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB3179.namprd18.prod.outlook.com (10.255.172.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.18; Mon, 12 Aug 2019 02:35:52 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::95e2:f1a5:356c:9a5d]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::95e2:f1a5:356c:9a5d%3]) with mapi id 15.20.2157.022; Mon, 12 Aug 2019 02:35:52 +0000 From: "Gary Lin" To: Michael D Kinney CC: "devel@edk2.groups.io" , Zailiang Sun Subject: Re: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic Thread-Topic: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic Thread-Index: AQHVTvjI006GJcWUUE2LNpIUkgT4Vqb2z1KA Date: Mon, 12 Aug 2019 02:35:52 +0000 Message-ID: <20190812023541.GF26233@GaryWorkstation> References: <20190809212348.12492-1-michael.d.kinney@intel.com> In-Reply-To: <20190809212348.12492-1-michael.d.kinney@intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB7PR03CA0079.eurprd03.prod.outlook.com (2603:10a6:10:72::20) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b9182b8-1983-481e-2a02-08d71ecdcb14 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB3179; x-ms-traffictypediagnostic: DM6PR18MB3179: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 012792EC17 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(7916004)(346002)(366004)(39860400002)(376002)(136003)(396003)(199004)(189003)(66946007)(66476007)(66556008)(86362001)(64756008)(66446008)(2906002)(3846002)(33656002)(6116002)(80792005)(33716001)(9686003)(6512007)(1076003)(5660300002)(229853002)(6486002)(6916009)(6436002)(8676002)(76176011)(52116002)(54906003)(8936002)(99286004)(6506007)(386003)(14454004)(102836004)(53936002)(81156014)(81166006)(6246003)(11346002)(446003)(476003)(4326008)(478600001)(25786009)(305945005)(7736002)(486006)(66066001)(71190400001)(71200400001)(186003)(256004)(14444005)(26005)(316002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB3179;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WPTv4GelD54/pBW3WOhwrVloYnAIFgSfLWkhB7npahnyYqRnfwLXNqhPp29LNPM0vNC9GtmV25AkEf24W7OdMNvVmv1tMV72DZtcY+CMERbnZ1QcGVULW7ZTWu+z6lYv4lWLaJQUSKl4n3AeLJXdTh4X0SF3lxfjcyeDbd0M+P2hlVMBMfQhr3nM7VoPNj2W6Iy2SjrOfpdYvoKJGnJ2CW8WhHrudKgG8YJYAZN54fVQpA6Yc3/6Lq1u9Ho07zDauP0EOzPYFwZhNoWROeA+cZDCvwDy4qGOfEcfaWJXrHI7t8JbklXE2PMlyHFn1pNKGdnywO4xzYobOg8qrz+xYXENmLyqc6bjpnrl2h+tnTqljFb6wkpiJkujzhvXz8VO3+pz/oeR3v8797B8LQdJlleeRdARq7uTBLfcdWtNKTY= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5b9182b8-1983-481e-2a02-08d71ecdcb14 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2019 02:35:52.1239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2GGvzukEw9Gkl86BOolUgaUXleBQYSxkCQJn36p9HPKjp/+fTfEu2WMpVScty1fe X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3179 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <461EBA23D9C2654FA6EB120F382225CE@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Fri, Aug 09, 2019 at 02:23:48PM -0700, Kinney, Michael D wrote: > VS2017 builds for X64 are failing due to the use of the > memset intrinsic. The local variable GopVersion is an > array that is initialied in the declaration. Update to > use ZeroMem() to intialize GopVersion. >=20 Looks reasonable to me. Reviewed-by: Gary Lin > Cc: Zailiang Sun > Cc: Gary Lin > Signed-off-by: Michael D Kinney > --- > .../Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpReg= ion.c b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c > index fcd9e566ae..3815c8fa9c 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c > +++ b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c > @@ -493,9 +493,10 @@ SetGOPVersionCallback ( > IN VOID *Context > ) > { > - CHAR16 GopVersion[16] =3D {0}; > + CHAR16 GopVersion[16]; > EFI_STATUS Status; > =20 > + ZeroMem (GopVersion, sizeof (GopVersion)); > Status =3D GetGOPDriverVersion(GopVersion); > if(!EFI_ERROR(Status)) { > StrCpy((CHAR16*)&(mIgdOpRegion.OpRegion->Header.GOPV[0]), GopVersion= ); > --=20 > 2.21.0.windows.1 >=20 >=20