* [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic
@ 2019-08-09 21:23 Michael D Kinney
2019-08-11 15:37 ` Sun, Zailiang
2019-08-12 2:35 ` Gary Lin
0 siblings, 2 replies; 3+ messages in thread
From: Michael D Kinney @ 2019-08-09 21:23 UTC (permalink / raw)
To: devel; +Cc: Zailiang Sun, Gary Lin
VS2017 builds for X64 are failing due to the use of the
memset intrinsic. The local variable GopVersion is an
array that is initialied in the declaration. Update to
use ZeroMem() to intialize GopVersion.
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Gary Lin <glin@suse.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
.../Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
index fcd9e566ae..3815c8fa9c 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
@@ -493,9 +493,10 @@ SetGOPVersionCallback (
IN VOID *Context
)
{
- CHAR16 GopVersion[16] = {0};
+ CHAR16 GopVersion[16];
EFI_STATUS Status;
+ ZeroMem (GopVersion, sizeof (GopVersion));
Status = GetGOPDriverVersion(GopVersion);
if(!EFI_ERROR(Status)) {
StrCpy((CHAR16*)&(mIgdOpRegion.OpRegion->Header.GOPV[0]), GopVersion);
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic
2019-08-09 21:23 [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic Michael D Kinney
@ 2019-08-11 15:37 ` Sun, Zailiang
2019-08-12 2:35 ` Gary Lin
1 sibling, 0 replies; 3+ messages in thread
From: Sun, Zailiang @ 2019-08-11 15:37 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io; +Cc: Gary Lin
Reviewed-by: Zailiang Sun <Zailiang.sun@intel.com>
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Saturday, August 10, 2019 5:24 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Gary Lin <glin@suse.com>
> Subject: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic
>
> VS2017 builds for X64 are failing due to the use of the
> memset intrinsic. The local variable GopVersion is an
> array that is initialied in the declaration. Update to
> use ZeroMem() to intialize GopVersion.
>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Gary Lin <glin@suse.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> .../Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> index fcd9e566ae..3815c8fa9c 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> @@ -493,9 +493,10 @@ SetGOPVersionCallback (
> IN VOID *Context
> )
> {
> - CHAR16 GopVersion[16] = {0};
> + CHAR16 GopVersion[16];
> EFI_STATUS Status;
>
> + ZeroMem (GopVersion, sizeof (GopVersion));
> Status = GetGOPDriverVersion(GopVersion);
> if(!EFI_ERROR(Status)) {
> StrCpy((CHAR16*)&(mIgdOpRegion.OpRegion->Header.GOPV[0]),
> GopVersion);
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic
2019-08-09 21:23 [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic Michael D Kinney
2019-08-11 15:37 ` Sun, Zailiang
@ 2019-08-12 2:35 ` Gary Lin
1 sibling, 0 replies; 3+ messages in thread
From: Gary Lin @ 2019-08-12 2:35 UTC (permalink / raw)
To: Michael D Kinney; +Cc: devel@edk2.groups.io, Zailiang Sun
On Fri, Aug 09, 2019 at 02:23:48PM -0700, Kinney, Michael D wrote:
> VS2017 builds for X64 are failing due to the use of the
> memset intrinsic. The local variable GopVersion is an
> array that is initialied in the declaration. Update to
> use ZeroMem() to intialize GopVersion.
>
Looks reasonable to me.
Reviewed-by: Gary Lin <glin@suse.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Gary Lin <glin@suse.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> .../Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> index fcd9e566ae..3815c8fa9c 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c
> @@ -493,9 +493,10 @@ SetGOPVersionCallback (
> IN VOID *Context
> )
> {
> - CHAR16 GopVersion[16] = {0};
> + CHAR16 GopVersion[16];
> EFI_STATUS Status;
>
> + ZeroMem (GopVersion, sizeof (GopVersion));
> Status = GetGOPDriverVersion(GopVersion);
> if(!EFI_ERROR(Status)) {
> StrCpy((CHAR16*)&(mIgdOpRegion.OpRegion->Header.GOPV[0]), GopVersion);
> --
> 2.21.0.windows.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-12 2:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-09 21:23 [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic Michael D Kinney
2019-08-11 15:37 ` Sun, Zailiang
2019-08-12 2:35 ` Gary Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox