From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=hyXrTKrS; spf=pass (domain: linaro.org, ip: 209.85.128.46, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by groups.io with SMTP; Tue, 13 Aug 2019 11:30:03 -0700 Received: by mail-wm1-f46.google.com with SMTP id v19so2287011wmj.5 for ; Tue, 13 Aug 2019 11:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fOwGxMkvKkI37f/ugI8MxM0gyMzrmPZ5EGa3q5RefEo=; b=hyXrTKrS46RPOCNCxCEWoLJMPIHy/l1gAOrOyO4QDXWU/iy/hgqWXsvliExIwyatbU p8bzwJXEJzhkbbQWYIIBETqO9lNbvQwrwPK96NcHCjvX4wKNL7d/BPNWFzio+sFWL93T Icq1Zo49jfab3nB/FeO5+gD5y4+IsRQbzgRcOXMz0EWJ77qQYIebAuU5gNI3/Jtl6On6 NsdtlqD7BdooTi9NEju4xbgxVblbxmbas6ykHdafGTOyOxeZraSv+YTYL6wkcp7YqpKR gg9TAtKOGkIzT4xUBlGCaZBaX4hV/Ogqacon/I+4udgKhrDFaOhrjK6cMH1EMNj9rS6L VsJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fOwGxMkvKkI37f/ugI8MxM0gyMzrmPZ5EGa3q5RefEo=; b=XuDxtWI9K/BQh23KHWQvrKS9PjuuN03cyh9+w9dASG7LcvOF4IoAYkidM4k5XyZo/I 4pJBuQlzCTrPkk6qdT98SE2KL+OAW5Mha/jk7yiUckb96hJYI//TLsvTSTgqJ7bPkJPC JmHf6TCxVbkuq35WQOciDEFvbVcQF1eXjj+uRpGFkTE3xfLtagy94Zr+KnVz7NjG2eu5 stHxdU+PsKyAVKgTAzBWwI6kvhj5MWF0ddDccbplP2bQxR4o3cz7JzA56o1/3qIUnh2q XgnlkuBDKDeHYZVkACEMAX63XO4GksB1PTIi8T2K4O/INUJ3807M3Yzkn+E7AzdUzJzr RH2A== X-Gm-Message-State: APjAAAXpJtQ2+Ez0d1JFkTcmWpfKn1Q6Am56MaJ0cT2MiFEMx+X31QO/ cMVVCAZmpw38UQ3GFLL49p8B2g== X-Google-Smtp-Source: APXvYqz/0WdQmQaaSZARf6GxB3cjFGmAlCV1cQ72oY+/v+IMkERtSAp11wsX1hlYVC0irS2wyuw6zQ== X-Received: by 2002:a7b:c85a:: with SMTP id c26mr4447562wml.77.1565721001391; Tue, 13 Aug 2019 11:30:01 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p10sm2585976wma.8.2019.08.13.11.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2019 11:30:00 -0700 (PDT) Date: Tue, 13 Aug 2019 19:29:58 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: "Chiu, Chasel" , "rfc@edk2.groups.io" , "Feng, Bob C" , "devel@edk2.groups.io" , "Cetola, Stephano" , "Laszlo Ersek (lersek@redhat.com)" , "afish@apple.com" , "Kinney, Michael D" Subject: Re: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Message-ID: <20190813182958.GE29255@bivouac.eciton.net> References: <3C3EFB470A303B4AB093197B6777CCEC5045B801@PGSMSX111.gar.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02AD@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02AD@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I am not fundamentally opposed to merging a simple script that does not affect other code in the tree. *But* the fact that we have multiple occurrences of this this time around *is* a bit of a concern for me. Yes, they won't affect the workings of anything else as part of the release. But they will not have had any chance to be actually used by others. For this particular script, I am also not very keen on the implementation. It manually parses the command line and prints usage instead of using argparse. And it contains the sys.exit(Main()) antipattern, which does not play well with Python3 asynchronous i/o (and hence is a bad habit to get into). Since this script is truly trivial, I am OK for it to be included *if* it is rewritten using argparse and not calling sys.exit. Best Regards, Leif On Tue, Aug 13, 2019 at 01:42:23PM +0000, Gao, Liming wrote: > This is a small helper script. I am OK to add it for edk2-stable201908 stable tag. > > Thanks > Liming > From: Chiu, Chasel > Sent: Monday, August 12, 2019 3:45 PM > To: rfc@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; devel@edk2.groups.io > Subject: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. > > > Hello, > > I would like to add below simple script to 201908 stable tag, review was sent on August 8th: > > A script that can return UTC date and time in ascii format which is convenient for patching build time information in any binary. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 > Patch: https://edk2.groups.io/g/devel/topic/32797962#45177 > > Thanks! > Chasel >