public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "Jin, Eric" <eric.jin@intel.com>,
	"rfc@edk2.groups.io" <rfc@edk2.groups.io>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	"Cetola, Stephano" <stephano.cetola@intel.com>,
	"Laszlo Ersek (lersek@redhat.com)" <lersek@redhat.com>,
	"afish@apple.com" <afish@apple.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag
Date: Tue, 13 Aug 2019 19:47:17 +0100	[thread overview]
Message-ID: <20190813184717.GF29255@bivouac.eciton.net> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D0329@SHSMSX104.ccr.corp.intel.com>

Hi Liming,

This is the other one. As I said, the fact that we are slipping
multiple scripts in *just* before freeze is a concern for me.

I have no objection to the code here though.

I would however request that Sean is set as author on patch 1/2 as he
was the original author of the script. (This was easy for me to find
out because the commit message was exemplary.)

Best Regards,

Leif

On Tue, Aug 13, 2019 at 01:49:24PM +0000, Gao, Liming wrote:
> I see this patch was sent a week ago. This is a standalone tool. There is no impact on normal build and boot. I am OK to add it for 201908 stable tag.
> 
> Thanks
> Liming
> From: Jin, Eric
> Sent: Monday, August 12, 2019 3:09 PM
> To: rfc@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Jin, Eric <eric.jin@intel.com>; devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
> Subject: [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag
> 
> Hi All,
> 
> It is the request to Enable Windows Firmware Update Driver Tool in Edk2/BaseTools  and catch the Q3 tag.
> The new tool will leverage the edk2-pytool-library to generate the cat/inf file based on the cap file. The output driver package can be trigged in Windows OS to complete capsule update.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1837
> 
> Patch link: https://edk2.groups.io/g/devel/topic/32780378#44992
> 
> Best Regards
> Eric
> 
> 

  reply	other threads:[~2019-08-13 18:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12  7:08 [RFC] BZ 1837 Enable Windows Firmware Update Driver Tool in Edk2/BaseTools for 201908 stable tag Eric Jin
2019-08-13 13:49 ` Liming Gao
2019-08-13 18:47   ` Leif Lindholm [this message]
2019-08-14  7:00     ` [edk2-devel] " Eric Jin
2019-08-14 16:19     ` Eric Jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190813184717.GF29255@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox