From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=exMkbJ/N; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Wed, 14 Aug 2019 10:03:55 -0700 Received: by mail-wm1-f68.google.com with SMTP id v19so5080540wmj.5 for ; Wed, 14 Aug 2019 10:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=W1yOBytRz4RrYnuspaaU2CPMrZLRz0pSCpzAVbWlaME=; b=exMkbJ/NalHD0viuWxYRxfmGOvTuazU5OhIdG4VSXpBiNJ0qL5ruEMIYipbdt39iqf Ic1KIeMR+t6D+8rKmNDbX3LhSg5Wm1dfz1P4Jt6lP2sgESUlQwpV0ywaNEfWmWGd/jVs hceIuXmpKZDnNeboT0NodJYP+cLfc9XH6VxP3hMnfOjLsMf9cq/clnIhFRWUU6rA+76B fyK1Dim4gTeKc8g2pUTCt11s+8gMbFEMNRM7fmr6+EKU0M46/BgG9bbEHgITowHmqku0 wK02d57DOkd+k7QG5TJY91xJ3U9nUV52qgKtbKH/1/qOF6+n4rXK2pagY+bVW752fJTp I07w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=W1yOBytRz4RrYnuspaaU2CPMrZLRz0pSCpzAVbWlaME=; b=ujG629qepWgk2oatrkE2uxcSRKj8p0VLINdqxOhn6gRzI8ICjw+6J5cU5j//MjlUJo TViENRyxD7zyQPpwJdtPaa2iTeKckrWHMaLhhFDoASHFVUTvRrQHyTj+badB6LC+IrJy sTJDwb6qATVmJlZLB2fwNg8bpPiukQTczvqIhey04XR9i8uF63YgdpttV0Z2RIgXj6D0 cR8hfoxlyXQEd2aFuIkqNDzeuDJxXPPEi+GE9j+31ynEzbvLDGnoOPNRsGkTbjolUGPB h5msk0ZPolSCnVCgp8fDrJqLI6+1PQiP+8r939X6t7AfD3kP2Sc/QcbD6KPScnvNirlq 8zQw== X-Gm-Message-State: APjAAAWDr/QHJz0xqy+EcK4bGVWi79+KFyVcWxXsjH3kI2Me8S4pWe1+ +DhHwKaI8NGFvJbWIH1ZxO9HaQ== X-Google-Smtp-Source: APXvYqw/7EtOrYCx4OhLt4aWTQqeceSWUORgcLzNqS1gZFz4QETD1bULtA5/aJVMKqfPwvX9UGAhBQ== X-Received: by 2002:a1c:7a12:: with SMTP id v18mr155037wmc.56.1565802233659; Wed, 14 Aug 2019 10:03:53 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p10sm248530wma.8.2019.08.14.10.03.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 10:03:52 -0700 (PDT) Date: Wed, 14 Aug 2019 18:03:51 +0100 From: "Leif Lindholm" To: Andy Hayes Cc: "devel@edk2.groups.io" , "michael.d.kinney@intel.com" Subject: Re: [PATCH v1 0/1] Added GOP driver for DisplayLink-based Universal USB Docks to edk2-platforms Message-ID: <20190814170351.GI29255@bivouac.eciton.net> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Andy, Many thanks for this submission. I am finding a few issues when building with gcc/clang (I expect you use Visual Studio). The RELEASE target barfs with .../edk2-platforms/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Gop.c:363:1: error: unused function 'CalculateRefreshRate' since the function is only called from a DEBUG statement. Could be resolved by putting the function inside #ifndef MDEPKG_NDEBUG Clang triggers an error on the USB_DISPLAYLINK_DEV_FROM_GRAPHICS_OUTPUT_PROTOCOL macro which seems to go away if the USB_DISPLAYLINK_DEV_SIGNATURE macro is moved below the USB_DISPLAYLINK_DEV definition. (I haven't bothered to figure out why this helps.) The NOOPT build fails for IA32/X64 on clang with .../edk2-platforms/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDescriptors.c:35: undefined reference to `memset' You could get rid of this by doing the assignment separate from the definition. (Indeed, I believe this is one of the reasons for the rule.) On X64/clang, the build fails with .../edk2-platforms/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDisplayLink.c:410:3: error: '__builtin_ms_va_start' used in System V ABI function Adding EFIAPI to the definition/declaration of DlGopPrintTextToScreen makes this one go away. Best Regards, Leif On Wed, Aug 14, 2019 at 02:43:43PM +0000, Andy Hayes wrote: > From 4a42eb997aeb3699217b40bf3bc47dec56458847 Mon Sep 17 00:00:00 2001 > From: "Andy Hayes" < andy.hayes@displaylink.com > > Date: Wed, 14 Aug 2019 15:30:20 +0100 > Subject: [PATCH v1 0/1] Added GOP graphics driver for DisplayLink-based Universal USB Docks to edk2-platforms > > andy.hayes@displaylink.com (1): > Added GOP driver for USB Docks which use DisplayLink chips. > > .../DisplayLinkPkg/DisplayLinkPkg.dsc | 61 + > .../DisplayLinkGop/DisplayLinkGopDxe.inf | 63 + > .../DisplayLinkPkg/DisplayLinkGop/Edid.h | 129 ++ > .../DisplayLinkGop/UsbDescriptors.h | 109 ++ > .../DisplayLinkGop/UsbDisplayLink.h | 284 +++++ > .../DisplayLinkGop/CapabilityDescriptor.c | 137 ++ > .../DisplayLinkGop/ComponentName.c | 235 ++++ > .../DisplayLinkPkg/DisplayLinkGop/Edid.c | 598 +++++++++ > .../DisplayLinkPkg/DisplayLinkGop/Gop.c | 587 +++++++++ > .../DisplayLinkGop/UsbDescriptors.c | 144 +++ > .../DisplayLinkGop/UsbDisplayLink.c | 1109 +++++++++++++++++ > .../DisplayLinkGop/UsbTransfer.c | 180 +++ > .../DisplayLinkGop/VideoModes.c | 254 ++++ > Drivers/DisplayLink/DisplayLinkPkg/ReadMe.md | 77 ++ > Maintainers.txt | 5 + > 15 files changed, 3972 insertions(+) > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/DisplayLinkGopDxe.inf > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Edid.h > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDescriptors.h > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDisplayLink.h > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/CapabilityDescriptor.c > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/ComponentName.c > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Edid.c > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Gop.c > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDescriptors.c > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDisplayLink.c > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/VideoModes.c > create mode 100644 Drivers/DisplayLink/DisplayLinkPkg/ReadMe.md > > -- > 2.17.1