From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: shenglei.zhang@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Wed, 14 Aug 2019 22:41:41 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 22:41:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,388,1559545200"; d="scan'208";a="181780037" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga006.jf.intel.com with ESMTP; 14 Aug 2019 22:41:40 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Jaben Carsey , Ray Ni , Zhichao Gao Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables Date: Thu, 15 Aug 2019 13:41:38 +0800 Message-Id: <20190815054138.16604-1-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 At latest edk2 version, there is build failure when building ShellPkg with VS2012x86, which results from uninitialized local variables. Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Shenglei Zhang --- .../Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8 ++++++++ .../Library/UefiShellAcpiViewCommandLib/AcpiView.c | 10 ++++++++++ 2 files changed, 18 insertions(+) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 2d6ff80e299e..94bafa22ef4c 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -121,6 +121,10 @@ VerifyChecksum ( UINT8 Checksum; UINTN OriginalAttribute; + // + // set local variables to suppress incorrect compiler/analyzer warnings + // + OriginalAttribute = 0; ByteCount = 0; Checksum = 0; @@ -472,6 +476,10 @@ ParseAcpi ( BOOLEAN HighLight; UINTN OriginalAttribute; + // + // set local variables to suppress incorrect compiler/analyzer warnings + // + OriginalAttribute = 0; Offset = 0; // Increment the Indent diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c index 9feb2df2078f..de0851dd5fba 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c @@ -211,6 +211,10 @@ ProcessTableReportOptions ( BOOLEAN Log; BOOLEAN HighLight; + // + // set local variables to suppress incorrect compiler/analyzer warnings + // + OriginalAttribute = 0; SignaturePtr = (UINT8*)(UINTN)&Signature; Log = FALSE; HighLight = GetColourHighlighting (); @@ -347,6 +351,12 @@ AcpiView ( PARSE_ACPI_TABLE_PROC RsdpParserProc; BOOLEAN Trace; + // + // set local variables to suppress incorrect compiler/analyzer warnings + // + EfiConfigurationTable = NULL; + OriginalAttribute = 0; + // Search the table for an entry that matches the ACPI Table Guid FoundAcpiTable = FALSE; for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) { -- 2.18.0.windows.1