From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ray Ni <ray.ni@intel.com>, Andrew Fish <afish@apple.com>
Subject: [Patch V4 07/10] EmulatorPkg/Unix/Host: Fix BerkeleyPacketFilter.c issues
Date: Thu, 15 Aug 2019 19:14:34 -0700 [thread overview]
Message-ID: <20190816021437.7516-8-michael.d.kinney@intel.com> (raw)
In-Reply-To: <20190816021437.7516-1-michael.d.kinney@intel.com>
* Fix uninitialized Private->ReadBuffer.
* Remove old debug code that generates an exception.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Andrew Fish <afish@apple.com>
---
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
index 8d0eb0d197..3013bbc86b 100644
--- a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
+++ b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
@@ -216,6 +216,7 @@ EmuSnpStart (
}
Status = EFI_SUCCESS;
+ Private->ReadBuffer = NULL;
if (Private->BpfFd == 0) {
Status = OpenBpfFileDescriptor (Private, &Private->BpfFd);
if (EFI_ERROR (Status)) {
@@ -766,10 +767,6 @@ EmuSnpGetStatus (
Private = EMU_SNP_PRIVATE_DATA_FROM_THIS (This);
- if (TxBuf != NULL) {
- *((UINT8 **)TxBuf) = (UINT8 *)1;
- }
-
if ( InterruptStatus != NULL ) {
*InterruptStatus = EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT;
}
--
2.21.0.windows.1
next prev parent reply other threads:[~2019-08-16 2:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 2:14 [Patch V4 00/10] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config Michael D Kinney
2019-08-16 2:14 ` [Patch V4 01/10] EmulatorPkg: Fix VS20xx IA32 boot failure Michael D Kinney
2019-08-16 2:14 ` [Patch V4 02/10] EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD Michael D Kinney
2019-08-16 2:14 ` [Patch V4 03/10] EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES Michael D Kinney
2019-08-16 2:14 ` [Patch V4 04/10] EmulatorPkg: Add support for NOOPT target Michael D Kinney
2019-08-16 2:14 ` [Patch V4 05/10] EmulatorPkg/Unix/Host: Disable inline/optimizations Michael D Kinney
2019-08-16 2:14 ` [Patch V4 06/10] EmulatorPkg: Fix XCODE5 lldb issues Michael D Kinney
2019-08-16 7:40 ` Jordan Justen
2019-08-16 15:09 ` Michael D Kinney
2019-08-16 17:30 ` [edk2-devel] " Andrew Fish
2019-08-16 18:21 ` Jordan Justen
2019-08-16 21:14 ` Michael D Kinney
2019-08-16 2:14 ` Michael D Kinney [this message]
2019-08-16 7:47 ` [Patch V4 07/10] EmulatorPkg/Unix/Host: Fix BerkeleyPacketFilter.c issues Jordan Justen
2019-08-16 2:14 ` [Patch V4 08/10] EmulatorPkg: Disable TftpDynamicCommand and LogoDxe for XCODE5 Michael D Kinney
2019-08-16 2:14 ` [Patch V4 09/10] EmulatorPkg/Sec: Change local variable scope " Michael D Kinney
2019-08-16 18:29 ` Jordan Justen
2019-08-16 2:14 ` [Patch V4 10/10] BaseTools/tools_def.template: Add -gdwarf to XCODE5 X64 Michael D Kinney
2019-08-16 4:50 ` [edk2-devel] " Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816021437.7516-8-michael.d.kinney@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox