From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: devel@edk2.groups.io
Cc: Jaben Carsey <jaben.carsey@intel.com>, Ray Ni <ray.ni@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>
Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
Date: Fri, 16 Aug 2019 14:10:34 +0800 [thread overview]
Message-ID: <20190816061034.23528-1-shenglei.zhang@intel.com> (raw)
Replace the operation to shift logical left with the function
LShiftU64, which has the same functionality.
The original code causes ShellPkg build failure with build
target"-b NOOPT".
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
v2: There is no return target from LShiftU64 in v1 patch.
So update code to "Val = LShiftU64(Val,32)".
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
index 94bafa22ef4c..a569c3c55406 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
@@ -294,7 +294,7 @@ DumpUint64 (
Val = *(UINT32*)(Ptr + sizeof (UINT32));
- Val <<= 32;
+ Val = LShiftU64(Val,32);
Val |= (UINT64)*(UINT32*)Ptr;
Print (Format, Val);
--
2.18.0.windows.1
next reply other threads:[~2019-08-16 6:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 6:10 Zhang, Shenglei [this message]
2019-08-16 6:19 ` [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Gao, Zhichao
2019-08-16 7:51 ` Zhang, Shenglei
2019-08-19 0:48 ` [edk2-devel] " Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816061034.23528-1-shenglei.zhang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox