From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: shenglei.zhang@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Thu, 15 Aug 2019 23:10:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2019 23:10:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; d="scan'208";a="182092762" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga006.jf.intel.com with ESMTP; 15 Aug 2019 23:10:35 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Jaben Carsey , Ray Ni , Zhichao Gao Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Date: Fri, 16 Aug 2019 14:10:34 +0800 Message-Id: <20190816061034.23528-1-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 Replace the operation to shift logical left with the function LShiftU64, which has the same functionality. The original code causes ShellPkg build failure with build target"-b NOOPT". Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Shenglei Zhang --- v2: There is no return target from LShiftU64 in v1 patch. So update code to "Val = LShiftU64(Val,32)". ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 94bafa22ef4c..a569c3c55406 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -294,7 +294,7 @@ DumpUint64 ( Val = *(UINT32*)(Ptr + sizeof (UINT32)); - Val <<= 32; + Val = LShiftU64(Val,32); Val |= (UINT64)*(UINT32*)Ptr; Print (Format, Val); -- 2.18.0.windows.1