From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=UPslcrBu; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.67, mailfrom: pete@akeo.ie) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Fri, 16 Aug 2019 03:00:24 -0700 Received: by mail-wr1-f67.google.com with SMTP id b16so980411wrq.9 for ; Fri, 16 Aug 2019 03:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WA/6PE9C3a9osw2Wy/N4HZdqGmAxGyNWfjAB+Kmi32A=; b=UPslcrBuZpC4sZIMJJOMMfjWg0CHAp18P1W+5yTwKbjnQbKSILr0iI54kDNV6XyeCN Pc+qLAhDhNBXzkqAlk/hZgrsAh0vlDlCcnt6W8zX4bu581eO7Jn67lxapgUjst/u2ZJi X10Bfw50oVIlorEz0d6isi7nrMpKV0DAhmNA1lCPae2DnB2N0l93HlHHPG1MIOhV/cbI dyzxlFnc8fVnFaYcpEgFpI71hOqqpe8TGFFrzvTds0q/VD37KTBUaVAzX4K4nE797jP1 eDljNjeyJ69gRUdOU0eGePMRgfGMFhxNUHELgKlx84qoiG832I036q7Lv9lpcW5QYvse oJOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WA/6PE9C3a9osw2Wy/N4HZdqGmAxGyNWfjAB+Kmi32A=; b=iE8KQeQfdjq17S414Ahp0CKdUspLLMEqAnjUdIZyasYcFu+1+GctHbjlqDamGGzuWl FpjObbU5cND07eD6SQ6aeXILD84s39WGH0Rl0HlaJL72yz3rj/8A9wmMUIqbF0qww/f9 bSvx7FdQHCY5On8rJ6fJvolf6Ish6zMxBKSIkRvbadk4DZyAlM+Z1c+i9up3GMA0+fTy PnZ4IiEy642bUA9C+1y7rOQOmHT3Q6ZMMQKI3gvzQijScfu/7E/CvxTBqP7/e4FkJuuC bGHgWJGuIvxk46ZDmXC1aqAO57rfwheLmqLHVbu3MZtzFIYNWe3ul0aZu3sNScYXE8Kw wsGA== X-Gm-Message-State: APjAAAVxzEPU7VykfQT4KO6z0a36aAs6z7VIgpkNZ3nez07vvbmGg4qH Ebom2rvMiFdewhFJE9I1wodEEuBZMEk= X-Google-Smtp-Source: APXvYqx6Za5ioSrsIUhkbksCw0nv20hrAvL+7jRvITgjq+Fd4VqpepK5m1Y/adHK5UXEmeWnNOJvxA== X-Received: by 2002:adf:ff84:: with SMTP id j4mr9373853wrr.71.1565949622775; Fri, 16 Aug 2019 03:00:22 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([84.203.61.230]) by smtp.gmail.com with ESMTPSA id j16sm4750851wrp.62.2019.08.16.03.00.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Aug 2019 03:00:22 -0700 (PDT) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org Subject: [edk2-platforms: PATCH v2 1/2] Platforms/RPi3: Improve debug output in FdtDxe Date: Fri, 16 Aug 2019 11:00:08 +0100 Message-Id: <20190816100009.3360-2-pete@akeo.ie> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20190816100009.3360-1-pete@akeo.ie> References: <20190816100009.3360-1-pete@akeo.ie> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Harmonize messages, avoid acronyms and provide human readable status codes. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 24 ++++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c b/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c index c84e5b2767e2..da99ef9535c8 100644 --- a/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c +++ b/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c @@ -383,12 +383,12 @@ FdtDxeInitialize ( * Have FDT passed via config.txt. */ FdtSize = fdt_totalsize (FdtImage); - DEBUG ((DEBUG_INFO, "DTB passed via config.txt of 0x%lx bytes\n", FdtSize)); + DEBUG ((DEBUG_INFO, "Device Tree passed via config.txt (0x%lx bytes)\n", FdtSize)); Status = EFI_SUCCESS; } else { Internal = TRUE; - DEBUG ((DEBUG_INFO, "No/bad FDT at %p (%a), trying internal DTB...\n", - FdtImage, fdt_strerror (Retval))); + DEBUG ((DEBUG_INFO, "No/Bad Device Tree found at address 0x%p (%a), " + "trying internal one...\n", FdtImage, fdt_strerror (Retval))); Status = GetSectionFromAnyFv (&gRaspberryPiFdtFileGuid, EFI_SECTION_RAW, 0, &FdtImage, &FdtSize); if (Status == EFI_SUCCESS) { @@ -399,7 +399,7 @@ FdtDxeInitialize ( } if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "Failed to locate device tree: %r\n", Status)); + DEBUG ((DEBUG_ERROR, "Failed to locate Device Tree: %r\n", Status)); return Status; } @@ -410,7 +410,7 @@ FdtDxeInitialize ( Status = gBS->AllocatePages (AllocateAnyPages, EfiBootServicesData, EFI_SIZE_TO_PAGES (FdtSize), (EFI_PHYSICAL_ADDRESS*)&mFdtImage); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "Failed to allocate new device tree: %r\n", Status)); + DEBUG ((DEBUG_ERROR, "Failed to allocate Device Tree: %r\n", Status)); return Status; } @@ -419,27 +419,27 @@ FdtDxeInitialize ( Status = SanitizePSCI (); if (EFI_ERROR (Status)) { - Print (L"Failed to sanitize PSCI (error %d)\n", Status); + Print (L"Failed to sanitize PSCI: %r\n", Status); } Status = CleanMemoryNodes (); if (EFI_ERROR (Status)) { - Print (L"Failed to clean memory nodes (error %d)\n", Status); + Print (L"Failed to clean memory nodes: %r\n", Status); } Status = CleanSimpleFramebuffer (); if (EFI_ERROR (Status)) { - Print (L"Failed to clean frame buffer (error %d)\n", Status); + Print (L"Failed to clean frame buffer: %r\n", Status); } Status = FixEthernetAliases (); if (EFI_ERROR (Status)) { - Print (L"Failed to fix ethernet aliases (error %d)\n", Status); + Print (L"Failed to fix ethernet aliases: %r\n", Status); } Status = UpdateMacAddress (); if (EFI_ERROR (Status)) { - Print (L"Failed to update MAC address (error %d)\n", Status); + Print (L"Failed to update MAC address: %r\n", Status); } if (Internal) { @@ -448,11 +448,11 @@ FdtDxeInitialize ( */ Status = UpdateBootArgs (); if (EFI_ERROR (Status)) { - Print (L"Failed to update boot arguments (error %d)\n", Status); + Print (L"Failed to update boot arguments: %r\n", Status); } } - DEBUG ((DEBUG_INFO, "Installed FDT is at %p\n", mFdtImage)); + DEBUG ((DEBUG_INFO, "Installed Device Tree at address 0x%p\n", mFdtImage)); Status = gBS->InstallConfigurationTable (&gFdtTableGuid, mFdtImage); ASSERT_EFI_ERROR (Status); -- 2.21.0.windows.1