From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Subject: Re: [edk2-platforms: PATCH v2 0/2] Platforms/RPi3: Device Tree driver improvements
Date: Fri, 16 Aug 2019 17:47:22 +0100 [thread overview]
Message-ID: <20190816164722.GS29255@bivouac.eciton.net> (raw)
In-Reply-To: <20190816100009.3360-1-pete@akeo.ie>
On Fri, Aug 16, 2019 at 11:00:07AM +0100, Pete Batard wrote:
> Changes from v1:
> - Break down DEBUB output embellishments from the other code changes.
> - Use GUIDs that are explicitly named after each platform/model rather than
> generic ones.
> - Drop the use of a GUID table/index and use a single GUID variable instead.
> - Add additional fallback in case the required internal Device Tree cannot
> be located (e.g. missing from the FDF).
> - Ensures that all of the Device Tree selection and fallback can be set up
> in the .dec (FdtDxe reusability).
> - Add premilinary Raspberry Pi 4 support (FdtDxe reusability).
>
> Note: Since the changes required to support the Raspberry Pi 4 are a direct
> byproduct of the changes required for multiple Device Tree support, I did
> not feel the need to break them down into a separate patch.
For the series,
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 591f0c39589c..7da906bfcd03.
Thanks!
> Pete Batard (2):
> Platforms/RPi3: Improve debug output in FdtDxe
> Platforms/RPi3: Add multiple embedded Device Tree selection
>
> Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 78 +++++++++++++++-----
> Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.inf | 5 +-
> Platform/RaspberryPi/RPi3/RPi3.dec | 8 +-
> Platform/RaspberryPi/RPi3/RPi3.fdf | 6 +-
> 4 files changed, 77 insertions(+), 20 deletions(-)
>
> --
> 2.21.0.windows.1
>
prev parent reply other threads:[~2019-08-16 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 10:00 [edk2-platforms: PATCH v2 0/2] Platforms/RPi3: Device Tree driver improvements Pete Batard
2019-08-16 10:00 ` [edk2-platforms: PATCH v2 1/2] Platforms/RPi3: Improve debug output in FdtDxe Pete Batard
2019-08-16 10:00 ` [edk2-platforms: PATCH v2 2/2] Platforms/RPi3: Add multiple embedded Device Tree selection Pete Batard
2019-08-16 16:47 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816164722.GS29255@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox