From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=s0sNVU2h; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Fri, 16 Aug 2019 09:47:26 -0700 Received: by mail-wr1-f67.google.com with SMTP id j16so2143769wrr.8 for ; Fri, 16 Aug 2019 09:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZO/OyUKsfd8OofWG6B9AYA7MOitptHLfZpWhSJHKxoU=; b=s0sNVU2h8Zdu2r/58nd8dJ7GbJvGVoe5WDOyGq/mgElKjbQfHYzGjXj9JWmE92WpbX 7OS3Gbg2U4yKKekCPWpMPmxbvafxMJ3QfXturnfdCqgAiRFUqxkN0sIwZkqxlb+GwjH1 boG7USpLQMTmzgsX11seSBx7Bm/1oV/qSDFR7QFvHI3feLTJ8wdx3JXBvwiipcfKy816 xyLPuAbHGJmWXcb/2VFdZ2QK/2R7E7pLjSdeGIkWfQdeg7mdRDs9Yj94PBGAe5NvZZIM 3QPTsN5WDap3o4Z5K0/jPzh2SBrSoHQgUyH+gfRkIh7J/TGVQa0db96okW/uMqVw6/qd GnPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZO/OyUKsfd8OofWG6B9AYA7MOitptHLfZpWhSJHKxoU=; b=sMqulE0EwVJqh3AyqekSmQY5hIZci2rUX7MaOCfZXi4ZKi0Of848/EOxvdY+ku6kE1 C47igFLuN+ABKC45plVi5PysF/poU+rLUcxma73YICbJj5ZLoJWnkP4WD3jVK3+ruEt4 gNlqkqG5IjfnO9nnhDAmnuZizmEfX4BsYe63vTEQWzyxXUvtszDj4SyfXNaPXqIl+/by kCaYlKeiec0FFMmJj2d6aavAOyZ5ZTtkK1bCtL+I80mYkP71HzLRgC8so+ZXJGBpYC0v BS+UM6+sS04HUjjs+21rNgU+ZbigCXK5+CHW+Lol11hkM0E1+x8iJeSFE+be+dCu5qPv 4mpA== X-Gm-Message-State: APjAAAVOjRyFps/iaqQ5rO3P5wl1XPHpNO8pm/b9WFQCrZLvHb50JfED DHea4+RaLbh3nD5NDhU8CoRq0Q== X-Google-Smtp-Source: APXvYqzlNYXgfz38uB68oIaOtB+kYKbL3tgWPeViQpAfN/fWoPReX75R3A72NVIFue7fqicIE/sKwQ== X-Received: by 2002:adf:f304:: with SMTP id i4mr5532491wro.61.1565974045056; Fri, 16 Aug 2019 09:47:25 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n14sm16712910wra.75.2019.08.16.09.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 09:47:24 -0700 (PDT) Date: Fri, 16 Aug 2019 17:47:22 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-platforms: PATCH v2 0/2] Platforms/RPi3: Device Tree driver improvements Message-ID: <20190816164722.GS29255@bivouac.eciton.net> References: <20190816100009.3360-1-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20190816100009.3360-1-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 16, 2019 at 11:00:07AM +0100, Pete Batard wrote: > Changes from v1: > - Break down DEBUB output embellishments from the other code changes. > - Use GUIDs that are explicitly named after each platform/model rather than > generic ones. > - Drop the use of a GUID table/index and use a single GUID variable instead. > - Add additional fallback in case the required internal Device Tree cannot > be located (e.g. missing from the FDF). > - Ensures that all of the Device Tree selection and fallback can be set up > in the .dec (FdtDxe reusability). > - Add premilinary Raspberry Pi 4 support (FdtDxe reusability). > > Note: Since the changes required to support the Raspberry Pi 4 are a direct > byproduct of the changes required for multiple Device Tree support, I did > not feel the need to break them down into a separate patch. For the series, Reviewed-by: Leif Lindholm Pushed as 591f0c39589c..7da906bfcd03. Thanks! > Pete Batard (2): > Platforms/RPi3: Improve debug output in FdtDxe > Platforms/RPi3: Add multiple embedded Device Tree selection > > Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 78 +++++++++++++++----- > Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.inf | 5 +- > Platform/RaspberryPi/RPi3/RPi3.dec | 8 +- > Platform/RaspberryPi/RPi3/RPi3.fdf | 6 +- > 4 files changed, 77 insertions(+), 20 deletions(-) > > -- > 2.21.0.windows.1 >