public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, mw@semihalf.com
Cc: ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com,
	kostap@marvell.com
Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2 06/10] Marvell/Library: MppLib: Allow to configure more Xenon PHYs
Date: Fri, 16 Aug 2019 18:36:15 +0100	[thread overview]
Message-ID: <20190816173615.GY29255@bivouac.eciton.net> (raw)
In-Reply-To: <1565837654-13258-7-git-send-email-mw@semihalf.com>

On Thu, Aug 15, 2019 at 04:54:10AM +0200, Marcin Wojtas wrote:
> Hitherto MppLib code assumed that there could be only two
> Xenon SdMmc controllers' PHYs. Remove this limitation, so that to
> support CN913x SoCs, which may have up to 4 of such interfaces.

Should this be merged with the preceding patch?

/
    Leif

> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  Silicon/Marvell/Library/MppLib/MppLib.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Silicon/Marvell/Library/MppLib/MppLib.c b/Silicon/Marvell/Library/MppLib/MppLib.c
> index 40d9077..f20668d 100644
> --- a/Silicon/Marvell/Library/MppLib/MppLib.c
> +++ b/Silicon/Marvell/Library/MppLib/MppLib.c
> @@ -139,11 +139,9 @@ SetSdMmcPhyMpp (
>    case 0:
>      Offset = SD_MMC_PHY_AP_MPP_OFFSET;
>      break;
> -  case 1:
> +  default:
>      Offset = SD_MMC_PHY_CP0_MPP_OFFSET;
>      break;
> -  default:
> -    return;
>    }
>  
>    /*
> -- 
> 2.7.4
> 
> 
> 
> 

  reply	other threads:[~2019-08-16 17:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15  2:54 [edk2-platforms: PATCH v2 00/10] Marvell Octeon CN913X SoC family support Marcin Wojtas
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 01/10] Marvell/Armada7k8k: Fix 32-bit compilation Marcin Wojtas
2019-08-16 17:03   ` Leif Lindholm
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 02/10] Marvell/Cn9130Db: Add ACPI tables Marcin Wojtas
2019-08-16 17:06   ` Leif Lindholm
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 03/10] Marvell/Cn9130Db: Add DeviceTree Marcin Wojtas
2019-08-16 17:10   ` Leif Lindholm
2019-08-16 21:03     ` Marcin Wojtas
2019-08-19 17:14       ` Leif Lindholm
2019-08-21  9:11         ` Laszlo Ersek
2019-08-21 11:04           ` Marcin Wojtas
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 04/10] Marvell/Cn9130Db: Introduce board support Marcin Wojtas
2019-08-16 17:31   ` Leif Lindholm
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 05/10] Marvell/Library: ArmadaSoCDescLib: Extend Xenon information Marcin Wojtas
2019-08-16 17:34   ` Leif Lindholm
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 06/10] Marvell/Library: MppLib: Allow to configure more Xenon PHYs Marcin Wojtas
2019-08-16 17:36   ` Leif Lindholm [this message]
2019-08-16 21:04     ` [edk2-devel] " Marcin Wojtas
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 07/10] Marvell/Library: IcuLib: Fix debug information Marcin Wojtas
2019-08-16 17:37   ` Leif Lindholm
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 08/10] Marvell/Cn9131Db: Introduce board support Marcin Wojtas
2019-08-16 17:39   ` Leif Lindholm
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 09/10] Marvell/Cn9132Db: " Marcin Wojtas
2019-08-16 17:40   ` Leif Lindholm
2019-08-15  2:54 ` [edk2-platforms: PATCH v2 10/10] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name Marcin Wojtas
2019-08-16 17:41   ` [edk2-devel] " Leif Lindholm
2019-08-16 20:57     ` Marcin Wojtas
2019-08-19 17:00       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190816173615.GY29255@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox