From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=IRObVwTQ; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Fri, 16 Aug 2019 10:36:19 -0700 Received: by mail-wm1-f65.google.com with SMTP id p77so3639694wme.0 for ; Fri, 16 Aug 2019 10:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PM12dGWGIUyLnZKAX9GZLJfrzN5Bww1TrLOPxrA9lLc=; b=IRObVwTQUfTAAJ/7CA7e/Ym/dRYRfEu/7aK5Caf1STUtlXeGNZKSomqSpPLbP3frej ehQdegdRbaGgT85uaCUSOE5fRsOm4AGGi9Q+zC1aoj/Z2WnZwb7zsC0vl4C2Y7eeG/vd RUrOO7oZkorylXV5i1ubtzdUDxNtTDo18xyu301YS19b1U5L13zoRiOdoEHs2vZQYWjP Iprkm7G5DbBv4h1868tZHy9auqlXP2MRf4ooMSDZpmWSx3IF60A1qPDZf8Il2BIr3wPb WDgoWKoTSFTl6P8CHfpipqGWBRXxc4vovnTqSXWwDLlEO1lYqjYdm3l93dhrdySbXsgj atJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PM12dGWGIUyLnZKAX9GZLJfrzN5Bww1TrLOPxrA9lLc=; b=tLcl6H6XDor44PsEIDhC1mlTj6OdgFBWaPxO4Cr+rDIzwCwmldq8ekQGz+a7DXbLoS PHvA54H76CdmiDhij1CDD5pPkoAoj8K09OmXvrHpmyMYIdDU02xQFTIsOCQRYQb8ojyM Dr7DXjqjr7PbyPUTv1O0RUOQQ4X4O0NX+xJ67DObyF2u5cL5FVagMn8BJ5ygi3JwgK9k k9tXzQ2uKsJQQDiD7BNaM5+VOYiHt+XK/CmZavj20VxSv1kAyR+R8QtuoEpExMy9w6w5 Lm2vclPABl8I9vjB2GTzsNBMqIcS0i9E/+CKmrFdt/r+OmbhEMxR2VmPCYORTLrbltP/ if7g== X-Gm-Message-State: APjAAAUsETI8SF2fPoJc7wH9RGLvy4ClRUB6D88htU8xmPYuMnu8STye GelQXHs6lizp3TFmSaFfJZ/6JEQ60ew= X-Google-Smtp-Source: APXvYqz7J96ysY8RW3IWTG8J6ZPhVnxfZgo70qxiajBrPnOvz0/LpgS1s+NCfE7nLbF3aHdqPe4+EQ== X-Received: by 2002:a1c:760b:: with SMTP id r11mr8728063wmc.41.1565976977678; Fri, 16 Aug 2019 10:36:17 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f18sm7740571wrx.85.2019.08.16.10.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 10:36:17 -0700 (PDT) Date: Fri, 16 Aug 2019 18:36:15 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, mw@semihalf.com Cc: ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2 06/10] Marvell/Library: MppLib: Allow to configure more Xenon PHYs Message-ID: <20190816173615.GY29255@bivouac.eciton.net> References: <1565837654-13258-1-git-send-email-mw@semihalf.com> <1565837654-13258-7-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1565837654-13258-7-git-send-email-mw@semihalf.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 15, 2019 at 04:54:10AM +0200, Marcin Wojtas wrote: > Hitherto MppLib code assumed that there could be only two > Xenon SdMmc controllers' PHYs. Remove this limitation, so that to > support CN913x SoCs, which may have up to 4 of such interfaces. Should this be merged with the preceding patch? / Leif > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Library/MppLib/MppLib.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Silicon/Marvell/Library/MppLib/MppLib.c b/Silicon/Marvell/Library/MppLib/MppLib.c > index 40d9077..f20668d 100644 > --- a/Silicon/Marvell/Library/MppLib/MppLib.c > +++ b/Silicon/Marvell/Library/MppLib/MppLib.c > @@ -139,11 +139,9 @@ SetSdMmcPhyMpp ( > case 0: > Offset = SD_MMC_PHY_AP_MPP_OFFSET; > break; > - case 1: > + default: > Offset = SD_MMC_PHY_CP0_MPP_OFFSET; > break; > - default: > - return; > } > > /* > -- > 2.7.4 > > > >