From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, mw@semihalf.com
Cc: ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com,
kostap@marvell.com
Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2 10/10] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name
Date: Fri, 16 Aug 2019 18:41:53 +0100 [thread overview]
Message-ID: <20190816174153.GC29255@bivouac.eciton.net> (raw)
In-Reply-To: <1565837654-13258-11-git-send-email-mw@semihalf.com>
On Thu, Aug 15, 2019 at 04:54:14AM +0200, Marcin Wojtas wrote:
> SmbiosPlatformDxe is used both by Armada 7k8k and CN913x platforms.
> Replace board name placeholder in order to avoid confusion.
Stupid/lazy question - do we already specify the actual platform name
elsewhere?
/
Leif
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> index 08f4fa7..cdacd90 100644
> --- a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> +++ b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> @@ -102,7 +102,7 @@ STATIC SMBIOS_TABLE_TYPE1 mArmadaDefaultType1 = {
>
> STATIC CHAR8 CONST *mArmadaDefaultType1Strings[] = {
> "Marvell \0",/* Manufacturer */
> - "Armada 7k/8k Family Board \0",/* Product Name placeholder*/
> + "Marvell Development Board \0",/* Product Name placeholder*/
> "Revision unknown \0",/* Version placeholder */
> " \0",/* 32 character buffer */
> NULL
> @@ -130,7 +130,7 @@ STATIC SMBIOS_TABLE_TYPE2 mArmadaDefaultType2 = {
>
> STATIC CHAR8 CONST *mArmadaDefaultType2Strings[] = {
> "Marvell \0",/* Manufacturer */
> - "Armada 7k/8k Family Board \0",/* Product Name placeholder*/
> + "Marvell Development Board \0",/* Product Name placeholder*/
> "Revision unknown \0",/* Version placeholder */
> "Serial Not Set \0",/* Serial */
> "Base of Chassis \0",/* Board location */
> --
> 2.7.4
>
>
>
>
next prev parent reply other threads:[~2019-08-16 17:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 2:54 [edk2-platforms: PATCH v2 00/10] Marvell Octeon CN913X SoC family support Marcin Wojtas
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 01/10] Marvell/Armada7k8k: Fix 32-bit compilation Marcin Wojtas
2019-08-16 17:03 ` Leif Lindholm
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 02/10] Marvell/Cn9130Db: Add ACPI tables Marcin Wojtas
2019-08-16 17:06 ` Leif Lindholm
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 03/10] Marvell/Cn9130Db: Add DeviceTree Marcin Wojtas
2019-08-16 17:10 ` Leif Lindholm
2019-08-16 21:03 ` Marcin Wojtas
2019-08-19 17:14 ` Leif Lindholm
2019-08-21 9:11 ` Laszlo Ersek
2019-08-21 11:04 ` Marcin Wojtas
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 04/10] Marvell/Cn9130Db: Introduce board support Marcin Wojtas
2019-08-16 17:31 ` Leif Lindholm
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 05/10] Marvell/Library: ArmadaSoCDescLib: Extend Xenon information Marcin Wojtas
2019-08-16 17:34 ` Leif Lindholm
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 06/10] Marvell/Library: MppLib: Allow to configure more Xenon PHYs Marcin Wojtas
2019-08-16 17:36 ` [edk2-devel] " Leif Lindholm
2019-08-16 21:04 ` Marcin Wojtas
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 07/10] Marvell/Library: IcuLib: Fix debug information Marcin Wojtas
2019-08-16 17:37 ` Leif Lindholm
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 08/10] Marvell/Cn9131Db: Introduce board support Marcin Wojtas
2019-08-16 17:39 ` Leif Lindholm
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 09/10] Marvell/Cn9132Db: " Marcin Wojtas
2019-08-16 17:40 ` Leif Lindholm
2019-08-15 2:54 ` [edk2-platforms: PATCH v2 10/10] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name Marcin Wojtas
2019-08-16 17:41 ` Leif Lindholm [this message]
2019-08-16 20:57 ` [edk2-devel] " Marcin Wojtas
2019-08-19 17:00 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816174153.GC29255@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox