From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=qwe3ZG6Q; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Fri, 16 Aug 2019 10:41:57 -0700 Received: by mail-wm1-f67.google.com with SMTP id 10so4665537wmp.3 for ; Fri, 16 Aug 2019 10:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7Km8iPhDNY1HcKmaWB7/fy8Uib32mwsNc4lF/htU9Wo=; b=qwe3ZG6QT23in0wUAh8I0Z6/lq+7xKVvLGlrElpxh4P2K/tEC4jSd2XeVlEvpJATRy Ernb0V96nHrjkt+rzUw8O5LTENDIKDucxh7iA1p9B4X8j6Qgam0AS4lhjMrte5yJdexh nCo1DohQlgcBmcV2BiIhtsBnJIiu1elQhN8vzBL4vsraD+xugFbLiPBp7IkRAhr7+Ym0 DG8b/n79hYDiNPiVA7Uc6E9Lg90ys1FscE2ijm0urI0/D896Yb2OiDXthagEv13uKN2b sKXy4ziG5LwSxc2yYuJf4pe8qvISD/KLQJZugUZaubrC+EZL3J+CHTYXJduATdDe+Mzt /7KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7Km8iPhDNY1HcKmaWB7/fy8Uib32mwsNc4lF/htU9Wo=; b=YAYUdagWA9svCP2iET2PWhtkc+XdGixXrAVOLhgVtPSsBDkPzAXOB4EThSS90yiJ0H KovoQ20OYHqg8ga5SlxwHgf0FU/O5SLohniCfd90SO/1wUZnKTbufDSRUbIK3et7tfTS Tz/L3PwYQryDlEbzBv1ez6ceEyvWiKdkLdNMRX/bMrWXJiaeBfwvxwR4lbWCc1j//UIg b6+ndgsLfPglTRYjTFttA6vUjIqXtm1ATQLd5JPhr+K0ALUPJaNz/Rvs6DjcDhHJfNJ1 n+QupUoGCNuzj+Pkwj11FBcW+hz5r2dSG4ysbzM5SlMFJxJ5iapqnf4iFqrPHgm3/6AI 0uKQ== X-Gm-Message-State: APjAAAXbtkX2TrW7CL12sQc7IODhnecBoPsEHkR2v9LPB+BMAnAAk0tp e/dk6pZ3b0yaZrp65zxbX4yitOkYrdo= X-Google-Smtp-Source: APXvYqy7ROdiR6TCesZgQDA22v1hOqhIlHFxOCo+hGn9YopQNyuMU7sqv7qTfvImSpO5nEv2uU4t4w== X-Received: by 2002:a1c:3d03:: with SMTP id k3mr8817954wma.138.1565977315853; Fri, 16 Aug 2019 10:41:55 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t198sm8642997wmt.39.2019.08.16.10.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 10:41:55 -0700 (PDT) Date: Fri, 16 Aug 2019 18:41:53 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, mw@semihalf.com Cc: ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2 10/10] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name Message-ID: <20190816174153.GC29255@bivouac.eciton.net> References: <1565837654-13258-1-git-send-email-mw@semihalf.com> <1565837654-13258-11-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1565837654-13258-11-git-send-email-mw@semihalf.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 15, 2019 at 04:54:14AM +0200, Marcin Wojtas wrote: > SmbiosPlatformDxe is used both by Armada 7k8k and CN913x platforms. > Replace board name placeholder in order to avoid confusion. Stupid/lazy question - do we already specify the actual platform name elsewhere? / Leif > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index 08f4fa7..cdacd90 100644 > --- a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -102,7 +102,7 @@ STATIC SMBIOS_TABLE_TYPE1 mArmadaDefaultType1 = { > > STATIC CHAR8 CONST *mArmadaDefaultType1Strings[] = { > "Marvell \0",/* Manufacturer */ > - "Armada 7k/8k Family Board \0",/* Product Name placeholder*/ > + "Marvell Development Board \0",/* Product Name placeholder*/ > "Revision unknown \0",/* Version placeholder */ > " \0",/* 32 character buffer */ > NULL > @@ -130,7 +130,7 @@ STATIC SMBIOS_TABLE_TYPE2 mArmadaDefaultType2 = { > > STATIC CHAR8 CONST *mArmadaDefaultType2Strings[] = { > "Marvell \0",/* Manufacturer */ > - "Armada 7k/8k Family Board \0",/* Product Name placeholder*/ > + "Marvell Development Board \0",/* Product Name placeholder*/ > "Revision unknown \0",/* Version placeholder */ > "Serial Not Set \0",/* Serial */ > "Base of Chassis \0",/* Board location */ > -- > 2.7.4 > > > >