public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Andy Hayes <andy.hayes@displaylink.com>
Cc: devel@edk2.groups.io, Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-platforms: PATCH 1/1] DisplayLinkPkg: DisplayLinkGOP: Added GOP driver for DisplayLink based USB docking stations.
Date: Mon, 19 Aug 2019 12:56:29 +0100	[thread overview]
Message-ID: <20190819115629.GD29255@bivouac.eciton.net> (raw)
In-Reply-To: <20190819111820.3479-2-andy.hayes@displaylink.com>

Hi Andy,

Something is fishy here - these (non-identical) patches *delete* code,
they don't add it.

On Mon, Aug 19, 2019 at 12:18:20PM +0100, Andy Hayes wrote:
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Andy Hayes <andy.hayes@displaylink.com>
> ---
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc                    |   61 --
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/DisplayLinkGopDxe.inf  |   65 --
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Edid.h                 |  129 ---
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDescriptors.h       |  109 --
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDisplayLink.h       |  278 -----
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/CapabilityDescriptor.c |  137 ---
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/ComponentName.c        |  235 -----
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Edid.c                 |  598 -----------
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Gop.c                  |  578 -----------
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDescriptors.c       |  145 ---
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDisplayLink.c       | 1082 --------------------
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c          |  180 ----
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/VideoModes.c           |  254 -----
>  Drivers/DisplayLink/DisplayLinkPkg/ReadMe.md                             |   77 --
>  Maintainers.txt                                                          |    5 -
>  15 files changed, 3933 deletions(-)

           reply	other threads:[~2019-08-19 11:56 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20190819111820.3479-2-andy.hayes@displaylink.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190819115629.GD29255@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox