From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=gboF5Srh; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Mon, 19 Aug 2019 04:56:33 -0700 Received: by mail-wr1-f67.google.com with SMTP id q12so8398381wrj.12 for ; Mon, 19 Aug 2019 04:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+MPMSuF7t/4hRC4+nGuNG2722vtIutLIp5L1TzDtEx8=; b=gboF5SrhR5xxc8ZJ3WkGMiU43BBIhq19DwtnlWs+6GbgMMO7iKoRtURqD+woBcK6GO vgfdyixftYkpcOXNVnyT4KXRHyfmxatpgAM5fnFw2ov7xo6HrhHvkALOyi6zKI0zhmH4 5fkQmiTmmhux7NCQVt+vtJcdaPqG73Mod3r1HqJjuk97Mqi1ONiJ4mWMrDLrP1P68ToF qXFERL8MPYPetoD0F8SYtJ6Ef4bErD96XXLq9xtFOWxm+dxQ6ACKEZ2mdctq6uQoa4r8 AIOKUZcoECss6QL076uZirSoSH9mw4Vyr46OEJwdxIxjvJIZ4TrTqS5SN+G0536mjGcy LwJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+MPMSuF7t/4hRC4+nGuNG2722vtIutLIp5L1TzDtEx8=; b=qg2+Bmql5IuLEpIdRONVKHSP43mL1TQp0v66ORFv7W2a41JeZdyNMWrKfDlDJ+G5VJ S6B/9RCjf6NrrJZ3wMcfS9PSCQMTHLuEMmgkNgW37D2RnsKZ11fVNg89gPcwbtuaKOxQ m1J0Xk5sCTu0pzhj36rb82mUiINjqxKRPSMnFqW2CGuaKsApJJfR7n3tR6cifg/4jDtz RtmCUJaht988Cjv63keR+dy/H3fQgIahGUVvzklYniK+T8Xv7p+lqCgcw3QcTm42Qkj9 HIFYb00zUi/dngRICwnKgC48A611JoJIXwXpAmRMoGKlzmj09eKGhR9VwoWMHrC01J1I 2dEg== X-Gm-Message-State: APjAAAVxKwmxn3k0x4Q+CL6OR//n5vJrvEWF/42LRqiMQBzz4IpPRch5 YI2lwvrjpZx6/Im5S0B/hwfYng== X-Google-Smtp-Source: APXvYqwupFUdEcnQr2ReOgsQotSSR4GcV34vpqz6agU2cHx5o0XEl0XTIzsU5ENJ/hmaRKcPLAKcWg== X-Received: by 2002:a05:6000:4d:: with SMTP id k13mr27178439wrx.196.1566215791476; Mon, 19 Aug 2019 04:56:31 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 91sm45325268wrp.3.2019.08.19.04.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 04:56:30 -0700 (PDT) Date: Mon, 19 Aug 2019 12:56:29 +0100 From: "Leif Lindholm" To: Andy Hayes Cc: devel@edk2.groups.io, Michael D Kinney Subject: Re: [edk2-platforms: PATCH 1/1] DisplayLinkPkg: DisplayLinkGOP: Added GOP driver for DisplayLink based USB docking stations. Message-ID: <20190819115629.GD29255@bivouac.eciton.net> References: <20190819111820.3479-1-andy.hayes@displaylink.com> <20190819111820.3479-2-andy.hayes@displaylink.com> MIME-Version: 1.0 In-Reply-To: <20190819111820.3479-2-andy.hayes@displaylink.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Andy, Something is fishy here - these (non-identical) patches *delete* code, they don't add it. On Mon, Aug 19, 2019 at 12:18:20PM +0100, Andy Hayes wrote: > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Andy Hayes > --- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 61 -- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/DisplayLinkGopDxe.inf | 65 -- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Edid.h | 129 --- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDescriptors.h | 109 -- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDisplayLink.h | 278 ----- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/CapabilityDescriptor.c | 137 --- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/ComponentName.c | 235 ----- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Edid.c | 598 ----------- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Gop.c | 578 ----------- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDescriptors.c | 145 --- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDisplayLink.c | 1082 -------------------- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 180 ---- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/VideoModes.c | 254 ----- > Drivers/DisplayLink/DisplayLinkPkg/ReadMe.md | 77 -- > Maintainers.txt | 5 - > 15 files changed, 3933 deletions(-)