* [edk2-platform PATCH 0/2] Fix warning message issues
@ 2019-08-21 8:01 Zhang, Shenglei
2019-08-21 8:01 ` [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Zhang, Shenglei
2019-08-21 8:01 ` [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Zhang, Shenglei
0 siblings, 2 replies; 9+ messages in thread
From: Zhang, Shenglei @ 2019-08-21 8:01 UTC (permalink / raw)
To: devel; +Cc: Sai Chaganty, Michael Kubacki, Chasel Chiu, Nate DeSimone,
Liming Gao
There are some header files used but not included in INF
files. This causes warings are generated when building the
packages. So now add them into INF files.
https://bugzilla.tianocore.org/show_bug.cgi?id=2037
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Shenglei Zhang (2):
Platform/SmbiosBasicDxe: Add a missing header file in INF
Platform/MinPlatformPkg: Add missing header files in INF files
.../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 +
.../MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf | 1 +
.../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 1 +
.../Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf | 1 +
.../Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf | 2 ++
.../PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf | 2 ++
.../Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf | 1 +
.../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf | 1 +
8 files changed, 10 insertions(+)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
2019-08-21 8:01 [edk2-platform PATCH 0/2] Fix warning message issues Zhang, Shenglei
@ 2019-08-21 8:01 ` Zhang, Shenglei
2019-08-23 17:32 ` Kubacki, Michael A
2019-08-23 18:11 ` Chaganty, Rangasai V
2019-08-21 8:01 ` [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Zhang, Shenglei
1 sibling, 2 replies; 9+ messages in thread
From: Zhang, Shenglei @ 2019-08-21 8:01 UTC (permalink / raw)
To: devel; +Cc: Michael Kubacki, Sai Chaganty, Liming Gao
The header file is used but missing in INF,which causes
warning message when building them.
https://bugzilla.tianocore.org/show_bug.cgi?id=2037
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
index 69e930dd..bbac1d5c 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
+++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
@@ -23,6 +23,7 @@
[Sources]
SmbiosBasicEntryPoint.c
+ SmbiosBasic.h
Type0BiosVendorFunction.c
Type1SystemManufacturerFunction.c
Type2BaseBoardManufacturerFunction.c
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files
2019-08-21 8:01 [edk2-platform PATCH 0/2] Fix warning message issues Zhang, Shenglei
2019-08-21 8:01 ` [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Zhang, Shenglei
@ 2019-08-21 8:01 ` Zhang, Shenglei
2019-08-21 8:09 ` Chiu, Chasel
` (2 more replies)
1 sibling, 3 replies; 9+ messages in thread
From: Zhang, Shenglei @ 2019-08-21 8:01 UTC (permalink / raw)
To: devel; +Cc: Michael Kubacki, Chasel Chiu, Nate DeSimone, Liming Gao
The header files are used but missing in INF,which causes
warning message when building them.
https://bugzilla.tianocore.org/show_bug.cgi?id=2037
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf | 1 +
.../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 1 +
.../Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf | 1 +
.../Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf | 2 ++
.../PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf | 2 ++
.../Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf | 1 +
.../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf | 1 +
7 files changed, 9 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
index cca7de94..4c5202f9 100644
--- a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
+++ b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
@@ -50,6 +50,7 @@
[Sources]
Common/SpiFvbServiceCommon.c
Common/FvbInfo.c
+ Common/SpiFvbServiceCommon.h
Smm/SpiFvbServiceSmm.c
[Protocols]
diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
index 5d77e9e4..3f5a63f2 100644
--- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
+++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
@@ -41,6 +41,7 @@
SecGetPerformance.c
SecTempRamDone.c
PlatformInit.c
+ FsptCoreUpd.h
[Sources.IA32]
Ia32/SecEntry.nasm
diff --git a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
index 64814528..172280e8 100644
--- a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
+++ b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
@@ -23,6 +23,7 @@
SecureBootBypass.c
ExternalDeviceDmaProtection.c
MorSupport.c
+ HstiIbvPlatformDxe.h
[Packages]
MdePkg/MdePkg.dec
diff --git a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf
index fd80c611..ad8882fe 100644
--- a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf
+++ b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf
@@ -37,6 +37,8 @@
[Sources]
PeiHobVariableLibFce.c
InternalCommonLib.c
+ Variable.h
+ Fce.h
[Ppis]
gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
diff --git a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf
index 82d81c98..e1a76715 100644
--- a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf
+++ b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf
@@ -36,6 +36,8 @@
[Sources]
PeiHobVariableLibFceOptSize.c
InternalCommonLib.c
+ Variable.h
+ Fce.h
[Ppis]
gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
index 62fceffb..76e193dc 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
@@ -68,6 +68,7 @@
DxeCheckTcgMor.c
DxeCheckDmaProtection.c
TestPointHelp.c
+ TestPointInternal.h
[Guids]
gEfiMemoryAttributesTableGuid
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
index 6007fbc9..03d027ec 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
@@ -45,6 +45,7 @@
DxeCheckLoadedImage.c
DxeCheckGcd.c
TestPointHelp.c
+ TestPointInternal.h
[Pcd]
gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files
2019-08-21 8:01 ` [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Zhang, Shenglei
@ 2019-08-21 8:09 ` Chiu, Chasel
2019-08-23 17:33 ` Kubacki, Michael A
2019-08-23 21:55 ` Nate DeSimone
2 siblings, 0 replies; 9+ messages in thread
From: Chiu, Chasel @ 2019-08-21 8:09 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Cc: Kubacki, Michael A, Desimone, Nathaniel L, Gao, Liming
Some of files touched by this patch still having old copyright year, please help to extend.
With above update: Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 4:01 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing
> header files in INF files
>
> The header files are used but missing in INF,which causes warning message
> when building them.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2037
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .../MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf | 1 +
> .../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 1 +
> .../Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf | 1 +
> .../Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf | 2 ++
> .../PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf | 2 ++
> .../Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf | 1 +
> .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf | 1 +
> 7 files changed, 9 insertions(+)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> index cca7de94..4c5202f9 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm
> +++ .inf
> @@ -50,6 +50,7 @@
> [Sources]
> Common/SpiFvbServiceCommon.c
> Common/FvbInfo.c
> + Common/SpiFvbServiceCommon.h
> Smm/SpiFvbServiceSmm.c
>
> [Protocols]
> diff --git
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo
> rmSecLib/SecFspWrapperPlatformSecLib.inf
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo
> rmSecLib/SecFspWrapperPlatformSecLib.inf
> index 5d77e9e4..3f5a63f2 100644
> ---
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfo
> rmSecLib/SecFspWrapperPlatformSecLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat
> +++ formSecLib/SecFspWrapperPlatformSecLib.inf
> @@ -41,6 +41,7 @@
> SecGetPerformance.c
> SecTempRamDone.c
> PlatformInit.c
> + FsptCoreUpd.h
>
> [Sources.IA32]
> Ia32/SecEntry.nasm
> diff --git
> a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD
> xe.inf
> b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD
> xe.inf
> index 64814528..172280e8 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformD
> xe.inf
> +++ b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatf
> +++ ormDxe.inf
> @@ -23,6 +23,7 @@
> SecureBootBypass.c
> ExternalDeviceDmaProtection.c
> MorSupport.c
> + HstiIbvPlatformDxe.h
>
> [Packages]
> MdePkg/MdePkg.dec
> diff --git
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFce.inf
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFce.inf
> index fd80c611..ad8882fe 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFce.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV
> +++ ariableLibFce.inf
> @@ -37,6 +37,8 @@
> [Sources]
> PeiHobVariableLibFce.c
> InternalCommonLib.c
> + Variable.h
> + Fce.h
>
> [Ppis]
> gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
> diff --git
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFceOptSize.inf
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFceOptSize.inf
> index 82d81c98..e1a76715 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVaria
> bleLibFceOptSize.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV
> +++ ariableLibFceOptSize.inf
> @@ -36,6 +36,8 @@
> [Sources]
> PeiHobVariableLibFceOptSize.c
> InternalCommonLib.c
> + Variable.h
> + Fce.h
>
> [Ppis]
> gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
> ntCheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
> ntCheckLib.inf
> index 62fceffb..76e193dc 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
> ntCheckLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTe
> +++ stPointCheckLib.inf
> @@ -68,6 +68,7 @@
> DxeCheckTcgMor.c
> DxeCheckDmaProtection.c
> TestPointHelp.c
> + TestPointInternal.h
>
> [Guids]
> gEfiMemoryAttributesTableGuid
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP
> ointCheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP
> ointCheckLib.inf
> index 6007fbc9..03d027ec 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestP
> ointCheckLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe
> +++ stPointCheckLib.inf
> @@ -45,6 +45,7 @@
> DxeCheckLoadedImage.c
> DxeCheckGcd.c
> TestPointHelp.c
> + TestPointInternal.h
>
> [Pcd]
> gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
2019-08-21 8:01 ` [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Zhang, Shenglei
@ 2019-08-23 17:32 ` Kubacki, Michael A
2019-08-23 18:11 ` Chaganty, Rangasai V
1 sibling, 0 replies; 9+ messages in thread
From: Kubacki, Michael A @ 2019-08-23 17:32 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Chaganty, Rangasai V, Gao, Liming
Please extend the copyright date in SmbiosDxe.inf to 2019. With that change:
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 1:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing
> header file in INF
>
> The header file is used but missing in INF,which causes warning message when
> building them.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2037
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx
> e.inf
> b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx
> e.inf
> index 69e930dd..bbac1d5c 100644
> ---
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx
> e.inf
> +++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
> +++ cDxe.inf
> @@ -23,6 +23,7 @@
>
> [Sources]
> SmbiosBasicEntryPoint.c
> + SmbiosBasic.h
> Type0BiosVendorFunction.c
> Type1SystemManufacturerFunction.c
> Type2BaseBoardManufacturerFunction.c
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files
2019-08-21 8:01 ` [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Zhang, Shenglei
2019-08-21 8:09 ` Chiu, Chasel
@ 2019-08-23 17:33 ` Kubacki, Michael A
2019-08-23 21:55 ` Nate DeSimone
2 siblings, 0 replies; 9+ messages in thread
From: Kubacki, Michael A @ 2019-08-23 17:33 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Cc: Chiu, Chasel, Desimone, Nathaniel L, Gao, Liming
Please extend the copyright date in all files touched to 2019. With that change:
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 1:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing
> header files in INF files
>
> The header files are used but missing in INF,which causes warning message
> when building them.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2037
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .../MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf | 1 +
> .../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 1 +
> .../Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf | 1 +
> .../Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf | 2 ++
> .../PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf | 2 ++
> .../Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf | 1 +
> .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf | 1 +
> 7 files changed, 9 insertions(+)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> index cca7de94..4c5202f9 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
> +++ b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm
> +++ .inf
> @@ -50,6 +50,7 @@
> [Sources]
> Common/SpiFvbServiceCommon.c
> Common/FvbInfo.c
> + Common/SpiFvbServiceCommon.h
> Smm/SpiFvbServiceSmm.c
>
> [Protocols]
> diff --git
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor
> mSecLib/SecFspWrapperPlatformSecLib.inf
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor
> mSecLib/SecFspWrapperPlatformSecLib.inf
> index 5d77e9e4..3f5a63f2 100644
> ---
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatfor
> mSecLib/SecFspWrapperPlatformSecLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat
> +++ formSecLib/SecFspWrapperPlatformSecLib.inf
> @@ -41,6 +41,7 @@
> SecGetPerformance.c
> SecTempRamDone.c
> PlatformInit.c
> + FsptCoreUpd.h
>
> [Sources.IA32]
> Ia32/SecEntry.nasm
> diff --git
> a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.
> inf
> b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.
> inf
> index 64814528..172280e8 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.
> inf
> +++ b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatf
> +++ ormDxe.inf
> @@ -23,6 +23,7 @@
> SecureBootBypass.c
> ExternalDeviceDmaProtection.c
> MorSupport.c
> + HstiIbvPlatformDxe.h
>
> [Packages]
> MdePkg/MdePkg.dec
> diff --git
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariabl
> eLibFce.inf
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariabl
> eLibFce.inf
> index fd80c611..ad8882fe 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariabl
> eLibFce.inf
> +++ b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV
> +++ ariableLibFce.inf
> @@ -37,6 +37,8 @@
> [Sources]
> PeiHobVariableLibFce.c
> InternalCommonLib.c
> + Variable.h
> + Fce.h
>
> [Ppis]
> gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
> diff --git
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariabl
> eLibFceOptSize.inf
> b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariabl
> eLibFceOptSize.inf
> index 82d81c98..e1a76715 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariabl
> eLibFceOptSize.inf
> +++ b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV
> +++ ariableLibFceOptSize.inf
> @@ -36,6 +36,8 @@
> [Sources]
> PeiHobVariableLibFceOptSize.c
> InternalCommonLib.c
> + Variable.h
> + Fce.h
>
> [Ppis]
> gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoint
> CheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoint
> CheckLib.inf
> index 62fceffb..76e193dc 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoint
> CheckLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTe
> +++ stPointCheckLib.inf
> @@ -68,6 +68,7 @@
> DxeCheckTcgMor.c
> DxeCheckDmaProtection.c
> TestPointHelp.c
> + TestPointInternal.h
>
> [Guids]
> gEfiMemoryAttributesTableGuid
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPoin
> tCheckLib.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPoi
> ntCheckLib.inf
> index 6007fbc9..03d027ec 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPoin
> tCheckLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe
> +++ stPointCheckLib.inf
> @@ -45,6 +45,7 @@
> DxeCheckLoadedImage.c
> DxeCheckGcd.c
> TestPointHelp.c
> + TestPointInternal.h
>
> [Pcd]
> gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
2019-08-21 8:01 ` [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Zhang, Shenglei
2019-08-23 17:32 ` Kubacki, Michael A
@ 2019-08-23 18:11 ` Chaganty, Rangasai V
2019-08-27 1:31 ` Zhang, Shenglei
1 sibling, 1 reply; 9+ messages in thread
From: Chaganty, Rangasai V @ 2019-08-23 18:11 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Kubacki, Michael A, Gao, Liming
Have you tried adding the path in AdvancedFeaturePkg.dec under [Includes] section?
-----Original Message-----
From: Zhang, Shenglei
Sent: Wednesday, August 21, 2019 1:01 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
The header file is used but missing in INF,which causes warning message when building them.
https://bugzilla.tianocore.org/show_bug.cgi?id=2037
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
index 69e930dd..bbac1d5c 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
+++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
+++ cDxe.inf
@@ -23,6 +23,7 @@
[Sources]
SmbiosBasicEntryPoint.c
+ SmbiosBasic.h
Type0BiosVendorFunction.c
Type1SystemManufacturerFunction.c
Type2BaseBoardManufacturerFunction.c
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files
2019-08-21 8:01 ` [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Zhang, Shenglei
2019-08-21 8:09 ` Chiu, Chasel
2019-08-23 17:33 ` Kubacki, Michael A
@ 2019-08-23 21:55 ` Nate DeSimone
2 siblings, 0 replies; 9+ messages in thread
From: Nate DeSimone @ 2019-08-23 21:55 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io
Cc: Kubacki, Michael A, Chiu, Chasel, Gao, Liming
With copyright change noted by other reviewers...
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Zhang, Shenglei
Sent: Wednesday, August 21, 2019 1:01 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files
The header files are used but missing in INF,which causes warning message when building them.
https://bugzilla.tianocore.org/show_bug.cgi?id=2037
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf | 1 +
.../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 1 +
.../Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf | 1 +
.../Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf | 2 ++
.../PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf | 2 ++
.../Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf | 1 +
.../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf | 1 +
7 files changed, 9 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
index cca7de94..4c5202f9 100644
--- a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf
+++ b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm
+++ .inf
@@ -50,6 +50,7 @@
[Sources]
Common/SpiFvbServiceCommon.c
Common/FvbInfo.c
+ Common/SpiFvbServiceCommon.h
Smm/SpiFvbServiceSmm.c
[Protocols]
diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
index 5d77e9e4..3f5a63f2 100644
--- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
+++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat
+++ formSecLib/SecFspWrapperPlatformSecLib.inf
@@ -41,6 +41,7 @@
SecGetPerformance.c
SecTempRamDone.c
PlatformInit.c
+ FsptCoreUpd.h
[Sources.IA32]
Ia32/SecEntry.nasm
diff --git a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
index 64814528..172280e8 100644
--- a/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf
+++ b/Platform/Intel/MinPlatformPkg/Hsti/HstiIbvPlatformDxe/HstiIbvPlatf
+++ ormDxe.inf
@@ -23,6 +23,7 @@
SecureBootBypass.c
ExternalDeviceDmaProtection.c
MorSupport.c
+ HstiIbvPlatformDxe.h
[Packages]
MdePkg/MdePkg.dec
diff --git a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf
index fd80c611..ad8882fe 100644
--- a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFce.inf
+++ b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV
+++ ariableLibFce.inf
@@ -37,6 +37,8 @@
[Sources]
PeiHobVariableLibFce.c
InternalCommonLib.c
+ Variable.h
+ Fce.h
[Ppis]
gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
diff --git a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf
index 82d81c98..e1a76715 100644
--- a/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobVariableLibFceOptSize.inf
+++ b/Platform/Intel/MinPlatformPkg/Library/PeiHobVariableLibFce/PeiHobV
+++ ariableLibFceOptSize.inf
@@ -36,6 +36,8 @@
[Sources]
PeiHobVariableLibFceOptSize.c
InternalCommonLib.c
+ Variable.h
+ Fce.h
[Ppis]
gEfiPeiMemoryDiscoveredPpiGuid ## NOTIFY
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
index 62fceffb..76e193dc 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPointCheckLib.inf
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTe
+++ stPointCheckLib.inf
@@ -68,6 +68,7 @@
DxeCheckTcgMor.c
DxeCheckDmaProtection.c
TestPointHelp.c
+ TestPointInternal.h
[Guids]
gEfiMemoryAttributesTableGuid
diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
index 6007fbc9..03d027ec 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe
+++ stPointCheckLib.inf
@@ -45,6 +45,7 @@
DxeCheckLoadedImage.c
DxeCheckGcd.c
TestPointHelp.c
+ TestPointInternal.h
[Pcd]
gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
2019-08-23 18:11 ` Chaganty, Rangasai V
@ 2019-08-27 1:31 ` Zhang, Shenglei
0 siblings, 0 replies; 9+ messages in thread
From: Zhang, Shenglei @ 2019-08-27 1:31 UTC (permalink / raw)
To: Chaganty, Rangasai V, devel@edk2.groups.io
Cc: Kubacki, Michael A, Gao, Liming
Actually we didn't do that. SmbiosBasic.h is only used by c files in its directory and not used in other packages.
Thanks,
Shenglei
> -----Original Message-----
> From: Chaganty, Rangasai V
> Sent: Saturday, August 24, 2019 2:12 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: RE: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a
> missing header file in INF
>
> Have you tried adding the path in AdvancedFeaturePkg.dec under [Includes]
> section?
>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 1:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing
> header file in INF
>
> The header file is used but missing in INF,which causes warning message when
> building them.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2037
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD
> xe.inf
> b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD
> xe.inf
> index 69e930dd..bbac1d5c 100644
> ---
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicD
> xe.inf
> +++
> b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
> +++ cDxe.inf
> @@ -23,6 +23,7 @@
>
> [Sources]
> SmbiosBasicEntryPoint.c
> + SmbiosBasic.h
> Type0BiosVendorFunction.c
> Type1SystemManufacturerFunction.c
> Type2BaseBoardManufacturerFunction.c
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-08-27 1:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-21 8:01 [edk2-platform PATCH 0/2] Fix warning message issues Zhang, Shenglei
2019-08-21 8:01 ` [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Zhang, Shenglei
2019-08-23 17:32 ` Kubacki, Michael A
2019-08-23 18:11 ` Chaganty, Rangasai V
2019-08-27 1:31 ` Zhang, Shenglei
2019-08-21 8:01 ` [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Zhang, Shenglei
2019-08-21 8:09 ` Chiu, Chasel
2019-08-23 17:33 ` Kubacki, Michael A
2019-08-23 21:55 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox