From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Bw6cEDqd; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Tue, 27 Aug 2019 03:18:37 -0700 Received: by mail-wm1-f66.google.com with SMTP id d16so2406245wme.2 for ; Tue, 27 Aug 2019 03:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SjklHz4e1PEY/FzA4Jz1hfW2IzxWkCIIACzbn32TJ/M=; b=Bw6cEDqdtVit+QrJaj0mep9Y2NHGFaGRdN4XozOllWEEbJnVHuiaTNO8Z6LM/ZQZCB 2Sc7LxdpMs+y+tL5vt0XY/Pb97v+/1MCvEnR0TvUibI9HRaTrpBo5PSrXANUcQwV++Lo uxbrd9+sy1+6NmsR/l/lDY2DA/qZ8MrbipXXPOUNtvNU7AfbiSA6PwxDeJp6bZUAWMEN veaKPMm2OrR6/vnBx0zzyN0xKw3WHisrRxB5rq4vc3zi1vF261wlDGnPc+xpKZ7lU9mL jTeJ6DIxup9cZ/vqG+Ts323ggMn2ETzQg9oOwI1ZzIoJHl5WSZ/ZoG6ozkr9BgN6/27y kE8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SjklHz4e1PEY/FzA4Jz1hfW2IzxWkCIIACzbn32TJ/M=; b=udkprRlaDIRu2cWYaKbJxLdrcb8gawD9Ga7CGBCJGLNchHE+PI4QL5FKb+wFPrFs+3 NJ4Ts7PVQF0OfHsh6MieZrIuPga2pT4rTCFKEoemTYjpNDV3coeEjU66Jm8BZS8E6BC/ iK19ncdszMY/7xCpeQhH3YWNnefv+FT9oR8TvA7AGCHlw8S5DVP9lXDR260kPzyoJOgA ugZYhgtBE/JxgXM30EK4MQREaIa7sPO4B1lu5oAdBSRmrT7XDSq/lUkQ4bt7TTYhRs9n 9+PHgSVN5zND2OpBrUApOVNrkEwrvnHORI0i0DZrQaaDyG9o1zHwZLfuKQj2273V3ZX6 pmPg== X-Gm-Message-State: APjAAAXQrxAxP7QLrCM2+mZDoGy738LaxLToJmkE6uATTUyQ45CuaJu4 2PnUlq4gAwwLAT+Ce39Fu6qj8w== X-Google-Smtp-Source: APXvYqwynpMEJT90rJ5BeYhgB2Wz2iiR2/I+2inie2nUwzdhlF5xAtoPV8fXIpa/KVA6T/O4f1Q/uw== X-Received: by 2002:a7b:cf11:: with SMTP id l17mr26746389wmg.158.1566901115509; Tue, 27 Aug 2019 03:18:35 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e11sm39845054wrc.4.2019.08.27.03.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2019 03:18:34 -0700 (PDT) Date: Tue, 27 Aug 2019 11:18:33 +0100 From: "Leif Lindholm" To: "Ni, Ray" Cc: "Kinney, Michael D" , "Gao, Liming" , "devel@edk2.groups.io" , "afish@apple.com" , "Laszlo Ersek (lersek@redhat.com)" Subject: Re: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList Message-ID: <20190827101833.GW29255@bivouac.eciton.net> References: <15BE8BCCADEA547C.18314@groups.io> <734D49CCEBEEF84792F5B80ED585239D5C29AD17@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC923@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C29CEF9@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C29CEF9@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Understood. But that also means they depend on a well tested open source repo. So I agree with Mike - the value of getting it into the stable tag would be defeated by getting it in too late for useful testing. I would prefer for it to go into after the stable tag. However, that is my procedural opinion. The diff is trivial. So I am not not saying "no", only that my preference would be to merge it after the tag. Best Regards, Leif On Tue, Aug 27, 2019 at 12:45:54AM +0000, Ni, Ray wrote: > The consumers are in close source and won't be in open source in near future. > But consumers depend on open source repo. > > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Monday, August 26, 2019 5:20 PM > > To: Gao, Liming ; Ni, Ray ; devel@edk2.groups.io; Kinney, Michael D > > > > Cc: afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek (lersek@redhat.com) > > Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type > > EfiBluetoothSmpPeerAddressList > > > > Ray, > > > > Are there any components that need these new enum values? > > > > The patch looks very straightforward and is from the > > UEFI Spec, so I think the risk is low. But if consumers > > will not show up until after the stable tag, perhaps this > > should be one of the first patches after the stable tag. > > > > Thanks, > > > > Mike > > > > > -----Original Message----- > > > From: Gao, Liming > > > Sent: Monday, August 26, 2019 4:57 PM > > > To: Ni, Ray ; devel@edk2.groups.io > > > Cc: Kinney, Michael D ; > > > afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek > > > (lersek@redhat.com) > > > Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] > > > MdePkg/BluetoothLeConfig.h: Add type > > > EfiBluetoothSmpPeerAddressList > > > > > > Cc to all Stewards. > > > > > > >-----Original Message----- > > > >From: Ni, Ray > > > >Sent: Tuesday, August 27, 2019 2:20 AM > > > >To: devel@edk2.groups.io; Ni, Ray > > > >Cc: Kinney, Michael D ; > > > Gao, Liming > > > > > > > >Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] > > > >MdePkg/BluetoothLeConfig.h: Add type > > > EfiBluetoothSmpPeerAddressList > > > > > > > >I understand it's now in code freeze phase. > > > >Just make a try to see whether this very clean/simple > > > header file > > > >change can be included in the stable tag. > > > >Any platform that uses BLE stack can get benefit from > > > this definition update. > > > > > > > >> -----Original Message----- > > > >> From: devel@edk2.groups.io On > > > Behalf Of Ni, > > > >> Ray > > > >> Sent: Monday, August 26, 2019 11:16 AM > > > >> To: devel@edk2.groups.io > > > >> Cc: Kinney, Michael D ; > > > Gao, Liming > > > > > > > >> Subject: [edk2-devel] [PATCH] [edk2-stable201908] > > > >MdePkg/BluetoothLeConfig.h: Add type > > > EfiBluetoothSmpPeerAddressList > > > >> > > > >> To support auto-connection, > > > EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs > > > >to > > > >> add a new data type EfiBluetoothSmpPeerAddressList > > > which associates > > > >> with a list of Bluetooth per address connected > > > before. > > > >> > > > >> This new data type was added in UEFI spec 2.7b. > > > >> > > > >> Signed-off-by: Ray Ni > > > >> Cc: Michael D Kinney > > > >> Cc: Liming Gao > > > >> --- > > > >> MdePkg/Include/Protocol/BluetoothLeConfig.h | 4 +++- > > > >> 1 file changed, 3 insertions(+), 1 deletion(-) > > > >> > > > >> diff --git > > > a/MdePkg/Include/Protocol/BluetoothLeConfig.h > > > >b/MdePkg/Include/Protocol/BluetoothLeConfig.h > > > >> index 8c0f881f85..8726a58b15 100644 > > > >> --- a/MdePkg/Include/Protocol/BluetoothLeConfig.h > > > >> +++ b/MdePkg/Include/Protocol/BluetoothLeConfig.h > > > >> @@ -2,7 +2,7 @@ > > > >> EFI Bluetooth LE Config Protocol as defined in > > > UEFI 2.7. > > > >> This protocol abstracts user interface > > > configuration for BluetoothLe device. > > > >> > > > >> - Copyright (c) 2017, Intel Corporation. All rights > > > reserved.
> > > >> + Copyright (c) 2017 - 2019, Intel Corporation. All > > > rights > > > >> + reserved.
> > > >> SPDX-License-Identifier: BSD-2-Clause-Patent > > > >> > > > >> @par Revision Reference: > > > >> @@ -451,6 +451,8 @@ typedef enum { > > > >> EfiBluetoothSmpLocalCSRK, /* If Key hierarchy not > > > supported */ > > > >> EfiBluetoothSmpLocalSignCounter, > > > >> EfiBluetoothSmpLocalDIV, > > > >> + EfiBluetoothSmpPeerAddressList, > > > >> + EfiBluetoothSmpMax, > > > >> } EFI_BLUETOOTH_LE_SMP_DATA_TYPE; > > > >> > > > >> /** > > > >> -- > > > >> 2.21.0.windows.1 > > > >> > > > >> > > > >> >