edk2-stable201908 Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

edk2-stable201908 Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

[Leif Lindholm]

Apologies, forgot to tag the subject for stable release (although I
did remember to cc the stewards).

We don't appear to have a fix version for edk2-stable201908 in
bugzilla, though.

On Tue, Aug 27, 2019 at 01:43:28PM +0100, Leif Lindholm via Groups.Io wrote:
> Commit 4a1f6b85c184
> ("MdeModulePkg: add LockBoxNullLib for !IA32/X64 in .dsc")
> added an ARM/AARCH64 resolution for LockBoxLib. However, this failed
> to address the overrides provided for PEIM, DXE_DRIVER,
> DXE_RUNTIME_DRIVER, DXE_SMM_DRIVER and UEFI_DRIVER, so any modules
> of those classes still failed to build.
> 
> Break these out properly into their own LibraryClasses sections.
> 
> Resolves BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2134
> 
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> Reported-by: Baptiste Gerondeau <baptiste.gerondeau@linaro.org>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> ---
> 
> I don't understand how the above would appear to work back when I
> submitted the previous patch but not work now, but I haven't dug
> into it deeper. Including the x86-specific LockBoxLib in the
> .common section is however clearly not correct.
> 
> I think a fix for this issue needs to go into 2019.08, but if
> someone has a prettier suggestion, I am not wedded to this one.
> 
>  MdeModulePkg/MdeModulePkg.dsc | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index 4320839abfb5..15ba96cecbed 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -109,6 +109,8 @@ [LibraryClasses.common.PEIM]
>    HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
>    MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
>    ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
> +
> +[LibraryClasses.IA32.PEIM,LibraryClasses.X64.PEIM]
>    LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
>  
>  [LibraryClasses.common.DXE_CORE]
> @@ -118,18 +120,22 @@ [LibraryClasses.common.DXE_CORE]
>  
>  [LibraryClasses.common.DXE_DRIVER]
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> -  LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>    MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>    ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
>  
> +[LibraryClasses.IA32.DXE_DRIVER,LibraryClasses.X64.DXE_DRIVER]
> +  LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
> +
>  [LibraryClasses.common.DXE_RUNTIME_DRIVER]
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
>    MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>    DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> -  LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
>  
> +[LibraryClasses.IA32.DXE_RUNTIME_DRIVER,LibraryClasses.X64.DXE_RUNTIME_DRIVER]
> +  LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
> +
>  [LibraryClasses.common.SMM_CORE]
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
>    MemoryAllocationLib|MdeModulePkg/Library/PiSmmCoreMemoryAllocationLib/PiSmmCoreMemoryAllocationLib.inf
> @@ -143,13 +149,17 @@ [LibraryClasses.common.DXE_SMM_DRIVER]
>    MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf
>    MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf
>    SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf
> +  SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
> +
> +[LibraryClasses.IA32.DXE_SMM_DRIVER,LibraryClasses.X64.DXE_SMM_DRIVER]
>    LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxSmmLib.inf
> -  SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
>  
>  [LibraryClasses.common.UEFI_DRIVER]
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
>    MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>    DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> +
> +[LibraryClasses.IA32.UEFI_DRIVER,LibraryClasses.X64.UEFI_DRIVER]
>    LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>  
>  [LibraryClasses.common.UEFI_APPLICATION]
> -- 
> 2.20.1
> 
> 
> 
> 

Re: edk2-stable201908 Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

[Laszlo Ersek]

On 08/27/19 17:50, Leif Lindholm wrote:
> Apologies, forgot to tag the subject for stable release (although I
> did remember to cc the stewards).

Understood, thus far... (And I commented on the target release under
your original submission.)

> We don't appear to have a fix version for edk2-stable201908 in
> bugzilla, though.

I don't get this paragraph. What is "fix version for edk2-stable201908"?

Thanks
Laszlo

Re: edk2-stable201908 Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

[Leif Lindholm]

On Tue, Aug 27, 2019 at 09:28:50PM +0200, Laszlo Ersek wrote:
> On 08/27/19 17:50, Leif Lindholm wrote:
> > Apologies, forgot to tag the subject for stable release (although I
> > did remember to cc the stewards).
> 
> Understood, thus far... (And I commented on the target release under
> your original submission.)
> 
> > We don't appear to have a fix version for edk2-stable201908 in
> > bugzilla, though.
> 
> I don't get this paragraph. What is "fix version for edk2-stable201908"?

The freeze announcement said bugzillas aiming for inclusion in the
stable tag should also be marked accordingly.

I choose to interpret this as the "Release(s) the issues must be
fixed:" field should be set to the corresponding target release tag.
But the most recent version selectable there is edk2-stable201905.

/
    Leif

Re: edk2-stable201908 Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

[Laszlo Ersek]

On 08/27/19 21:41, Leif Lindholm wrote:
> On Tue, Aug 27, 2019 at 09:28:50PM +0200, Laszlo Ersek wrote:
>> On 08/27/19 17:50, Leif Lindholm wrote:
>>> Apologies, forgot to tag the subject for stable release (although I
>>> did remember to cc the stewards).
>>
>> Understood, thus far... (And I commented on the target release under
>> your original submission.)
>>
>>> We don't appear to have a fix version for edk2-stable201908 in
>>> bugzilla, though.
>>
>> I don't get this paragraph. What is "fix version for edk2-stable201908"?
> 
> The freeze announcement said bugzillas aiming for inclusion in the
> stable tag should also be marked accordingly.
> 
> I choose to interpret this as the "Release(s) the issues must be
> fixed:" field should be set to the corresponding target release tag.
> But the most recent version selectable there is edk2-stable201905.

I see. Indeed I've only briefly skimmed the new values once (beyond the
earlier "Master" and "UDK*" entries).

Thanks!
Laszlo